* [PATCH] OvmfPkg/build.sh: run qemu _after_ building OvmfPkg
@ 2019-07-24 1:20 rebecca
2019-07-24 2:40 ` [edk2-devel] " Jordan Justen
0 siblings, 1 reply; 3+ messages in thread
From: rebecca @ 2019-07-24 1:20 UTC (permalink / raw)
To: devel, Jordan Justen, Laszlo Ersek, Ard Biesheuvel; +Cc: Rebecca Cran
Running qemu before building the firmware image doesn't make much sense.
Move things so qemu is run after building OvmfPkg.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
OvmfPkg/build.sh | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 1c28e65404..a2c4eff2a5 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -256,6 +256,11 @@ else
echo using prebuilt tools
fi
+#
+# Build the edk2 OvmfPkg
+#
+echo Running edk2 build for OvmfPkg$Processor
+build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER
if [[ "$RUN_QEMU" == "yes" ]]; then
if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then
@@ -275,10 +280,4 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
exit $?
fi
-#
-# Build the edk2 OvmfPkg
-#
-echo Running edk2 build for OvmfPkg$Processor
-build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER
exit $?
-
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg/build.sh: run qemu _after_ building OvmfPkg
2019-07-24 1:20 [PATCH] OvmfPkg/build.sh: run qemu _after_ building OvmfPkg rebecca
@ 2019-07-24 2:40 ` Jordan Justen
2019-07-24 21:33 ` rebecca
0 siblings, 1 reply; 3+ messages in thread
From: Jordan Justen @ 2019-07-24 2:40 UTC (permalink / raw)
To: Ard Biesheuvel, Laszlo Ersek, devel, rebecca; +Cc: Rebecca Cran
On 2019-07-23 18:20:31, wrote:
> Running qemu before building the firmware image doesn't make much sense.
> Move things so qemu is run after building OvmfPkg.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/build.sh | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 1c28e65404..a2c4eff2a5 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -256,6 +256,11 @@ else
> echo using prebuilt tools
> fi
>
> +#
> +# Build the edk2 OvmfPkg
> +#
> +echo Running edk2 build for OvmfPkg$Processor
> +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER
>
> if [[ "$RUN_QEMU" == "yes" ]]; then
> if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then
> @@ -275,10 +280,4 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
> exit $?
We exit after running qemu. In other words, if qemu is present on the
command line, then we run qemu, but don't try to build OVMF.
One use case for running qemu multiple times without building is to
preserve non-volatile variables across multiple qemu boots.
-Jordan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg/build.sh: run qemu _after_ building OvmfPkg
2019-07-24 2:40 ` [edk2-devel] " Jordan Justen
@ 2019-07-24 21:33 ` rebecca
0 siblings, 0 replies; 3+ messages in thread
From: rebecca @ 2019-07-24 21:33 UTC (permalink / raw)
To: Jordan Justen, Ard Biesheuvel, Laszlo Ersek, devel
On 2019-07-23 20:40, Jordan Justen wrote:
>
> We exit after running qemu. In other words, if qemu is present on the
> command line, then we run qemu, but don't try to build OVMF.
>
> One use case for running qemu multiple times without building is to
> preserve non-volatile variables across multiple qemu boots.
Oh! I thought the use case for having qemu in build.sh was to run it
against the newly-built firmware. Since that's not the case, just ignore
this patch.
--
Rebecca Cran
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-24 21:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24 1:20 [PATCH] OvmfPkg/build.sh: run qemu _after_ building OvmfPkg rebecca
2019-07-24 2:40 ` [edk2-devel] " Jordan Justen
2019-07-24 21:33 ` rebecca
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox