public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Dandan Bi <dandan.bi@intel.com>, edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>
Subject: Re: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure
Date: Wed, 7 Feb 2018 11:29:09 +0800	[thread overview]
Message-ID: <a7b09585-7eb8-9acb-bac1-44b33012a649@Intel.com> (raw)
In-Reply-To: <1517967056-18112-1-git-send-email-dandan.bi@intel.com>

On 2/7/2018 9:30 AM, Dandan Bi wrote:
> Initialize local variable to suppress warning C4703:
> potentially uninitialized local pointer variable.
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>   MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> index c48e3bb..13221b9 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> @@ -242,10 +242,12 @@ PciBusDriverBindingStart (
>   {
>     EFI_STATUS                      Status;
>     EFI_DEVICE_PATH_PROTOCOL        *ParentDevicePath;
>     EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL *PciRootBridgeIo;
>   
> +  PciRootBridgeIo = NULL;
> +
>     //
>     // Check RemainingDevicePath validation
>     //
>     if (RemainingDevicePath != NULL) {
>       //
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thank you very much!!

-- 
Thanks,
Ray


      parent reply	other threads:[~2018-02-07  3:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07  1:30 [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure Dandan Bi
2018-02-07  1:44 ` Zeng, Star
2018-02-07  1:58   ` Bi, Dandan
     [not found]   ` <2d354a20-80eb-f0e4-25dc-3f19f9828c88@redhat.com>
2018-02-07  8:25     ` Bi, Dandan
2018-02-07  3:29 ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7b09585-7eb8-9acb-bac1-44b33012a649@Intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox