public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Lendacky, Thomas" <thomas.lendacky@amd.com>
To: devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Ashish Kalra <Ashish.Kalra@amd.com>
Subject: Re: [PATCH 0/2] SEV-SNP guest support fixes
Date: Fri, 10 Mar 2023 11:08:26 -0600	[thread overview]
Message-ID: <a7e90e14-b801-d4c7-412e-241d12b37458@amd.com> (raw)
In-Reply-To: <cover.1678467840.git.thomas.lendacky@amd.com>

On 3/10/23 11:03, Tom Lendacky wrote:
> This patch series provides some fixes around AP creation:
> 
> - An erratum on AMD hardware requires that a VMSA not be aligned on a
>    2MB boundary. To work around this issue, allocate 2 pages of memory
>    and using the page that is not 2MB aligned and freeing the other.
> 
> - When parking APs after exiting boot services, the current SNP support
>    will perform an allocation that will not be reflected in memory map
>    being supplied to the OS. Instead of allocating new VMSAs each time,
>    re-use the current VMSA.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4353
> 
> ---
> 
> These patches are based on commit:
> f80f052277c8 ("OvmfPkg/RiscVVirt: Add Stack HOB")

Specified the wrong commit here...  should be:

9b94ebb0c826 ("DynamicTablesPkg: Add SMBIOS String table helper library")

Also, the first patch has a #define for IS_ALIGNED, which Gerd is trying 
to address with another patch series. Once his series is merged, I'll 
re-submit with the removal of the #define, but wanted to get this out for 
review now.

Thanks,
Tom

> 
> Cc:	Eric Dong <eric.dong@intel.com>
> Cc:	Ray Ni <ray.ni@intel.com>
> Cc:	Rahul Kumar <rahul1.kumar@intel.com>
> Cc:	Gerd Hoffmann <kraxel@redhat.com>
> Cc:	Michael Roth <michael.roth@amd.com>
> Cc:	Ashish Kalra <Ashish.Kalra@amd.com>
> 
> Tom Lendacky (2):
>    UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB
>      aligned
>    UefiCpuPkg/MpInitLib: Reuse VMSA allocation to avoid unreserved
>      allocation
> 
>   UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c | 224 ++++++++++++++--------
>   1 file changed, 144 insertions(+), 80 deletions(-)
> 

      parent reply	other threads:[~2023-03-10 17:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 17:03 [PATCH 0/2] SEV-SNP guest support fixes Lendacky, Thomas
2023-03-10 17:03 ` [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned Lendacky, Thomas
2023-03-13  8:00   ` Gerd Hoffmann
2023-03-13  8:31     ` Ni, Ray
2023-03-13 14:15     ` Lendacky, Thomas
2023-03-13  8:28   ` Ni, Ray
2023-03-13  8:45     ` Gerd Hoffmann
2023-03-13  8:47       ` [edk2-devel] " Ni, Ray
2023-03-13 13:42     ` Lendacky, Thomas
2023-03-10 17:04 ` [PATCH 2/2] UefiCpuPkg/MpInitLib: Reuse VMSA allocation to avoid unreserved allocation Lendacky, Thomas
2023-03-10 17:08 ` Lendacky, Thomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7e90e14-b801-d4c7-412e-241d12b37458@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox