From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.2712.1587376012107662390 for ; Mon, 20 Apr 2020 02:46:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ekmYi/4l; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587376011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8yPQIb4nBCGvICS7uqEo0DeueS3tusD98dCYiJ/aheg=; b=ekmYi/4lKoD1Gb5+1ZMOpeDiUrgyuzNH1OWVZJF2jvYTrEaCqDYsNG8dgD6QFyovHq6Bu0 QC56UEzR2SYn4miCpuRpouFzPQ+ncxqilPygio1Gcy2ZfMi/QABO9BFlR7aB2s3MiD7UpV t8qHglHw8atQSjJVKUUVOhKn5YMdjPc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-rUkgCZrINzqh7DBSEqk60w-1; Mon, 20 Apr 2020 05:46:45 -0400 X-MC-Unique: rUkgCZrINzqh7DBSEqk60w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6EE119057B6; Mon, 20 Apr 2020 09:46:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-228.ams2.redhat.com [10.36.114.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id A09AF5DA85; Mon, 20 Apr 2020 09:46:41 +0000 (UTC) Subject: Re: [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix To: Ard Biesheuvel , edk2-devel-groups-io Cc: Anthony Perard , Jordan Justen , Julien Grall , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Rebecca Cran References: <20200417153751.7110-1-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 20 Apr 2020 11:46:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/17/20 17:59, Ard Biesheuvel wrote: > On 4/17/20 5:37 PM, Laszlo Ersek wrote: >> Ref:=C2=A0=C2=A0=C2=A0 https://bugzilla.tianocore.org/show_bug.cgi?id=3D= 2675 >> Repo:=C2=A0=C2=A0 https://pagure.io/lersek/edk2.git >> Branch: rsl_cleanup >> >> Rebecca's >> >> =C2=A0=C2=A0 [PATCH 02/13] OvmfPkg: support powering off bhyve guests >> >> at >> >> =C2=A0=C2=A0 https://edk2.groups.io/g/devel/message/57450 >> =C2=A0=C2=A0 >> http://mid.mail-archive.com/e4e9b29189b83076e1d1a0b9c989938f5226cab6.158= 6991816.git.rebecca@bsdio.com >> >> >> made me realize OvmfPkg/ResetSystemLib should be refreshed. This will >> let us add a simple bhyve-specific instance (later), and also allows us >> to fix a long time dormant bug (now). >> >> Cc: Anthony Perard >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Julien Grall >> Cc: Philippe Mathieu-Daud=C3=A9 >> Cc: Rebecca Cran >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (6): >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: wrap long lines >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: clean up library dependencies >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: improve coding style in ResetSystem= () >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: factor out ResetShutdown() >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: rename to BaseResetSystemLib >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: introduce the DxeResetSystemLib ins= tance >> >=20 > For the series, >=20 > Reviewed-by: Ard Biesheuvel >=20 > One nit: putting a diff block inside the commit log [6/6] doesn't help > legibility a lot, and the issue of not being able to access memory that > is not mapped for runtime is so basic that it doesn't require that level > of detail to describe a reproducer and the Linux kernel log output when > the issue is triggered. Thanks! I will remove the third note altogether (the one that starts with "The bug is not easy to trigger in common setups..."). Thanks! Laszlo