From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5DBFF78003C for ; Tue, 9 Jan 2024 16:15:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5OcYQZOukbDQLLHRT1CdaUQB3nlW33c5lcw30xKX8Is=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704816939; v=1; b=Rx1VSXwayrXGsZy2CiUTpbsMnFu4Cj3HA012elRu/WXCKQ6jrkf4ir0Ao4IwtquEolskXkUI zDqaDj7hPD41bRx5XzCrNFl+8vEnkJnZfnYfeC4JgQGNZX5YCOIZoz39dELDaNaheHWaPUTZc8z giSTCny2/PbyAOdAebSnDttg= X-Received: by 127.0.0.2 with SMTP id nVV3YY7687511xVfVXiGEsIk; Tue, 09 Jan 2024 08:15:39 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.20596.1704816937731994690 for ; Tue, 09 Jan 2024 08:15:38 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DCE96DA7; Tue, 9 Jan 2024 08:16:22 -0800 (PST) X-Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 88AC43F5A1; Tue, 9 Jan 2024 08:15:35 -0800 (PST) Message-ID: Date: Tue, 9 Jan 2024 17:15:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check To: Jeshua Smith , "devel@edk2.groups.io" Cc: "ardb+tianocore@kernel.org" , "quic_llindhol@quicinc.com" , "Sami.Mujawar@arm.com" , Shanker Donthineni , Vikram Sethi , Ashish Singhal References: From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YAi7y33k5JMQj4dlMcQu6OB2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Rx1VSXwa; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/9/24 16:47, Jeshua Smith wrote: >> From: Pierre Gondois >> Sent: Tuesday, January 9, 2024 1:22 AM >=20 >> On 1/8/24 19:12, Jeshua Smith wrote: >>> The code was incorrectly assuming that root nodes had to be physical >>> package nodes and vice versa. This is not always true, so the check is >>> being removed. >> >> Does it mean that you have a topology where the top-level node is not a >> physical package ? If yes, does it also mean that multiple physical pack= ages >> share a resource (which belong to the top-level node) ? >=20 > Yes, this change is due to the check incorrectly flagging our topology as= invalid. Simply removing the check fixed the problem for us. > =20 >> It is correct that the check is a bit stronger than what the specificati= on states, >> but it was handling all topologies so far, so would it be possible to de= scribe the >> topology that you have ? >=20 > Two physical packages are on a multi-chip module and share resources on t= he module. The module then plugs into the baseboard/motherboard. Is it possible to elaborate on the resource being shared ? Does it fall into the subject of this thread ? Some resources might be aswe= ll described in other ACPI tables. https://edk2.groups.io/g/devel/message/89121 >=20 > Note: While investigating this we noticed that another vendor also has a = similar PPTT topology to what is being flagged as invalid, so either that v= endor isn't using EDK2 or they have done something to avoid this check with= out submitting a patch to EDK2. This check is only present in the DynamicTablesPkg, so it shouldn't be too = restrictive. If the platform is known to use it, is it possible to share which platform = it is ? Regards, Pierre -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113456): https://edk2.groups.io/g/devel/message/113456 Mute This Topic: https://groups.io/mt/103603398/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-