From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com, "Kasbekar,
Saloni" <saloni.kasbekar@intel.com>,
Rebecca Cran <rebecca@bsdio.com>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"Kubacki, Michael" <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
Date: Fri, 31 May 2024 00:36:06 -0400 [thread overview]
Message-ID: <a81c0f50-5e5c-4cb5-a928-309d66fb9c43@linux.microsoft.com> (raw)
In-Reply-To: <CO1PR11MB4929ECE662462FE7AE22D234D2FC2@CO1PR11MB4929.namprd11.prod.outlook.com>
I do not see the commits now but given dependabot commits are the latest
in the master branch, I'd assume a branch was not rebased correctly.
Thanks,
Michael
On 5/30/2024 11:50 PM, Michael D Kinney wrote:
> Hi Michael,
>
> Do you know why there would be dependabot commits in PRs not related to dependabot updates?
>
> For example:
>
> https://github.com/tianocore/edk2/pull/5708/commits
>
> Thanks,
>
> Mike
>
>
>
>> -----Original Message-----
>> From: Kinney, Michael D <michael.d.kinney@intel.com>
>> Sent: Thursday, May 30, 2024 11:01 AM
>> To: Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io;
>> mikuback@linux.microsoft.com; Rebecca Cran <rebecca@bsdio.com>;
>> kraxel@redhat.com; Kubacki, Michael <michael.kubacki@microsoft.com>
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: RE: [edk2-devel] GitHub PR Code Review process now active
>>
>> Yes.
>>
>> Mike
>>
>>> -----Original Message-----
>>> From: Kasbekar, Saloni <saloni.kasbekar@intel.com>
>>> Sent: Thursday, May 30, 2024 10:39 AM
>>> To: devel@edk2.groups.io; mikuback@linux.microsoft.com; Kinney, Michael D
>>> <michael.d.kinney@intel.com>; Rebecca Cran <rebecca@bsdio.com>;
>>> kraxel@redhat.com; Kubacki, Michael <michael.kubacki@microsoft.com>
>>> Subject: RE: [edk2-devel] GitHub PR Code Review process now active
>>>
>>> How are we planning to handle packages (like NetworkPkg) without a
>>> maintainer? Would the stewards add in the reviewers in that case?
>>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
>>> Kubacki
>>> Sent: Wednesday, May 29, 2024 5:51 PM
>>> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io;
>>> Rebecca Cran <rebecca@bsdio.com>; kraxel@redhat.com; Kubacki, Michael
>>> <michael.kubacki@microsoft.com>
>>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>>>
>>> I've updated the wiki process to clarify that maintainers need to ensure PR
>>> reviewers are added and that a contributor cannot do so unless they are a
>>> maintainer in this update:
>>>
>>> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-
>>>
>> Process/_compare/b9d1f34e40d8ecbc7b59632302c9b0c823f52ab8...dd846b296754da310
>>> 03f8c2a70e9a0b861e600b6
>>>
>>> I did not include the @<github> ID process since there was not clear
>>> consensus on that. I think it's tedious and for this small window of time
>>> without automation, ideally the GitHub notifications mentioned earlier can
>> be
>>> used.
>>>
>>> Thanks,
>>> Michael
>>>
>>> On 5/29/2024 4:06 PM, Kinney, Michael D wrote:
>>>> We could, but that would require manually syncing CODEOWNERS with
>>>> Maintainer.txt until that part of the process is automated.
>>>>
>>>> We also need a way to verify that CODEOWNERS and Maintainers.txt
>>>> produce the exact same assignments.
>>>>
>>>> This was on the list of future enhancements when resources are
>>>> available to help. We need to focus on a process that works until
>>>> those automations can be deployed and supported.
>>>>
>>>> Mike
>>>>
>>>>> -----Original Message-----
>>>>> From: Michael Kubacki <mikuback@linux.microsoft.com>
>>>>> Sent: Wednesday, May 29, 2024 12:25 PM
>>>>> To: devel@edk2.groups.io; Kinney, Michael D
>>>>> <michael.d.kinney@intel.com>; Rebecca Cran <rebecca@bsdio.com>;
>>>>> kraxel@redhat.com; Kubacki, Michael <michael.kubacki@microsoft.com>
>>>>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>>>>>
>>>>> Mike,
>>>>>
>>>>> I agree that automatically adding reviewers would be helpful.
>>>>>
>>>>> Do you think we could add a CODEOWNERS file now to assist with this?
>>>>>
>>>>> Benefits being:
>>>>>
>>>>> 1. CODEOWNERS is low overhead in that GitHub already supports it.
>>>>>
>>>>> 2. We do not need to require CODEOWNER enforcement yet. We can simply
>>>>> use it for automating the process of adding maintainers.
>>>>>
>>>>> 3. Maintainers have write access so they are required to approve and
>>>>> add the push label. This would add a relevant maintainer(s) with
>>>>> write access to fulfill that role.
>>>>>
>>>>> Thanks,
>>>>> Michael
>>>>>
>>>>> On 5/29/2024 2:27 PM, Michael D Kinney wrote:
>>>>>> GitHub has notification settings. Maintainers should configure
>>>>>> GitHub so they are notified of all PR submissions to edk2 repo.
>>>>>>
>>>>>> The Wiki for the Maintainer Process provides a link to this page
>>>>>> with the
>>>>> details:
>>>>>>
>>>>>> https://docs.github.com/en/account-and-profile/managing-subscription
>>>>>> s-and-
>>>>> notifications-on-github/setting-up-notifications/configuring-notifica
>>>>> tions
>>>>>>
>>>>>> https://docs.github.com/en/account-and-profile/managing-subscription
>>>>>> s-and-
>>>>> notifications-on-github/setting-up-notifications/configuring-
>>>>> notifications#about-custom-notifications
>>>>>>
>>>>>> This allows Maintainers to receive notifications without being an
>>>>>> assigned reviewer.
>>>>>>
>>>>>> Mike
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: Rebecca Cran <rebecca@bsdio.com>
>>>>>>> Sent: Wednesday, May 29, 2024 11:19 AM
>>>>>>> To: devel@edk2.groups.io; Kinney, Michael D
>>>>>>> <michael.d.kinney@intel.com>; kraxel@redhat.com; Kubacki, Michael
>>>>>>> <michael.kubacki@microsoft.com>
>>>>>>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>>>>>>>
>>>>>>> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote:
>>>>>>>> Hi Gerd,
>>>>>>>>
>>>>>>>> We can clarify the Wiki. A Maintainer has to be involved in every
>>>>>>>> code review. The first action a Maintainer does is verify that
>>>>>>>> the code change should be considered at all or rejected. Then add
>>>>>>>> maintainers for the ones that look like good submissions.
>>>>>>>>
>>>>>>>> I agree that this may add a bit of delay. You are welcome to add
>>>>>>>> a comment with @<githubid> tags to the maintainers and reviewers
>>>>>>>> so they know to look at it and do the assignments. If you like
>>>>>>>> that idea we can add that to the Wiki as well.
>>>>>>>>
>>>>>>>> Since PRs can be also opened by outside contributors that have
>>>>>>>> limited access, maintainers have to be involved in reviewing newly
>>>>>>>> submitted PRs.
>>>>>>>
>>>>>>> "Then add maintainers for the ones that look like good submissions."
>>>>>>>
>>>>>>> Surely in order for the maintainers to know the PR should be looked
>>>>>>> at in the first place they need to already be added?
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Rebecca Cran
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>
>>>
>>>
>>>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119405): https://edk2.groups.io/g/devel/message/119405
Mute This Topic: https://groups.io/mt/106355103/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-05-31 4:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 18:53 [edk2-devel] GitHub PR Code Review process now active Michael D Kinney
2024-05-29 6:38 ` Gerd Hoffmann
2024-05-29 15:00 ` Michael D Kinney
2024-05-29 16:38 ` Gerd Hoffmann
2024-05-29 18:09 ` Michael D Kinney
2024-05-29 18:18 ` Rebecca Cran
2024-05-29 18:27 ` Michael D Kinney
2024-05-29 19:25 ` Michael Kubacki
2024-05-29 20:06 ` Michael D Kinney
2024-05-30 0:51 ` Michael Kubacki
2024-05-30 17:38 ` Saloni Kasbekar
2024-05-30 18:00 ` Michael D Kinney
2024-05-31 3:50 ` Michael D Kinney
2024-05-31 4:36 ` Michael Kubacki [this message]
2024-06-21 5:15 ` Dhaval Sharma
2024-06-21 5:25 ` Michael D Kinney
2024-05-30 8:32 ` Gerd Hoffmann
2024-05-30 14:10 ` Michael D Kinney
2024-05-29 10:40 ` Chang, Abner via groups.io
2024-05-29 14:44 ` Michael D Kinney
2024-05-29 14:48 ` Chang, Abner via groups.io
2024-05-30 0:41 ` Yao, Jiewen
2024-06-03 16:13 ` Neal Gompa
2024-06-03 16:26 ` Michael D Kinney
2024-06-03 18:46 ` Neal Gompa
2024-06-03 19:38 ` Michael D Kinney
2024-06-05 22:21 ` Michael D Kinney
2024-06-05 22:47 ` Rebecca Cran via groups.io
2024-06-05 23:27 ` Michael D Kinney
2024-06-16 22:08 ` Rebecca Cran
2024-06-06 1:21 ` Guo Dong
2024-06-06 1:37 ` Michael D Kinney
2024-06-04 13:23 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a81c0f50-5e5c-4cb5-a928-309d66fb9c43@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox