From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 185FBAC0B85 for ; Fri, 31 May 2024 04:36:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3H4V0Abgqp/NKG+7xvcCbRnh1oEVqa6234/AM1pECvI=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717130170; v=1; b=HmsgO0yb7XGVYM+H9dCgMOmnkN5AUJo53DTd78kFzc0BH20nOj6YQp91/psZxNPBiVKv+2k/ I7SCaf8FBhepzukOvmJg5H+9okyDgtXUFupEKGtq0omh+NGhhOz/Fd6RB2kEq9ZGtwfpcRu2nbn K9IizoUiCiwqTbRF+/Iz61QSefi8DNB2tjU8CIJxo7FJdPSS9QlbRsebWhQAMnVozTGx09E5iuF l4pNC0KXK6Fllp3IBrYLVqSdr/ZFIwZueUOjczgoe4AB3S7MR5nrtHlqRqBjTh+wll6ZYRfSWlm c0ReLRkXe/auvvntot49oWM4V1276PDH3Os5KIMKgStlw== X-Received: by 127.0.0.2 with SMTP id 6e4vYY7687511x2nUGCx0B8P; Thu, 30 May 2024 21:36:09 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.4164.1717130168930158466 for ; Thu, 30 May 2024 21:36:09 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.14]) by linux.microsoft.com (Postfix) with ESMTPSA id CF37620B915A; Thu, 30 May 2024 21:36:07 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CF37620B915A Message-ID: Date: Fri, 31 May 2024 00:36:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] GitHub PR Code Review process now active To: devel@edk2.groups.io, michael.d.kinney@intel.com, "Kasbekar, Saloni" , Rebecca Cran , "kraxel@redhat.com" , "Kubacki, Michael" References: <086790e8-a850-426f-86b1-73f54feebc1b@bsdio.com> <28097adb-a5fa-4bc6-ac39-fbf9ff71b9c4@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 30 May 2024 21:36:09 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sqlTzbrxua60CGbvZnEaBcFFx7686176AA= Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=HmsgO0yb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io I do not see the commits now but given dependabot commits are the latest=20 in the master branch, I'd assume a branch was not rebased correctly. Thanks, Michael On 5/30/2024 11:50 PM, Michael D Kinney wrote: > Hi Michael, >=20 > Do you know why there would be dependabot commits in PRs not related to d= ependabot updates? >=20 > For example: >=20 > https://github.com/tianocore/edk2/pull/5708/commits >=20 > Thanks, >=20 > Mike >=20 >=20 >=20 >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Thursday, May 30, 2024 11:01 AM >> To: Kasbekar, Saloni ; devel@edk2.groups.io; >> mikuback@linux.microsoft.com; Rebecca Cran ; >> kraxel@redhat.com; Kubacki, Michael >> Cc: Kinney, Michael D >> Subject: RE: [edk2-devel] GitHub PR Code Review process now active >> >> Yes. >> >> Mike >> >>> -----Original Message----- >>> From: Kasbekar, Saloni >>> Sent: Thursday, May 30, 2024 10:39 AM >>> To: devel@edk2.groups.io; mikuback@linux.microsoft.com; Kinney, Michael= D >>> ; Rebecca Cran ; >>> kraxel@redhat.com; Kubacki, Michael >>> Subject: RE: [edk2-devel] GitHub PR Code Review process now active >>> >>> How are we planning to handle packages (like NetworkPkg) without a >>> maintainer? Would the stewards add in the reviewers in that case? >>> >>> -----Original Message----- >>> From: devel@edk2.groups.io On Behalf Of Michael >>> Kubacki >>> Sent: Wednesday, May 29, 2024 5:51 PM >>> To: Kinney, Michael D ; devel@edk2.groups.i= o; >>> Rebecca Cran ; kraxel@redhat.com; Kubacki, Michael >>> >>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active >>> >>> I've updated the wiki process to clarify that maintainers need to ensur= e PR >>> reviewers are added and that a contributor cannot do so unless they are= a >>> maintainer in this update: >>> >>> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Developmen= t- >>> >> Process/_compare/b9d1f34e40d8ecbc7b59632302c9b0c823f52ab8...dd846b296754= da310 >>> 03f8c2a70e9a0b861e600b6 >>> >>> I did not include the @ ID process since there was not clear >>> consensus on that. I think it's tedious and for this small window of ti= me >>> without automation, ideally the GitHub notifications mentioned earlier = can >> be >>> used. >>> >>> Thanks, >>> Michael >>> >>> On 5/29/2024 4:06 PM, Kinney, Michael D wrote: >>>> We could, but that would require manually syncing CODEOWNERS with >>>> Maintainer.txt until that part of the process is automated. >>>> >>>> We also need a way to verify that CODEOWNERS and Maintainers.txt >>>> produce the exact same assignments. >>>> >>>> This was on the list of future enhancements when resources are >>>> available to help. We need to focus on a process that works until >>>> those automations can be deployed and supported. >>>> >>>> Mike >>>> >>>>> -----Original Message----- >>>>> From: Michael Kubacki >>>>> Sent: Wednesday, May 29, 2024 12:25 PM >>>>> To: devel@edk2.groups.io; Kinney, Michael D >>>>> ; Rebecca Cran ; >>>>> kraxel@redhat.com; Kubacki, Michael >>>>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active >>>>> >>>>> Mike, >>>>> >>>>> I agree that automatically adding reviewers would be helpful. >>>>> >>>>> Do you think we could add a CODEOWNERS file now to assist with this? >>>>> >>>>> Benefits being: >>>>> >>>>> 1. CODEOWNERS is low overhead in that GitHub already supports it. >>>>> >>>>> 2. We do not need to require CODEOWNER enforcement yet. We can simply >>>>> use it for automating the process of adding maintainers. >>>>> >>>>> 3. Maintainers have write access so they are required to approve and >>>>> add the push label. This would add a relevant maintainer(s) with >>>>> write access to fulfill that role. >>>>> >>>>> Thanks, >>>>> Michael >>>>> >>>>> On 5/29/2024 2:27 PM, Michael D Kinney wrote: >>>>>> GitHub has notification settings. Maintainers should configure >>>>>> GitHub so they are notified of all PR submissions to edk2 repo. >>>>>> >>>>>> The Wiki for the Maintainer Process provides a link to this page >>>>>> with the >>>>> details: >>>>>> >>>>>> https://docs.github.com/en/account-and-profile/managing-subscription >>>>>> s-and- >>>>> notifications-on-github/setting-up-notifications/configuring-notifica >>>>> tions >>>>>> >>>>>> https://docs.github.com/en/account-and-profile/managing-subscription >>>>>> s-and- >>>>> notifications-on-github/setting-up-notifications/configuring- >>>>> notifications#about-custom-notifications >>>>>> >>>>>> This allows Maintainers to receive notifications without being an >>>>>> assigned reviewer. >>>>>> >>>>>> Mike >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Rebecca Cran >>>>>>> Sent: Wednesday, May 29, 2024 11:19 AM >>>>>>> To: devel@edk2.groups.io; Kinney, Michael D >>>>>>> ; kraxel@redhat.com; Kubacki, Michael >>>>>>> >>>>>>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active >>>>>>> >>>>>>> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote: >>>>>>>> Hi Gerd, >>>>>>>> >>>>>>>> We can clarify the Wiki. A Maintainer has to be involved in every >>>>>>>> code review. The first action a Maintainer does is verify that >>>>>>>> the code change should be considered at all or rejected. Then add >>>>>>>> maintainers for the ones that look like good submissions. >>>>>>>> >>>>>>>> I agree that this may add a bit of delay. You are welcome to add >>>>>>>> a comment with @ tags to the maintainers and reviewers >>>>>>>> so they know to look at it and do the assignments. If you like >>>>>>>> that idea we can add that to the Wiki as well. >>>>>>>> >>>>>>>> Since PRs can be also opened by outside contributors that have >>>>>>>> limited access, maintainers have to be involved in reviewing newly >>>>>>>> submitted PRs. >>>>>>> >>>>>>> "Then add maintainers for the ones that look like good submissions.= " >>>>>>> >>>>>>> Surely in order for the maintainers to know the PR should be looked >>>>>>> at in the first place they need to already be added? >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Rebecca Cran >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>> >>> >>> >>> >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119405): https://edk2.groups.io/g/devel/message/119405 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-