From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.9959.1590140655443034586
 for <devel@edk2.groups.io>;
 Fri, 22 May 2020 02:44:15 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1736230E;
	Fri, 22 May 2020 02:44:15 -0700 (PDT)
Received: from [192.168.1.81] (unknown [10.37.8.250])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3888A3F305;
	Fri, 22 May 2020 02:44:13 -0700 (PDT)
Subject: Re: [PATCH edk2-platforms 16/16] Platform/NXP: LS1043aRdbPkg : Increase fv image size
To: Wasim Khan <wasim.khan@oss.nxp.com>, devel@edk2.groups.io,
 meenakshi.aggarwal@nxp.com, vabhav.sharma@nxp.com, V.Sethi@nxp.com,
 leif@nuviainc.com, jon@solid-run.com
Cc: Wasim Khan <wasim.khan@nxp.com>
References: <1590102139-16588-1-git-send-email-wasim.khan@oss.nxp.com>
 <1590102139-16588-17-git-send-email-wasim.khan@oss.nxp.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <a820b63e-d509-27ee-5f9a-22e2ebf5433d@arm.com>
Date: Fri, 22 May 2020 11:44:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <1590102139-16588-17-git-send-email-wasim.khan@oss.nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 5/22/20 1:02 AM, Wasim Khan wrote:
> From: Wasim Khan <wasim.khan@nxp.com>
> 
> Increase fv image size to pass debug build.
> 
> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

> ---
>   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
> index 81142f217a63..1c160e349eb9 100644
> --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
> +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
> @@ -24,10 +24,12 @@
>   
>   [FD.LS1043ARDB_EFI]
>   BaseAddress   = 0x82000000|gArmTokenSpaceGuid.PcdFdBaseAddress  #The base address of the FLASH Device.
> -Size          = 0x00140000|gArmTokenSpaceGuid.PcdFdSize         #The size in bytes of the FLASH Device
> +Size          = 0x00180000|gArmTokenSpaceGuid.PcdFdSize         #The size in bytes of the FLASH Device
>   ErasePolarity = 1
> +
> +# This one is tricky, it must be: BlockSize * NumBlocks = Size
>   BlockSize     = 0x40000
> -NumBlocks     = 0x5
> +NumBlocks     = 0x6
>   
>   ################################################################################
>   #
> @@ -44,7 +46,7 @@ [FD.LS1043ARDB_EFI]
>   # RegionType <FV, DATA, or FILE>
>   #
>   ################################################################################
> -0x00000000|0x00140000
> +0x00000000|0x00180000
>   gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
>   FV = FVMAIN_COMPACT
>   
>