From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=104.47.40.53; helo=nam03-co1-obe.outbound.protection.outlook.com; envelope-from=brijesh.singh@amd.com; receiver=edk2-devel@lists.01.org Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0053.outbound.protection.outlook.com [104.47.40.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1AABB21CF58AF for ; Thu, 5 Oct 2017 12:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Dh2foRDU0D1Tr6jgke66LLUwG7baUE2nNYneF23aeBo=; b=qXbawVEimO6a3l5slM5lWEKgT058vzLIBDohQu5900joTsiGrslqbrelw7Hx0GuHSXw+H7+nCHpl6UZ4Pe7e/WOuV6lfhAoo877BJ2B2H9nNNnhLwr5FqvWyU4pAUHVGAVtgUVP5QnlfbD5VIYM20hmy2/QDYJJ9JFjgLm8JFPQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 5 Oct 2017 19:52:50 +0000 Cc: brijesh.singh@amd.com, Jordan Justen , Tom Lendacky , Chao Zhang To: Laszlo Ersek , edk2-devel@lists.01.org References: <20171005184848.94432-1-brijesh.singh@amd.com> <20171005184848.94432-2-brijesh.singh@amd.com> <0383fa57-dd89-eb73-abaa-3248e1e7269f@redhat.com> From: Brijesh Singh Message-ID: Date: Thu, 5 Oct 2017 14:52:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <0383fa57-dd89-eb73-abaa-3248e1e7269f@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR1801CA0011.namprd18.prod.outlook.com (10.171.252.24) To CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87260e64-4ef2-42e5-af4b-08d50c2aa8fa X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 3:BHH9qUuJddfEFfd0PPROCrxmS66uxiTA635ReiyB+yOgLGEguJGRjmbcgZxGAOifFs3ajSQEb1gYrJSCJk0t8DGW7OY9sueZP7vP0a90EfJsh3VVdDb4edjmtInNi5ueIrNok1QnwjpgrJhGTOaLj9DrUUPJpZAhvjqh+3MhJaAa+qY2oVsF5RfMDBG19Wfis+7EyFtZUFElRFC01dR7w+3rVEyDHl/KIyksr236F4z5DGX3gZftnXlrBCTTkIiF; 25:y4mG4aPm804OSKHVCvC+cKqRzmR6YNlFBe5mO+WivycB+EpCT9ymrYBjBlPDEul4yggCen5rYR6aeXIIpVS+OaEDghJYLpguzJGIBHpjzW6bRRIK6HX1ZFG5clSstqatRUVszGbjYlNpv7+o2/vUPKhNrY8+yU27WQVo240OUi5xSFO3HQb3kAZ8ZELXkG1i4/ztCJ0AcgOgP+5xKAVUEyVLfA//aiyHrbw7T9+zQfqMC0XTg9zJh9F0lqaEdlqxfHRxN+Pu+oTv0KJWC9jWxCj3WfZFDXsM+eC6aVzjtpnVk0gbf75HP+4zr6E5WZzSdFQgHkOIUpj4ze039qahnw==; 31:8gABS9vCwAV/y/gWqP1S1dCD0RzktQoIUv3iEI4LCfK9WnGAbbUY+PeKhEB9uTZjDcROa9Q+liRG/9p8bEG2kORQHd4bGAsNpLCj427zE8t4MvOaIC91JBEqh4rozMsWtqVKnEGghCmK2u2cZ4R2wuhsSHF36aUQvtJJbCB2+ecekQMJ/l7mXAGdPUhgkD96zG+WivYR55EhWKvdzTyKd0ihgc1M3V5dPdExvizT+oU= X-MS-TrafficTypeDiagnostic: CY1PR12MB0151: X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 20:BOb5893PbFEcuyEktKpqb5qFFsLyx2MebyCZxTNSKc5uURchFDcymOtfvYwGUIXuqENRaqbUAK9r6ofhWZy6d+s5kJMiNUM8dIeRCXvpKbg4Jpe8rlDIAsoiIyEWNHhJyENQ+srvOn02YaWrONhqyZ99xB1Y5wlGuXoId+XhrdgUXnlABt1CKbsGEAfm+nSAhYhBoiMhiWInWuEjQtHIEi2C0FS7eg1oQiEmEBFGJVi4AbaXMzcWHquEyjjJ9L+suG3MuSg2wKGErOQCa7XYZnKJc5Q/iltcDOvh5IKDeXHN5/m0jLWVhqXfO0T0RKHlHDkW3l2PWIjEZrMlBUmyTJFwi03Yx8XQMBFtYekZCbpfr3mkAF8nonXijc7lx/Ct6G1jj7dIUOM7YbQ0UbBTWjkvt6RVGVfNPavyDKX9+vWeYSPaAzWhOWyOiuf0uSC6Y0NjUZ1Ko69bYZIwphTR3L1ZdqziY1vX7cf0wrxFbcEGJOo+HOvvchOJtOyi+AaQ; 4:qz2FVrUbpckTWwXllLd1OSp4Yu8+JlDeQEfIN4faXX0lgzwNpCOfPirkkUwYvUN0S0+CaaIAev+Tx/oix5ecxUSDmdu8ABP65AHsqmgyT43WzJV4ltmag097bymgYrgOHE5C989zssq+7lBtYbA6SYR3kBTMmTX7XtNuCaN7DLd7ZXESCmqfO9ATchgvzO7PJQZcXLNX+GVJ2ajXgM79x1EYYIcz2TJrPShR9tkNIqdCHAxzyIJg70v3xYdp2Wmf0ywwpkmKj+eHau6sZbaIVjO0El1HJZKLCHDa3jlqP20= X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR12MB0151; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR12MB0151; X-Forefront-PRVS: 04519BA941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(376002)(39860400002)(346002)(199003)(377454003)(24454002)(52314003)(189002)(50986999)(31696002)(2950100002)(2906002)(53546010)(6246003)(6306002)(36756003)(97736004)(16576012)(316002)(105586002)(229853002)(31686004)(58126008)(189998001)(106356001)(101416001)(68736007)(6666003)(3846002)(16526018)(23676002)(6116002)(86362001)(33646002)(64126003)(4326008)(7736002)(8936002)(305945005)(53936002)(54906003)(81166006)(81156014)(83506001)(50466002)(8676002)(5660300001)(6486002)(478600001)(65956001)(66066001)(76176999)(77096006)(966005)(25786009)(54356999)(65806001)(47776003)(65826007)(90366009)(230700001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0151; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzIzOmlLMzlmekFobE1oaWI1STZPOHBURS9aT2tG?= =?utf-8?B?VVhMWWpKM1lrM2RGWkhjbkNoR0QwcVE0WjMrQ3d0RTVFT3ArT2JFNEY0VUNG?= =?utf-8?B?Q2k3TXhkL3lkMmYrTStudmFwRVNMK3gxN2tFYTh0WDJyTU9aVlUvaXkya1lW?= =?utf-8?B?VEdHYUxqa0dvWHo2a2l6cm5MTWE3eVJGMnlSU0dkRUhwazNZWktvUmdvUHFL?= =?utf-8?B?cHlTNU9icGlXT3N5YlBUSkU2SHdRTlpEY2RCY0J3c2cxRkdWY1hSVHAxMjhI?= =?utf-8?B?anA0QWY5REpxNVdZeHNqa2xUY1lycER6UjFoYXY3VEg4U2dDUFljR0N3RGtG?= =?utf-8?B?N1d6RlZFU2thK1JSSk5ubzRLQ0RNaW42MDhqSTl2cnRFOVhrYUFqUmVtT01I?= =?utf-8?B?dCtweUtLZWkrdkxueUJxSVQ5K2NVYVFCUFZKaHlPeVYyUGFubVVmRUk2bGRI?= =?utf-8?B?RVo0Vysza3lQVUtTdG55Mno4cGZ3Y1VYdnRWdDFiYWk2NEo5N29SVWhYNVcy?= =?utf-8?B?MTUxOWlyWU56NlQzZVdHVlVrVTkvcGhEaDBYcno0N2FsYXA2b2RWNGswTFU0?= =?utf-8?B?bi9TaTl4alltTGdtRExjeEs3eHBWcFI2MDRFQ1cxdjlyV3Y5dXhuQ1MyY1N3?= =?utf-8?B?dGRkOUpZUVl4UWJOQml1djVoK1hOQVE2K2xueDhXcFpPWDlvOHBtKzhYUXY5?= =?utf-8?B?d2dwN1RNV2xVUGVSL3VvTUU2NDdmSUROejBZalBoUG1wUUhYd3I2OHdITXNP?= =?utf-8?B?aFRzcEsrOG5EUGR6eEZpd1pzS0tZUVJZWUFEcTFka1lwWjRSbGtjbWp0YWVZ?= =?utf-8?B?V1k0dHJPS2JVbmpYSUFHYVhXNFdqenRSNFpoaHNQcWl2TlkzNXRRWjU4eVk5?= =?utf-8?B?WDVrUnZtQ1NvTkhtNGZaMHVkRlZFaTN4MThhQnpmM2w0WWZlSyt3bHlWYWZF?= =?utf-8?B?LzFNZGNhQTJWNWlaSmw0dEhWd2pqaCtjWmFFTEZSa0FIblRsL3BjVU1tVDRs?= =?utf-8?B?dCtDdVRYZitTMmNkNG8zNjJoQmVqUjRFVnRiQy94WERGSkFHREQ3ZzlndXNx?= =?utf-8?B?YW53U2prUlVNdVYraldJVHY5OHB2MDBad3pxZlc5d3A4RFBtcCtqeW5oK2ly?= =?utf-8?B?NHhyc3hoWm04K3p4alNvd3JZTUdoZi9zNGZNVFJNSUFka2RsNVJoNWVJVWJC?= =?utf-8?B?UlZIdDRMbUg0ZjR3VGtrbXg5NFY2anNwT0hQR05WcmxaTTNPRktUQ00wcFdm?= =?utf-8?B?bWZPTTFWSWVqZWpWdExxTDUrYk85dHpJVEd5Z2FVSVlzMjQxTERWWlV4MU1P?= =?utf-8?B?YVhidS9Td0NtRElnSTcwQ2JyYm42Yzc0cXdDZ2crZ3h3RTZoU2EwMElkWnpC?= =?utf-8?B?a0tBWjlHSi9VbDhtWklFZ3ZlQWw4czdSdDNtYk9HVExBbjlxbDRmUXNRT2pu?= =?utf-8?B?L01WS1h1bFlnUkY3S3UweUMwOUZXNWhEYTdaL01CY29oekRqNnNOV3Uyc1FQ?= =?utf-8?B?UU5rRS9KWmxFcmJIa0trOS9xNktWQ1N0cDMyWllJZkxyTDBqeXAwMUhqU2NX?= =?utf-8?B?UFZVbjB4SnhPMVdlc1pMd25ZU0JSMktiVUMrVkhZbDVmMWZ4dGJYSVM5TTdj?= =?utf-8?B?UDNvTElIWW1iVEFWVUVxVWpOUDkyN3hZeVJScVYyQi9iQnc0QmI0TWdPSnJw?= =?utf-8?B?cFFLTmRra2wxRysvVUxXdmNrdWNUc1orbGg2VkNxREFCZVZ2cTZYMzA3d1li?= =?utf-8?B?NjU1T3QvNmI2SGFDdWVUdGpYek1DWGlHMko0QVdHdThsYUl5RkxOeHZqY3Zi?= =?utf-8?B?eXdpNFNGOGdjbm9kOXlGdXBsOEpJUW5aUWkxV1BVZlk0cExGY1ZvTzM4aHcw?= =?utf-8?B?bTJ5NzBURWo3bGJHV1JlQ2ozQVdRVGlkekxXekhSODlweXB4cVhacFlVdWM4?= =?utf-8?Q?XBG/AQn/d/e1r2oAow36RtMT9+o/qA=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 6:0w3X1n/SuzJ93xlsyCzruXPXR7gYZtQ1SMEXgODetQDlZ3n7FnaI+mqyuSutGA4t7LauDWwfiPEvgNM+WSG0yBqh0hJH2ZKHZpr8DeKa/opXokih6yE0+quX+2GhAJ1jNycmf5cqgSlndmLzNbkzdEElYhiz7+ka9oHd0jwhA7SuKH7IQ7Umab0tzoXtq5Ky5Yy8nqztcLsGReeAKp5zqvqg5yIynPoyI5Tg5Bqe6VXM7Un68tM8jzhDtKAbAllH8+gzEH+1hYImof/Rl2pnLaMO9Lx2Le0zpBCAOj27jLTYq1MKVBBdh2QtdwT5VdK/rX3tYP78AAp+iI96he7J9A==; 5:kfBCphw4y7ktTATr7+M8PfawQVzYJ/nW3cQ3KcLMh0HzlHreku6ePrJy2Gv/BhNl9YHJDamCK3axCHC4DskYNxm1MGlPs7sIrMA6OviA92EdYyFsET76Ly/EPuqMN1czvB9MYb/VhyY5OimyMtIvHw==; 24:Jtuv7hkljVr1T70Ua84WCZtqpLoo+9e69EzxlB3EjF02NbfElLCWPSPwYQq72wiNx/A1yzMUn+C2XNVV1jiMlHlEFUsyrxR2cTqWU74HXbw=; 7:Hi2HlQ3r9cea3NYANcXV3dd/i03vaQ2KZHT0m6xIV1FxKo5WyZxvf9J1tEi4oexQp9oBdMKlXeEj56z2Y8vsXGMsWF74G7FB720ys0f8QqfkvBAbebgpsYE03xPT+fmCi2MZjPwTJGJP3nzlR/6FT1izuL8yAQxeT8FywU2s5azUJfU+nvGRa4L6D2hB30NLFUuWTQKtbHpn1ZSS3E/n/ZFUAZOcelPnJ0Gsh1Yh3bM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 20:7TeIOxwXwPBB47nc7RDW0GeavQjedud65nc44i7fGJagiFYHMxmtfBjYqv4uY5Ip0DKLVoKZ9g18Q55xP/KU+nZS6wf1FgmVsTAgQpuMK56wqkbaE6GjVcSsxhtOrAUrWI3GOUIEpq/Z/0BF5VkzIqT4GytppNgoWPSxpPE4asEngZWZZuDSlpNMzUAc23+9ckqWZxlOM4X7Ay9MXUr69NkYEI4N2QKtLaW2QN1g15GWV5Li+rAfrWpadEgGuVJl X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2017 19:52:50.3297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0151 Subject: Re: [PATCH 2/2] OvmfPkg/PlatformPei: DENY_EXECUTE_ON_SECURITY_VIOLATION when SEV is active X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 19:49:31 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Laszlo, On 10/05/2017 02:46 PM, Laszlo Ersek wrote: ....>> ################################################################################ >> # >> # Components Section - list of all EDK II Modules needed by this Platform. > > (1) It's hard to see what section of the DSC file the lines are moved > from, and to what section. > > Git can be configured so that it display the section names in the diff > hunk header (following the "@@" marks). Please refer to the following: > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05 > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09 > > In particular, see the "diff.ini.xfuncname" config option, and the > matching "diff=ini" attributes. > > (This remark does not affect the patch, only how it is formatted. > Showing the DSC section names in the diff hunk headers helps quite a bit > with review.) > I recently changed by build box and I did carried over my previous gitconfig setting so that it generate the correct formating per your week but I might have missed something in the process. I will fix it. sorry about that. > > > (2) Please apply the same code movement to "OvmfPkg/OvmfPkgIa32.dsc". > > As written, the PcdSet32S() macro invocation in PlatformPei below will > not even compile for OvmfPkgIa32. Namely, the PCD will remain > fixed-at-build, and because of that, the replacement text of the > PcdSet32S() macro, i.e. > > _PCD_SET_MODE_32_S_##TokenName ((Value)) > > from > > MdePkg/Include/Library/PcdLib.h > > will not have any *further* replacement text, from "AutoGen.h". > Ah good catch. I will fix in v2. >> > > (3) I find it sub-optimal that the > > DENY_EXECUTE_ON_SECURITY_VIOLATION > > macro, from > > SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.h > > is internal to that library instance, and isn't exposed in some library > class header. > Yep, I had similar concern but as you said SecurityPkg.dec spells out very well hence I did not bother to move the header file from internal to somewhere its accessible by other modules. > Anyway, I guess we can't do much about it here, and at least > SecurityPkg.dec spells out the meanings of the values. So this hunk > looks fine to me. >