From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.894.1606331701873441077 for ; Wed, 25 Nov 2020 11:15:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Pdr7ha3p; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606331701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ulMiFBQs3hOrsMhCMXwlfeUwBBcPDI5lMVMlmgBfuOc=; b=Pdr7ha3pgH+sAzU41RCM3qxW1ly1lzhedl9MmRWi4jjn7n6pPC0WRFMM6qh6Vuv8um4+QL z2RlPHIoSvONwj/NRIOY8MHYhQ7m+zlw7+h/IF+Yp9jD/uddENegx8PzEF3anrAorc0eym IAYNwm8gcFo30KH5Xaj2fZcJJjV9QM0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-zVJo6hRjMaS-urIr0P53zQ-1; Wed, 25 Nov 2020 14:14:57 -0500 X-MC-Unique: zVJo6hRjMaS-urIr0P53zQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5DD0804006; Wed, 25 Nov 2020 19:14:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-239.ams2.redhat.com [10.36.112.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id D118F60C43; Wed, 25 Nov 2020 19:14:51 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 2/6] OvmfPkg/AmdSev: add Grub Firmware Volume Package From: "Laszlo Ersek" To: jejb@linux.ibm.com, devel@edk2.groups.io, Bret Barkelew , "Liming Gao (Byosoft address)" Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" , "Ard Biesheuvel (ARM address)" References: <20201120184521.19437-1-jejb@linux.ibm.com> <20201120184521.19437-3-jejb@linux.ibm.com> <28e99174-79b3-e805-b977-5fed0071a702@redhat.com> <06b9425507ab8c1b35d377cf9bba155b0cc44147.camel@linux.ibm.com> <3b7899fa-fa52-7652-2d2a-d4ec67ece34d@redhat.com> <1c871b56-f459-5ac4-3b8d-a55d978eac06@redhat.com> <93fdaca88b53d400670b338a06fd1410c1445a39.camel@linux.ibm.com> <082a97c2-9a49-acf6-fd7c-70ee6b61c000@redhat.com> <5b9b21c3eb37ba7024c1cb85ead267867b323c7d.camel@linux.ibm.com> <1064db1d53315987bf8bb478894a07bda8d90a96.camel@linux.ibm.com> <53957e99-3f81-0121-b8fd-db28fdb01a73@redhat.com> Message-ID: Date: Wed, 25 Nov 2020 20:14:50 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/25/20 20:08, Laszlo Ersek wrote: > (BTW I see some more pool allocations in > "MdeModulePkg/Library/VariablePolicyHelperLib" to... I guess I'll have > to check those as well.) The VariablePolicyHelperLib functions should be OK -- they create VariablePolicy objects on the heap only temporarily, so they can be copied into "mPolicyTable". Right after these one-off objects get released. Thanks Laszlo