From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH v3 0/5] Add DynamicPlatRepoLib
Date: Tue, 14 Dec 2021 18:35:36 +0000 [thread overview]
Message-ID: <a8645cdc-c4f1-f8e8-4734-a992665bca60@arm.com> (raw)
In-Reply-To: <20211209093251.1249368-1-Pierre.Gondois@arm.com>
Hi Pierre,
Thank you for this patch series.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 09/12/2021 09:32 AM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> v3:
> - Run uncrustify and apply the required formatting. [Pierre]
> - No other change with v2. [Pierre]
> v2:
> - Various small fixes (change status returned, reset values when
> freeing memory, ...). [Sami]
>
> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=3743
>
> The DynamicPlatRepoLib is library allowing to receive and then
> give Configuration Manager (CM) objects.
> After being initialized, a dynamic platform repository can receive
> CMObjects. The library generates a token to uniquely identify the
> CMObject in the repository. The dynamic platform repository must
> then be 'finalized' before receiving CMObject queries.
>
> This library is complementary to the 'static' definition of
> CMObjects (i.e. as C structs). It is particularly useful when
> using a HwInfoParserLib that dynamically creates CMObjects
> (from a device tree for instance).
>
> The changes can be seen at: https://github.com/PierreARM/edk2/tree/1788_Add_Dynamic_Plarform_Repository_Lib_v3
>
> Pierre Gondois (5):
> DynamicTablesPkg: Definition for DynamicPlatRepoLib interface
> DynamicTablesPkg: DynamicPlatRepo: Add TokenGenerator
> DynamicTablesPkg: DynamicPlatRepo: Add TokenFixer
> DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper
> DynamicTablesPkg: Add DynamicPlatRepo library
>
> DynamicTablesPkg/DynamicTablesPkg.dec | 3 +
> DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
> .../Include/Library/DynamicPlatRepoLib.h | 114 ++++
> .../DynamicPlatRepoLib/CmObjectTokenFixer.c | 165 ++++++
> .../DynamicPlatRepoLib/CmObjectTokenFixer.h | 52 ++
> .../DynamicPlatRepoLib/DynamicPlatRepo.c | 521 ++++++++++++++++++
> .../DynamicPlatRepoInternal.h | 78 +++
> .../DynamicPlatRepoLib/DynamicPlatRepoLib.inf | 33 ++
> .../DynamicPlatRepoLib/TokenGenerator.c | 29 +
> .../DynamicPlatRepoLib/TokenGenerator.h | 26 +
> .../Common/DynamicPlatRepoLib/TokenMapper.c | 224 ++++++++
> .../Common/DynamicPlatRepoLib/TokenMapper.h | 123 +++++
> 12 files changed, 1369 insertions(+)
> create mode 100644 DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.h
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoInternal.h
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/TokenGenerator.c
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/TokenGenerator.h
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/TokenMapper.c
> create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/TokenMapper.h
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-12-14 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 9:32 [PATCH v3 0/5] Add DynamicPlatRepoLib PierreGondois
2021-12-09 9:32 ` [PATCH v3 1/5] DynamicTablesPkg: Definition for DynamicPlatRepoLib interface PierreGondois
2021-12-09 9:32 ` [PATCH v3 2/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenGenerator PierreGondois
2021-12-09 9:32 ` [PATCH v3 3/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenFixer PierreGondois
2021-12-09 9:32 ` [PATCH v3 4/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper PierreGondois
2021-12-09 9:32 ` [PATCH v3 5/5] DynamicTablesPkg: Add DynamicPlatRepo library PierreGondois
2021-12-14 18:35 ` Sami Mujawar [this message]
2021-12-14 18:48 ` [PATCH v3 0/5] Add DynamicPlatRepoLib Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8645cdc-c4f1-f8e8-4734-a992665bca60@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox