From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.72]) by mx.groups.io with SMTP id smtpd.web08.29790.1639506948810702355 for ; Tue, 14 Dec 2021 10:35:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=jQvZgE+L; spf=pass (domain: arm.com, ip: 40.107.0.72, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O397irJ7IJsuBKMF6MFW9W+OvQaZk0N5pz/tYDiYGk0=; b=jQvZgE+Lf0R+3ZlptMcU5QMRZ4fQ77WR0Y5fVcX8+Whb8z6u+xfuvr2RoK5egMdLYzn8UgjGW+rNJvZw6uOJEPBmc3VNub+tS88I4Rskt4Un0+yAv+GCiysNkshjOHF4iTuOMH7RGJyLlzy6tlP6HJB7d7kp/I2tka08IkKnXz0= Received: from AM5PR0701CA0063.eurprd07.prod.outlook.com (2603:10a6:203:2::25) by AM4PR0802MB2130.eurprd08.prod.outlook.com (2603:10a6:200:61::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec 2021 18:35:45 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::6f) by AM5PR0701CA0063.outlook.office365.com (2603:10a6:203:2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Tue, 14 Dec 2021 18:35:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Tue, 14 Dec 2021 18:35:45 +0000 Received: ("Tessian outbound c61f076cbd30:v110"); Tue, 14 Dec 2021 18:35:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d842e58d79ec0f3c X-CR-MTA-TID: 64aa7808 Received: from 290ec8f9c8d9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1C5DF69E-F54E-4590-9359-444E2D2C91E0.1; Tue, 14 Dec 2021 18:35:30 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 290ec8f9c8d9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 14 Dec 2021 18:35:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wtd3PAj1iBeZRuNK91vJdetxBVPNHaMmCDvF1gmjHEvH6Tqmgvr/ed5Z+CKlVycM4k32dzVcpUrp1ZZI6qyLzmPz0m5uDLXSVJLen9fKnqNmBq8vu9xIg62K4g6zPuAj58uhWG+f4py4XcakNoMbMTts3ICaqw4369oWabbuapzcLQDyhK59rjw7CT3J+iW5acMyIjO7JqxpjH+mZA4CQptUPt2rkJe49NgoKR3RLrbBIeM84fo7Or2p35I3IjsMRHqRiQ1u4aMzuUpEJA26/1NSRK507ugEUCEuEE2kR0cjD7QjSHMJ6WnGvKIDDzV8la4/isDveWVcemHD649Zxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O397irJ7IJsuBKMF6MFW9W+OvQaZk0N5pz/tYDiYGk0=; b=lvSL0lfsUs/1N8BL3LsJiMDT+qUiwNwB+X13qb1H0IHxtiWTG2qQtFJ2lJM98qX/jF8wcHf+MHuEnPZ+2vyohXG0h8O8q+QYPrR2NU2wcOWYN9uCXQ4fQm3wGUviXecDN0US3kU+Du1vMqFIYczMuXHSO2NenjMInGVBdJZIr5KYQhFLQSU2/GGimCKp+modoGg2iKP0QAYHIMZGqAqEPRop8bepOOamXfn2UTMPCripaolRn7bTS+vp5UP3HSdgBpy20yOS91xp/U3Qga9ZiwtXa03JsqbaZefY2T7j9khIT8XIT+/zpv5ezUiMlEwGfkSjYNF7b6yUAf9Cao+yew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O397irJ7IJsuBKMF6MFW9W+OvQaZk0N5pz/tYDiYGk0=; b=jQvZgE+Lf0R+3ZlptMcU5QMRZ4fQ77WR0Y5fVcX8+Whb8z6u+xfuvr2RoK5egMdLYzn8UgjGW+rNJvZw6uOJEPBmc3VNub+tS88I4Rskt4Un0+yAv+GCiysNkshjOHF4iTuOMH7RGJyLlzy6tlP6HJB7d7kp/I2tka08IkKnXz0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB5205.eurprd08.prod.outlook.com (2603:10a6:20b:ee::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec 2021 18:35:29 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Tue, 14 Dec 2021 18:35:29 +0000 Subject: Re: [PATCH v3 0/5] Add DynamicPlatRepoLib To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , nd References: <20211209093251.1249368-1-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: Date: Tue, 14 Dec 2021 18:35:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211209093251.1249368-1-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO2P265CA0111.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::27) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO2P265CA0111.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Tue, 14 Dec 2021 18:35:28 +0000 X-MS-Office365-Filtering-Correlation-Id: 69d39e33-414d-48cf-6fa8-08d9bf308a75 X-MS-TrafficTypeDiagnostic: AM6PR08MB5205:EE_|AM5EUR03FT033:EE_|AM4PR0802MB2130:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KE7xfhMWhN8h/iUwdQIwmnnfjDRrdGR8D5/0H1XIVCE8/8ImaQT2Ln3iZaMU4tHLFyXCiJNla2kUmDGTv8YIOJMEG+RAhy6EXo+g+Q3ynTjEibHeF/n7H1AMLhW3wOEkVwICUM3CBcN6DfthwOC0VKU+rAhvfBDoqsMu0mVPEqBjuo9DikLrgsW0Hkp5BgPbFjbdTiDxHl27d3/TgoIdsp7Wvuklzs8ziqQh10JGT99Ltd+SJYrDsg/SuWeJx80ZvaBBOD7EneTE/9eDfyDOmoArVdWfnylLMzLaxxiJEgqPizj/P6P7CiidQjIaQuDfcAxkfLb+h/fGrvRFHrPIrmaoF60qmqE9h3D8wo9UQaTM8yesX4XETPaLveMAob0W2xxakUwkZdDM3M2qgJ4QmWRmgy1KJ9rMVYC1+dekswS+emf+wx727hw4OmD1DOxkR8nwksDxhxXNnJd2DJ6GT5T3eHnBhThZhjpRWIbfmVMmscN1eF+K1IB9nS+wZ989rltXb4l87Srha5x9BWVZwxLpoh/EGG+oJtx9PRRaZTxIlVBa8/VmrW6h4oYKTfcw4vPq5ukTOaixIdFc6Msz2m8eLmdeR1Vhw/+B+vV05ZRTZkBpGFG3jiEy1KEsXcCPczVzubwXcP5MbgHvT3tjynMbfHZxOBv92F5f6/7gSpBkrttcDQCv7+iTCPl6FO6xpRqvXU1IZmJNZwGgOmDrEAYr9ckW4/QYpSpK3hH/RXQN+X0h+ZOUOcKcaXY1QKRImzHesDvP2b2889WLWmGBV4wUCDiAb5XtjNKUgmBUkpSbgF4BI5w37AssZn0IqA5rV4wJXEAtdkOyfg7vnaJdMUiMOgAcSA5pjrXQcB5P6l1PkWaVHya4htYcSMbMD/FR X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6666004)(2906002)(36756003)(6486002)(66946007)(4326008)(316002)(186003)(66476007)(956004)(26005)(53546011)(508600001)(966005)(44832011)(66556008)(16576012)(54906003)(52116002)(86362001)(8936002)(38100700002)(8676002)(2616005)(31696002)(38350700002)(31686004)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5205 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4c6b4c07-7e72-4094-0efb-08d9bf3080d3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YnrQF0Of4oMBm+S5m2RKi/SKncKVPnF3RvNjU6rJac2qHAmkTffeAWHInTFpbjfl7jbYPNcYt21TxW+tmIOwRQuQ3h5LnKJE6u/f/dNXQXODdhysiphHexW9ivCEt5Eu+n7Li8ajBkpFyeGmikGgIX/vw4BnGab1VKQNP77OIlEHI2SWGyt15Kkk7c7UStb2x5O1wny1Q0dz8mWqVoTCzbrBikdCn4uIW/gjO4h0sip20MwJ+fRcY2yph0D8ygm7CKCRuh1QgfFNZlNitX2Dykpp68ETXGyln0MfjjcpM2cDquPcbQ0VSXjdsC+q/3qcaV5TTxe52doiKjtAtQ3gWhS1vD+d2qN1c14xgigY3pC+wph7OT042WYqGGhNfq49B+szNJVQB2jz9eIU0aNe2LXox6cunzul68e21UqDAbs2tSm1fX7P1o4TTPQ9RlAjWusgUv/Jxs2XSLfqZ0yUHL+7iXXvbkqnPLngYE/0RMeYYhPHfv7e3xFsZOIxjRPvS1gAd0rj7MGjWQnFOfqw9VwVPpX1fFVqr99m2Yt51497ts04F5Teaw4/ZQ+J6g0ySjvJqNefo2d5mZJb9jKBP73++Ns5HxEwkNKc4hEMB4KxTt9DSFnDaHmAPhOE8OGI3mLTtVqx9P64M4D+uuI8lAQaBiib31taQ+K5T+SKE+Oqq6K/+iX5ebRfaLWuIXmXerxfqOJ/pfklDN99zu8VTqHVUlDU8VS8c+eVCbBMH1NxcR025NAbK8I5OlEyDYKotdvg71S0/NfRObCYVG3aVOUvSauMM1zpuC78LxztzKh9Kr3OOBkkLb1mHLtPktknR82X1IYrdFoHF2OOQBshrWn2wEqyoNjlyWB9/3ViCN/8hSL23aoNyjMPMD0AOp76zGD/CciQwX0SBa9jRXeoqswaTT6kjJccA2YdfzV4dAY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(53546011)(4326008)(54906003)(70206006)(8936002)(26005)(508600001)(70586007)(356005)(81166007)(40460700001)(86362001)(31686004)(2616005)(82310400004)(6666004)(316002)(16576012)(5660300002)(31696002)(47076005)(6486002)(336012)(966005)(8676002)(2906002)(186003)(956004)(36756003)(44832011)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 18:35:45.1299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69d39e33-414d-48cf-6fa8-08d9bf308a75 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2130 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Pierre, Thank you for this patch series. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 09/12/2021 09:32 AM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > v3: > - Run uncrustify and apply the required formatting. [Pierre] > - No other change with v2. [Pierre] > v2: > - Various small fixes (change status returned, reset values when > freeing memory, ...). [Sami] > > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=3743 > > The DynamicPlatRepoLib is library allowing to receive and then > give Configuration Manager (CM) objects. > After being initialized, a dynamic platform repository can receive > CMObjects. The library generates a token to uniquely identify the > CMObject in the repository. The dynamic platform repository must > then be 'finalized' before receiving CMObject queries. > > This library is complementary to the 'static' definition of > CMObjects (i.e. as C structs). It is particularly useful when > using a HwInfoParserLib that dynamically creates CMObjects > (from a device tree for instance). > > The changes can be seen at: https://github.com/PierreARM/edk2/tree/1788_Add_Dynamic_Plarform_Repository_Lib_v3 > > Pierre Gondois (5): > DynamicTablesPkg: Definition for DynamicPlatRepoLib interface > DynamicTablesPkg: DynamicPlatRepo: Add TokenGenerator > DynamicTablesPkg: DynamicPlatRepo: Add TokenFixer > DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper > DynamicTablesPkg: Add DynamicPlatRepo library > > DynamicTablesPkg/DynamicTablesPkg.dec | 3 + > DynamicTablesPkg/DynamicTablesPkg.dsc | 1 + > .../Include/Library/DynamicPlatRepoLib.h | 114 ++++ > .../DynamicPlatRepoLib/CmObjectTokenFixer.c | 165 ++++++ > .../DynamicPlatRepoLib/CmObjectTokenFixer.h | 52 ++ > .../DynamicPlatRepoLib/DynamicPlatRepo.c | 521 ++++++++++++++++++ > .../DynamicPlatRepoInternal.h | 78 +++ > .../DynamicPlatRepoLib/DynamicPlatRepoLib.inf | 33 ++ > .../DynamicPlatRepoLib/TokenGenerator.c | 29 + > .../DynamicPlatRepoLib/TokenGenerator.h | 26 + > .../Common/DynamicPlatRepoLib/TokenMapper.c | 224 ++++++++ > .../Common/DynamicPlatRepoLib/TokenMapper.h | 123 +++++ > 12 files changed, 1369 insertions(+) > create mode 100644 DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.h > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoInternal.h > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/TokenGenerator.c > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/TokenGenerator.h > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/TokenMapper.c > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/TokenMapper.h > > -- > 2.25.1