public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Marcin Wojtas <mw@semihalf.com>,
	"Masami Hiramatsu" <masami.hiramatsu@linaro.org>,
	<devel@edk2.groups.io>
Subject: Re: [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common
Date: Tue, 1 Feb 2022 09:58:52 -0700	[thread overview]
Message-ID: <a86b88db-87e4-895a-e9f6-32b261cf105c@quicinc.com> (raw)
In-Reply-To: <20220201165627.25216-1-quic_rcran@quicinc.com>

Sorry, I forgot to add a cover letter.

I noticed some breakages in Arm platforms caused by additions of 
VariablePolicyHelperLib: the 3 patches fix them by adding it to 
LibraryClasses.common.


-- 
Rebecca Cran


On 2/1/22 09:56, Rebecca Cran wrote:
> The VariablePolicyHelperLib is now used by a number of driver types, so
> instead of duplicating it, move it into the LibraryClasses.common section.
>
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
>   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index af207391209c..41c1cadc3425 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -125,6 +125,7 @@ DEFINE X64EMU_ENABLE  = FALSE
>     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>     RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
>     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>   
>     UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -209,7 +210,6 @@ DEFINE X64EMU_ENABLE  = FALSE
>     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
>     MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>     NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>   
>   [LibraryClasses.common.DXE_RUNTIME_DRIVER]
>     HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> @@ -219,7 +219,6 @@ DEFINE X64EMU_ENABLE  = FALSE
>     DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
>   !endif
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>   
>   [LibraryClasses.common.UEFI_APPLICATION]
>     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf

  parent reply	other threads:[~2022-02-01 16:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 16:56 [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
2022-02-01 16:56 ` [PATCH 2/3] Platform/Socionext: Move VariablePolicyHelperLib to LibraryClasses.common Rebecca Cran
2022-02-01 16:56 ` [PATCH 3/3] Silicon/Marvell: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
2022-02-01 17:03   ` Marcin Wojtas
2022-02-01 16:58 ` Rebecca Cran [this message]
2022-02-01 16:59   ` [edk2-devel] [PATCH 1/3] Platform/AMD: " Ard Biesheuvel
2022-02-01 17:14     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a86b88db-87e4-895a-e9f6-32b261cf105c@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox