public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common
@ 2022-02-01 16:56 Rebecca Cran
  2022-02-01 16:56 ` [PATCH 2/3] Platform/Socionext: Move VariablePolicyHelperLib to LibraryClasses.common Rebecca Cran
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Rebecca Cran @ 2022-02-01 16:56 UTC (permalink / raw)
  To: Ard Biesheuvel, Leif Lindholm, Marcin Wojtas, Masami Hiramatsu,
	devel
  Cc: Rebecca Cran

The VariablePolicyHelperLib is now used by a number of driver types, so
instead of duplicating it, move it into the LibraryClasses.common section.

Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index af207391209c..41c1cadc3425 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -125,6 +125,7 @@ DEFINE X64EMU_ENABLE  = FALSE
   OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
   RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
   TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
 
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -209,7 +210,6 @@ DEFINE X64EMU_ENABLE  = FALSE
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
   NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
-  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 [LibraryClasses.common.DXE_RUNTIME_DRIVER]
   HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
@@ -219,7 +219,6 @@ DEFINE X64EMU_ENABLE  = FALSE
   DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
 !endif
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
-  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 [LibraryClasses.common.UEFI_APPLICATION]
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] Platform/Socionext: Move VariablePolicyHelperLib to LibraryClasses.common
  2022-02-01 16:56 [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
@ 2022-02-01 16:56 ` Rebecca Cran
  2022-02-01 16:56 ` [PATCH 3/3] Silicon/Marvell: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
  2022-02-01 16:58 ` [PATCH 1/3] Platform/AMD: " Rebecca Cran
  2 siblings, 0 replies; 7+ messages in thread
From: Rebecca Cran @ 2022-02-01 16:56 UTC (permalink / raw)
  To: Ard Biesheuvel, Leif Lindholm, Marcin Wojtas, Masami Hiramatsu,
	devel
  Cc: Rebecca Cran

The VariablePolicyHelperLib is now used by a number of driver types, so
instead of duplicating it, move it into the LibraryClasses.common section.

Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
---
 Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
index fd4cfa82330d..690cdef9d91c 100644
--- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
+++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
@@ -128,6 +128,8 @@
 
   NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
 
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
+
 [LibraryClasses.common.SEC]
   PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
@@ -182,8 +184,6 @@
   PciHostBridgeLib|Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf
   NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
 
-  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
-
 [LibraryClasses.common.UEFI_APPLICATION]
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
@@ -210,7 +210,6 @@
 !if $(TARGET) != RELEASE
   DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
 !endif
-  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 [LibraryClasses.ARM]
   ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] Silicon/Marvell: Move VariablePolicyHelperLib into LibraryClasses.common
  2022-02-01 16:56 [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
  2022-02-01 16:56 ` [PATCH 2/3] Platform/Socionext: Move VariablePolicyHelperLib to LibraryClasses.common Rebecca Cran
@ 2022-02-01 16:56 ` Rebecca Cran
  2022-02-01 17:03   ` Marcin Wojtas
  2022-02-01 16:58 ` [PATCH 1/3] Platform/AMD: " Rebecca Cran
  2 siblings, 1 reply; 7+ messages in thread
From: Rebecca Cran @ 2022-02-01 16:56 UTC (permalink / raw)
  To: Ard Biesheuvel, Leif Lindholm, Marcin Wojtas, Masami Hiramatsu,
	devel
  Cc: Rebecca Cran

The VariablePolicyHelperLib is now used by a number of driver types, so
instead of duplicating it, move it into the LibraryClasses.common section.

Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 5e153782079c..9322ad881e69 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -69,6 +69,7 @@
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
   UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
   PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
 
@@ -175,7 +176,6 @@
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
   NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
   DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
-  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 [LibraryClasses.common.UEFI_APPLICATION]
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
@@ -198,7 +198,6 @@
 !endif
   DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
-  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 [LibraryClasses.ARM, LibraryClasses.AARCH64]
   #
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common
  2022-02-01 16:56 [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
  2022-02-01 16:56 ` [PATCH 2/3] Platform/Socionext: Move VariablePolicyHelperLib to LibraryClasses.common Rebecca Cran
  2022-02-01 16:56 ` [PATCH 3/3] Silicon/Marvell: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
@ 2022-02-01 16:58 ` Rebecca Cran
  2022-02-01 16:59   ` [edk2-devel] " Ard Biesheuvel
  2 siblings, 1 reply; 7+ messages in thread
From: Rebecca Cran @ 2022-02-01 16:58 UTC (permalink / raw)
  To: Ard Biesheuvel, Leif Lindholm, Marcin Wojtas, Masami Hiramatsu,
	devel

Sorry, I forgot to add a cover letter.

I noticed some breakages in Arm platforms caused by additions of 
VariablePolicyHelperLib: the 3 patches fix them by adding it to 
LibraryClasses.common.


-- 
Rebecca Cran


On 2/1/22 09:56, Rebecca Cran wrote:
> The VariablePolicyHelperLib is now used by a number of driver types, so
> instead of duplicating it, move it into the LibraryClasses.common section.
>
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
>   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index af207391209c..41c1cadc3425 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -125,6 +125,7 @@ DEFINE X64EMU_ENABLE  = FALSE
>     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>     RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
>     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>   
>     UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -209,7 +210,6 @@ DEFINE X64EMU_ENABLE  = FALSE
>     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
>     MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>     NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>   
>   [LibraryClasses.common.DXE_RUNTIME_DRIVER]
>     HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> @@ -219,7 +219,6 @@ DEFINE X64EMU_ENABLE  = FALSE
>     DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
>   !endif
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>   
>   [LibraryClasses.common.UEFI_APPLICATION]
>     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common
  2022-02-01 16:58 ` [PATCH 1/3] Platform/AMD: " Rebecca Cran
@ 2022-02-01 16:59   ` Ard Biesheuvel
  2022-02-01 17:14     ` Ard Biesheuvel
  0 siblings, 1 reply; 7+ messages in thread
From: Ard Biesheuvel @ 2022-02-01 16:59 UTC (permalink / raw)
  To: edk2-devel-groups-io, Rebecca Cran
  Cc: Ard Biesheuvel, Leif Lindholm, Marcin Wojtas, Masami Hiramatsu

On Tue, 1 Feb 2022 at 17:58, Rebecca Cran <quic_rcran@quicinc.com> wrote:
>
> Sorry, I forgot to add a cover letter.
>
> I noticed some breakages in Arm platforms caused by additions of
> VariablePolicyHelperLib: the 3 patches fix them by adding it to
> LibraryClasses.common.
>
>

No worries - I'll pick these up momentarily.



>
>
> On 2/1/22 09:56, Rebecca Cran wrote:
> > The VariablePolicyHelperLib is now used by a number of driver types, so
> > instead of duplicating it, move it into the LibraryClasses.common section.
> >
> > Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> > ---
> >   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > index af207391209c..41c1cadc3425 100644
> > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > @@ -125,6 +125,7 @@ DEFINE X64EMU_ENABLE  = FALSE
> >     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> >     RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
> >     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> > +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> >     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> >
> >     UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > @@ -209,7 +210,6 @@ DEFINE X64EMU_ENABLE  = FALSE
> >     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> >     MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> >     NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> > -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> >
> >   [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> >     HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> > @@ -219,7 +219,6 @@ DEFINE X64EMU_ENABLE  = FALSE
> >     DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> >   !endif
> >     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> > -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> >
> >   [LibraryClasses.common.UEFI_APPLICATION]
> >     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
>
>
> 
>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] Silicon/Marvell: Move VariablePolicyHelperLib into LibraryClasses.common
  2022-02-01 16:56 ` [PATCH 3/3] Silicon/Marvell: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
@ 2022-02-01 17:03   ` Marcin Wojtas
  0 siblings, 0 replies; 7+ messages in thread
From: Marcin Wojtas @ 2022-02-01 17:03 UTC (permalink / raw)
  To: Rebecca Cran
  Cc: Ard Biesheuvel, Leif Lindholm, Masami Hiramatsu,
	edk2-devel-groups-io

Hi,


wt., 1 lut 2022 o 17:56 Rebecca Cran <quic_rcran@quicinc.com> napisał(a):
>
> The VariablePolicyHelperLib is now used by a number of driver types, so
> instead of duplicating it, move it into the LibraryClasses.common section.
>
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 5e153782079c..9322ad881e69 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -69,6 +69,7 @@
>    UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
>    UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
>    UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
> +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>
> @@ -175,7 +176,6 @@
>    MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>    NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
>    DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
> -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>
>  [LibraryClasses.common.UEFI_APPLICATION]
>    PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> @@ -198,7 +198,6 @@
>  !endif
>    DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
>    VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>
>  [LibraryClasses.ARM, LibraryClasses.AARCH64]
>    #
> --
> 2.30.2
>

Reviewed-by: Marcin Wojtas <mw@semihalf.com>

Thanks,
Marcin

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common
  2022-02-01 16:59   ` [edk2-devel] " Ard Biesheuvel
@ 2022-02-01 17:14     ` Ard Biesheuvel
  0 siblings, 0 replies; 7+ messages in thread
From: Ard Biesheuvel @ 2022-02-01 17:14 UTC (permalink / raw)
  To: edk2-devel-groups-io, Rebecca Cran
  Cc: Ard Biesheuvel, Leif Lindholm, Marcin Wojtas, Masami Hiramatsu

On Tue, 1 Feb 2022 at 17:59, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Tue, 1 Feb 2022 at 17:58, Rebecca Cran <quic_rcran@quicinc.com> wrote:
> >
> > Sorry, I forgot to add a cover letter.
> >
> > I noticed some breakages in Arm platforms caused by additions of
> > VariablePolicyHelperLib: the 3 patches fix them by adding it to
> > LibraryClasses.common.
> >
> >
>
> No worries - I'll pick these up momentarily.
>

Series

    Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Pushed as 5777ed5d604e..ce768c6535cd

Thanks,
Ard.

>
>
> >
> >
> > On 2/1/22 09:56, Rebecca Cran wrote:
> > > The VariablePolicyHelperLib is now used by a number of driver types, so
> > > instead of duplicating it, move it into the LibraryClasses.common section.
> > >
> > > Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> > > ---
> > >   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > > index af207391209c..41c1cadc3425 100644
> > > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > > @@ -125,6 +125,7 @@ DEFINE X64EMU_ENABLE  = FALSE
> > >     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > >     RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > >     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> > > +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> > >     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> > >
> > >     UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > @@ -209,7 +210,6 @@ DEFINE X64EMU_ENABLE  = FALSE
> > >     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> > >     MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> > >     NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> > > -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> > >
> > >   [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> > >     HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> > > @@ -219,7 +219,6 @@ DEFINE X64EMU_ENABLE  = FALSE
> > >     DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> > >   !endif
> > >     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> > > -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> > >
> > >   [LibraryClasses.common.UEFI_APPLICATION]
> > >     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> >
> >
> > 
> >
> >

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-02-01 17:14 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-01 16:56 [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
2022-02-01 16:56 ` [PATCH 2/3] Platform/Socionext: Move VariablePolicyHelperLib to LibraryClasses.common Rebecca Cran
2022-02-01 16:56 ` [PATCH 3/3] Silicon/Marvell: Move VariablePolicyHelperLib into LibraryClasses.common Rebecca Cran
2022-02-01 17:03   ` Marcin Wojtas
2022-02-01 16:58 ` [PATCH 1/3] Platform/AMD: " Rebecca Cran
2022-02-01 16:59   ` [edk2-devel] " Ard Biesheuvel
2022-02-01 17:14     ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox