Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]

Hi Ard,


Thanks,
Chao
On 2023/12/21 15:31, Ard Biesheuvel wrote:
> On Thu, 21 Dec 2023 at 04:48, Chao Li<lichao@loongson.cn>  wrote:
> ...
>> Ard,
>>
>> PcdPciIoTranslationIsEnabled is only use for whether to trigger the Ffio read or write, it seem that only x86 or x64 need them, not others.
>>
>> When I was submitted the patch V2, CpuIo2Dxe was private to LoongArch, just like Arm and RISC-V. Gerd recommended finding a better place for ArmPciCpuIo2Dxe so that other ARCH can easily use it. And then I found the UefiCpuPkg/CpuIo2Dxe might be able to accommodate the MMIO methods, so I merged them togeter in this change.
>>
> I think it makes sense to have a shared implementation under
> UefiCpuPkg or even MdeModulePkg. But merging it with the x86
> implementation using function pointers that are dereferenced at
> runtime seems unnecessary to me.
So what do you suggest? Write some new functions to handle the MMIO 
method under the CpuIo2Dxe?
>
> My preference would be to put this into MdeModulePkg, but Ray may have
> a different view.
Let's wait for Ray together. :)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112811): https://edk2.groups.io/g/devel/message/112811
Mute This Topic: https://groups.io/mt/103261693/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3290 bytes --]