public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ruiyu Ni <ruiyu.ni@intel.com>, edk2-devel@lists.01.org
Cc: Jiewen Yao <jiewen.yao@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: Re: [PATCH v2] UefiCpuPkg/SmmCpu: Block access-out only when static paging is used
Date: Wed, 7 Nov 2018 15:46:28 +0100	[thread overview]
Message-ID: <a88be864-833c-c99b-e0b0-e96bc9b7f7aa@redhat.com> (raw)
In-Reply-To: <20181107085907.158392-1-ruiyu.ni@intel.com>

On 11/07/18 09:59, Ruiyu Ni wrote:
> From: Jiewen Yao <jiewen.yao@intel.com>
> 
> When static paging is disabled, page table for below 4GB is created
> and page table for above 4GB is created dynamically in page fault
> handler.
> 
> Today's implementation only allow SMM access-out to below types of
> memory address no matter static paging is enabled or not:
> 1. Reserved, run time and ACPI NVS type
> 2. MMIO
> 
> But certain platform feature like RAS may need to access other types
> of memory from SMM. Today's code blocks these platforms.
> This patch simplifies the policy to only block when static paging
> is used so that the static paging can be disabled in these platforms
> to meet their SMM access-out need.
> 
> Setting PcdCpuSmmStaticPageTable to FALSE can disable the static
> paging.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, this has improved a lot!
Laszlo


  parent reply	other threads:[~2018-11-07 14:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07  8:59 [PATCH v2] UefiCpuPkg/SmmCpu: Block access-out only when static paging is used Ruiyu Ni
2018-11-07  9:13 ` Yao, Jiewen
2018-11-07 14:46 ` Laszlo Ersek [this message]
2018-11-07 14:58   ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a88be864-833c-c99b-e0b0-e96bc9b7f7aa@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox