From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68398AC12FC for ; Wed, 27 Sep 2023 15:07:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/s5khx29Ku7QdrMX+v9eF68E62yd4qJ9sG1xx31EKHA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695827241; v=1; b=NNyVo6SLCF8D39/VdF476W5FWcbqKomFxIr4pM1QqZv3lBvdhj2Izkf2cF9ktwEWga5oF2UX +sPAaeREyKVndMp6oY/SvG8YJWJJC3mhrEbG/rg3rEYNiW80+j8guLKgkDPEzp3oZ0exUvKSHXs c576rUNiMrk0bvajrYxn5+4w= X-Received: by 127.0.0.2 with SMTP id zlqQYY7687511xmLQmvZm33q; Wed, 27 Sep 2023 08:07:21 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.19613.1695827239971218626 for ; Wed, 27 Sep 2023 08:07:20 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFEC71FB; Wed, 27 Sep 2023 08:07:56 -0700 (PDT) X-Received: from [10.57.93.35] (unknown [10.57.93.35]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 27FC03F59C; Wed, 27 Sep 2023 08:07:17 -0700 (PDT) Message-ID: Date: Wed, 27 Sep 2023 17:07:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v4 2/4] DynamicTablesPkg: Add support for simple method invocation. To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" , "jbrasen@nvidia.com" , Sami Mujawar Cc: Swatisri Kantamsetti , Ashish Singhal , nd References: <737650480edcab199927322064b2459f647f9f02.1695049337.git.jbrasen@nvidia.com> <885016b1-c8f3-8951-8473-15a37cd640a2@arm.com> From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QJTWbUa7T6Zvm4wKXQVFdULox7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NNyVo6SL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Abdul, On 9/23/23 06:22, Attar, AbdulLateef (Abdul Lateef) wrote: > [AMD Official Use Only - General] >=20 >=20 > Hi Jeff, Sami, >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 I=E2=80=99m not reviewer, just providing the opinion. >=20 > How about making it generic(generic to integer argument) =C2=A0instead of= single integer argument. >=20 > =C2=A0=C2=A0=C2=A0 IN=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 UINT64= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 IntegerArgument >=20 > =C2=A0=C2=A0=C2=A0 IN =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0UINT64 = **IntegerArgumentArray.* >=20 > Create the list(by making use of AmlVarListAddTail) of data object depend= s on IntergerArgument value. >=20 > Also, I think if data in data node is AML_ARG0(0x68), AML_ARG1=E2=80=A6.,= then it will considered as Arg0, Arg1, =E2=80=A6.etc. Just to be sure, you would like the method generated by AmlCodeGenMethodRet= NameStringIntegerArgument() to take multiple integer argument ? This would allow to generate a function= taking N input arguments like: Method(MET0, N, Serialized, 3) { Return (MET1 (1, 2, ..., N)) } It is true AmlCodeGenMethodRetNameStringIntegerArgument() takes a NumArgs p= arameter, but currently NumArgs can only equal 1. Is there a specific use case that you are looking to solve with this soluti= on ? Regards, Pierre >=20 > Thanks >=20 > AbduL >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109123): https://edk2.groups.io/g/devel/message/109123 Mute This Topic: https://groups.io/mt/101436335/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-