* [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
@ 2020-09-04 7:19 Abner Chang
2020-09-04 8:25 ` Laszlo Ersek
2020-09-04 10:04 ` [edk2-devel] " Laszlo Ersek
0 siblings, 2 replies; 6+ messages in thread
From: Abner Chang @ 2020-09-04 7:19 UTC (permalink / raw)
To: devel
Cc: abner.chang, Andrew Fish, Laszlo Ersek, Leif Lindholm,
Michael D Kinney, Leif Lindholm
Add reviewers for all /RiscV64 folders.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
Maintainers.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 57cd2fc662..6a22a14796 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -98,6 +98,11 @@ F: */Arm/
M: Leif Lindholm <leif@nuviainc.com>
M: Ard Biesheuvel <ard.biesheuvel@arm.com>
+RISCV64
+F: */RiscV64/
+M: Abner Chang <abner.chang@hpe.com>
+R: Daniel Schaefer <daniel.schaefer@hpe.com>
+
EDK II Continuous Integration:
------------------------------
.azurepipelines/
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
2020-09-04 7:19 [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64 Abner Chang
@ 2020-09-04 8:25 ` Laszlo Ersek
2020-09-04 8:51 ` Abner Chang
2020-09-04 10:04 ` [edk2-devel] " Laszlo Ersek
1 sibling, 1 reply; 6+ messages in thread
From: Laszlo Ersek @ 2020-09-04 8:25 UTC (permalink / raw)
To: Abner Chang, devel
Cc: Andrew Fish, Leif Lindholm, Michael D Kinney, Leif Lindholm
On 09/04/20 09:19, Abner Chang wrote:
> Add reviewers for all /RiscV64 folders.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Maintainers.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 57cd2fc662..6a22a14796 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -98,6 +98,11 @@ F: */Arm/
> M: Leif Lindholm <leif@nuviainc.com>
> M: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> +RISCV64
> +F: */RiscV64/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Daniel Schaefer <daniel.schaefer@hpe.com>
> +
> EDK II Continuous Integration:
> ------------------------------
> .azurepipelines/
>
What are the changes relative to v1?
(Also, I believe Leif is away at the moment, and I think we should have
his ACK on this patch, before we merge the patch.)
Thanks
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
2020-09-04 8:25 ` Laszlo Ersek
@ 2020-09-04 8:51 ` Abner Chang
2020-09-04 9:43 ` Laszlo Ersek
0 siblings, 1 reply; 6+ messages in thread
From: Abner Chang @ 2020-09-04 8:51 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io
Cc: Andrew Fish, Leif Lindholm, Michael D Kinney, Leif Lindholm
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, September 04, 2020 4:25 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>;
> Michael D Kinney <michael.d.kinney@intel.com>; Leif Lindholm
> <leif.lindholm@linaro.org>
> Subject: Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
>
> On 09/04/20 09:19, Abner Chang wrote:
> > Add reviewers for all /RiscV64 folders.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> > Maintainers.txt | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt index
> > 57cd2fc662..6a22a14796 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -98,6 +98,11 @@ F: */Arm/
> > M: Leif Lindholm <leif@nuviainc.com>
> > M: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >
> > +RISCV64
> > +F: */RiscV64/
> > +M: Abner Chang <abner.chang@hpe.com>
> > +R: Daniel Schaefer <daniel.schaefer@hpe.com>
> > +
> > EDK II Continuous Integration:
> > ------------------------------
> > .azurepipelines/
> >
>
> What are the changes relative to v1?
R: for Abner changed to M: for Abner
>
> (Also, I believe Leif is away at the moment, and I think we should have his
> ACK on this patch, before we merge the patch.)
Yes, I had few conversations with Leif and Mike for this in this.
Sure we can wait for his Ack.
Thanks
>
> Thanks
> Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
2020-09-04 8:51 ` Abner Chang
@ 2020-09-04 9:43 ` Laszlo Ersek
2020-09-04 10:07 ` Abner Chang
0 siblings, 1 reply; 6+ messages in thread
From: Laszlo Ersek @ 2020-09-04 9:43 UTC (permalink / raw)
To: Chang, Abner (HPS SW/FW Technologist), devel@edk2.groups.io
Cc: Andrew Fish, Leif Lindholm, Michael D Kinney, Leif Lindholm
Hi Abner,
On 09/04/20 10:51, Chang, Abner (HPS SW/FW Technologist) wrote:
>
>
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Friday, September 04, 2020 4:25 PM
>> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
>> devel@edk2.groups.io
>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>;
>> Michael D Kinney <michael.d.kinney@intel.com>; Leif Lindholm
>> <leif.lindholm@linaro.org>
>> Subject: Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
>>
>> On 09/04/20 09:19, Abner Chang wrote:
>>> Add reviewers for all /RiscV64 folders.
>>>
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>> Acked-by: Laszlo Ersek <lersek@redhat.com>
>>> ---
>>> Maintainers.txt | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Maintainers.txt b/Maintainers.txt index
>>> 57cd2fc662..6a22a14796 100644
>>> --- a/Maintainers.txt
>>> +++ b/Maintainers.txt
>>> @@ -98,6 +98,11 @@ F: */Arm/
>>> M: Leif Lindholm <leif@nuviainc.com>
>>> M: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>>
>>> +RISCV64
>>> +F: */RiscV64/
>>> +M: Abner Chang <abner.chang@hpe.com>
>>> +R: Daniel Schaefer <daniel.schaefer@hpe.com>
>>> +
>>> EDK II Continuous Integration:
>>> ------------------------------
>>> .azurepipelines/
>>>
>>
>> What are the changes relative to v1?
> R: for Abner changed to M: for Abner
>>
>> (Also, I believe Leif is away at the moment, and I think we should have his
>> ACK on this patch, before we merge the patch.)
> Yes, I had few conversations with Leif and Mike for this in this.
Wait, that reminds me... OK, I've looked up the v1 discussion now.
Is there any particular reason you didn't pick up Leif's Reviewed-by
from the v1 thread? Leif gave his R-b conditional on the R->M change for
your name:
https://edk2.groups.io/g/devel/message/64807
and you have implemented that change. So I think Leif's R-b should have
been picked up.
Based on <https://edk2.groups.io/g/devel/message/64810> -- do you have
push access to edk2 at this time? Because if that's the case, then we
should merge this patch now.
Hmm let me see.
https://github.com/orgs/tianocore/teams/edk-ii-maintainers/members
Yes, you are a member of this group.
https://github.com/orgs/tianocore/teams?query=@changab
So I'm going to apply Leif's R-b from the v1 thread now, and then merge
this patch.
Thanks,
Laszlo
> Sure we can wait for his Ack.
> Thanks
>>
>> Thanks
>> Laszlo
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
2020-09-04 7:19 [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64 Abner Chang
2020-09-04 8:25 ` Laszlo Ersek
@ 2020-09-04 10:04 ` Laszlo Ersek
1 sibling, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2020-09-04 10:04 UTC (permalink / raw)
To: devel, abner.chang
Cc: Andrew Fish, Leif Lindholm, Michael D Kinney, Leif Lindholm
On 09/04/20 09:19, Abner Chang wrote:
> Add reviewers for all /RiscV64 folders.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Maintainers.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 57cd2fc662..6a22a14796 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -98,6 +98,11 @@ F: */Arm/
> M: Leif Lindholm <leif@nuviainc.com>
> M: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> +RISCV64
> +F: */RiscV64/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Daniel Schaefer <daniel.schaefer@hpe.com>
> +
> EDK II Continuous Integration:
> ------------------------------
> .azurepipelines/
>
Merged as commit 2ace920de1e9, via
<https://github.com/tianocore/edk2/pull/915>.
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
2020-09-04 9:43 ` Laszlo Ersek
@ 2020-09-04 10:07 ` Abner Chang
0 siblings, 0 replies; 6+ messages in thread
From: Abner Chang @ 2020-09-04 10:07 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io
Cc: Andrew Fish, Leif Lindholm, Michael D Kinney, Leif Lindholm
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, September 04, 2020 5:44 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>;
> Michael D Kinney <michael.d.kinney@intel.com>; Leif Lindholm
> <leif.lindholm@linaro.org>
> Subject: Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64
>
> Hi Abner,
>
> On 09/04/20 10:51, Chang, Abner (HPS SW/FW Technologist) wrote:
> >
> >
> >> -----Original Message-----
> >> From: Laszlo Ersek [mailto:lersek@redhat.com]
> >> Sent: Friday, September 04, 2020 4:25 PM
> >> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> >> devel@edk2.groups.io
> >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>;
> >> Michael D Kinney <michael.d.kinney@intel.com>; Leif Lindholm
> >> <leif.lindholm@linaro.org>
> >> Subject: Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of
> >> */RiscV64
> >>
> >> On 09/04/20 09:19, Abner Chang wrote:
> >>> Add reviewers for all /RiscV64 folders.
> >>>
> >>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >>> Cc: Andrew Fish <afish@apple.com>
> >>> Cc: Laszlo Ersek <lersek@redhat.com>
> >>> Cc: Leif Lindholm <leif@nuviainc.com>
> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> >>> Acked-by: Laszlo Ersek <lersek@redhat.com>
> >>> ---
> >>> Maintainers.txt | 5 +++++
> >>> 1 file changed, 5 insertions(+)
> >>>
> >>> diff --git a/Maintainers.txt b/Maintainers.txt index
> >>> 57cd2fc662..6a22a14796 100644
> >>> --- a/Maintainers.txt
> >>> +++ b/Maintainers.txt
> >>> @@ -98,6 +98,11 @@ F: */Arm/
> >>> M: Leif Lindholm <leif@nuviainc.com>
> >>> M: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >>>
> >>> +RISCV64
> >>> +F: */RiscV64/
> >>> +M: Abner Chang <abner.chang@hpe.com>
> >>> +R: Daniel Schaefer <daniel.schaefer@hpe.com>
> >>> +
> >>> EDK II Continuous Integration:
> >>> ------------------------------
> >>> .azurepipelines/
> >>>
> >>
> >> What are the changes relative to v1?
> > R: for Abner changed to M: for Abner
> >>
> >> (Also, I believe Leif is away at the moment, and I think we should
> >> have his ACK on this patch, before we merge the patch.)
> > Yes, I had few conversations with Leif and Mike for this in this.
>
> Wait, that reminds me... OK, I've looked up the v1 discussion now.
>
> Is there any particular reason you didn't pick up Leif's Reviewed-by from the
> v1 thread? Leif gave his R-b conditional on the R->M change for your name:
Oops, I forget this. No particular reason to not picking up Leif's r-b.
>
> https://edk2.groups.io/g/devel/message/64807
>
> and you have implemented that change. So I think Leif's R-b should have
> been picked up.
>
> Based on <https://edk2.groups.io/g/devel/message/64810> -- do you have
> push access to edk2 at this time? Because if that's the case, then we should
> merge this patch now.
>
> Hmm let me see.
>
> https://github.com/orgs/tianocore/teams/edk-ii-maintainers/members
>
> Yes, you are a member of this group.
>
> https://github.com/orgs/tianocore/teams?query=@changab
>
> So I'm going to apply Leif's R-b from the v1 thread now, and then merge this
> patch.
Sure, thanks.
Abner
>
> Thanks,
> Laszlo
>
> > Sure we can wait for his Ack.
> > Thanks
> >>
> >> Thanks
> >> Laszlo
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-04 10:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-04 7:19 [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64 Abner Chang
2020-09-04 8:25 ` Laszlo Ersek
2020-09-04 8:51 ` Abner Chang
2020-09-04 9:43 ` Laszlo Ersek
2020-09-04 10:07 ` Abner Chang
2020-09-04 10:04 ` [edk2-devel] " Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox