From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.7555.1598944121786505820 for ; Tue, 01 Sep 2020 00:08:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fVXbqWht; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598944121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8c4QVRkOKEH/KqmDfAfUGKCCaWhSIdRUXXXs4TXayEg=; b=fVXbqWht/47nr/ETxdrlNkR514n6Qc4RHdGRac/O7C94EHQELeXVrR+kVh4o7ktC3cuLWk RQmZlgdrwrsV7THLSOXdd+bkBUzQB/h6NgL+wKg12+bj/psYPMBX491fqtQxzcoYLlULp9 K7XCzwGaRweDHRr4IK0EmtjjakN81vw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-Kbfr4X8ONyGTYQ3oix48vg-1; Tue, 01 Sep 2020 03:08:32 -0400 X-MC-Unique: Kbfr4X8ONyGTYQ3oix48vg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2CEBC100855C; Tue, 1 Sep 2020 07:08:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-251.ams2.redhat.com [10.36.112.251]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED4002634D; Tue, 1 Sep 2020 07:08:29 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull To: devel@edk2.groups.io, qi1.zhang@intel.com Cc: Jian J Wang , Hao A Wu , Jiewen Yao References: <20200901013557.9249-1-qi1.zhang@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 1 Sep 2020 09:08:29 +0200 MIME-Version: 1.0 In-Reply-To: <20200901013557.9249-1-qi1.zhang@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 09/01/20 03:35, Qi Zhang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 > > Signed-off-by: Qi Zhang > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Jiewen Yao > --- > .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > index 61abcfa2ec..327d80f319 100644 > --- a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > +++ b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > @@ -12,7 +12,7 @@ > FILE_GUID = 6DFD6E9F-9278-48D8-8F45-B6CFF2C2B69C > MODULE_TYPE = UEFI_DRIVER > VERSION_STRING = 1.0 > - LIBRARY_CLASS = TpmMeasurementLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER > + LIBRARY_CLASS = TpmMeasurementLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER PEIM SEC > MODULE_UNI_FILE = TpmMeasurementLibNull.uni > > # > It tends to improve readability if we keep the "earlier" / "more primitive" module types to the left, such as: SEC, PEIM, DXE_*, UEFI_* But I don't want to obsess about this: Reviewed-by: Laszlo Ersek Thanks, Laszlo