From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 02:39:03 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6AD013082B02; Tue, 17 Sep 2019 09:39:02 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0B0A60126; Tue, 17 Sep 2019 09:39:00 +0000 (UTC) Subject: Re: [PATCH V2 1/3] MdeModulePkg: Extend the support keyboard type of Terminal console To: Zhichao Gao , devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Ray Ni , Ard Biesheuvel , Liming Gao References: <20190917061912.17420-1-zhichao.gao@intel.com> <20190917061912.17420-2-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 17 Sep 2019 11:38:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190917061912.17420-2-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 17 Sep 2019 09:39:02 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/17/19 08:19, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 > > A common terminal console software Putty support various types of > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400, > VT100+ and SCO. Refer to the link: > https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > MdeModulePkg/Include/Guid/TtyTerm.h | 13 +++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > 2 files changed, 17 insertions(+) > > diff --git a/MdeModulePkg/Include/Guid/TtyTerm.h b/MdeModulePkg/Include/Guid/TtyTerm.h > index 8333344b9d..19e0faa8bc 100644 > --- a/MdeModulePkg/Include/Guid/TtyTerm.h > +++ b/MdeModulePkg/Include/Guid/TtyTerm.h > @@ -4,6 +4,7 @@ provide support for modern *nix terminals. > > > Copyright (c) 2015 Linaro Ltd. > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -14,6 +15,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #define EFI_TTY_TERM_GUID \ > {0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 } } > > +#define EDKII_LINUX_MODE_GUID \ > + {0xe4364a7f, 0xf825, 0x430e, {0x9d, 0x3a, 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 } } > + > +#define EDKII_XTERM_R6_GUID \ > + {0xfbfca56b, 0xbb36, 0x4b78, {0xaa, 0xab, 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb } } > + > +#define EDKII_VT400_GUID \ > + {0x8e46dddd, 0x3d49, 0x4a9d, {0xb8, 0x75, 0x3c, 0x08, 0x6f, 0x6a, 0xa2, 0xbd } } > + > +#define EDKII_SCO_GUID \ > + {0xfc7dd6e0, 0x813c, 0x434d, {0xb4, 0xda, 0x3b, 0xd6, 0x49, 0xe9, 0xe1, 0x5a } } > + > extern EFI_GUID gEfiTtyTermGuid; > > #endif > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 17beb45235..67b7bbd83d 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -342,6 +342,10 @@ > > ## Include/Guid/TtyTerm.h > gEfiTtyTermGuid = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }} > + gEdkiiLinuxModeGuid = { 0xe4364a7f, 0xf825, 0x430e, {0x9d, 0x3a, 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 }} > + gEdkiiXtermR6Guid = { 0xfbfca56b, 0xbb36, 0x4b78, {0xaa, 0xab, 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb }} > + gEdkiiVT400Guid = { 0x8e46dddd, 0x3d49, 0x4a9d, {0xb8, 0x75, 0x3c, 0x08, 0x6f, 0x6a, 0xa2, 0xbd }} > + gEdkiiSCOGuid = { 0xfc7dd6e0, 0x813c, 0x434d, {0xb4, 0xda, 0x3b, 0xd6, 0x49, 0xe9, 0xe1, 0x5a }} > > ## Include/Guid/HiiBootMaintenanceFormset.h > gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89, 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} > Shouldn't we put "Tty" or "Term" or "Terminal" somewhere in the symbolic names of the GUIDs? "Xterm" and "VT400" are OK already, but "LinuxMode" and "SCO" are too general, in my opinion. Just a random comment, I defer to the MdeModulePkg maintainers. Thanks Laszlo