From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.4092.1675299883559443891
 for <devel@edk2.groups.io>;
 Wed, 01 Feb 2023 17:04:43 -0800
Authentication-Results: mx.groups.io;
 dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=jO6F2972;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id CD93420B74F7;
	Wed,  1 Feb 2023 17:04:41 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CD93420B74F7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1675299883;
	bh=SZu/Cqoavu709qWKXDUyhh1vI69hgzIDmpi5QcFMiQk=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=jO6F2972cunVbOvM78hFoOZPKvJUyemnGwBb6AE3rGupA+xm1A1VLTf6KMMkKOAk7
	 Q35bojIHvlMb7855FhkM9H8e3jdxd1+BKT3r/UTl8nJL+aIwJlF/SZOQamRDshf3ik
	 6/3W4QdDZbbN0FygLs0PJEOt/mV7Fx44Lz6MozFU=
Message-ID: <a90e1758-7beb-d1fd-be12-a0dc056047e0@linux.microsoft.com>
Date: Wed, 1 Feb 2023 20:04:40 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 1/1] .pytool/Plugin/EccCheck: Add PACKAGES_PATH support
To: =?UTF-8?Q?Marvin_Ha=cc=88user?= <mhaeuser@posteo.de>, devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Pedro Falcato <pedro.falcato@gmail.com>
References: <20230201144750.71495-1-mhaeuser@posteo.de>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230201144750.71495-1-mhaeuser@posteo.de>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 2/1/2023 9:47 AM, Marvin Ha=CC=88user wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4326
>=20
> EccBuild currently assumes all packages reside in WORKSPACE. However,
> this is obviously not the case for many setups. Most notably, Ext4Pkg
> is located in edk2-platforms/Features and thus cannot be in WORKSPACE
> in any reasonable setup.
>=20
> Use Edk2Path to locate the package in WORKSPACE and PACKAGES_PATH.
>=20
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Signed-off-by: Marvin H=C3=A4user <mhaeuser@posteo.de>
> ---
>   .pytool/Plugin/EccCheck/EccCheck.py | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>=20
> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCh=
eck/EccCheck.py
> index 4fbc67765fdf..7235fcb55cea 100644
> --- a/.pytool/Plugin/EccCheck/EccCheck.py
> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> @@ -69,6 +69,13 @@ class EccCheck(ICiBuildPlugin):
>           env.set_shell_var('PACKAGES_PATH', os.pathsep.join(Edk2pathOb=
j.PackagePathList))
>           self.ECC_PASS =3D True
>  =20
> +        abs_pkg_path =3D Edk2pathObj.GetAbsolutePathOnThisSystemFromEd=
k2RelativePath(packagename)
> +
> +        if abs_pkg_path is None:
> +            tc.SetSkipped()
> +            tc.LogStdError("No Package folder {0}".format(abs_pkg_path=
))
> +            return 0
> +
>           # Create temp directory
>           temp_path =3D os.path.join(workspace_path, 'Build', '.pytool'=
, 'Plugin', 'EccCheck')
>           try:
> @@ -77,7 +84,7 @@ class EccCheck(ICiBuildPlugin):
>                   shutil.rmtree(temp_path)
>               # Copy package being scanned to temp_path
>               shutil.copytree (
> -              os.path.join(workspace_path, packagename),
> +              abs_pkg_path,
>                 os.path.join(temp_path, packagename),
>                 symlinks=3DTrue
>                 )