From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 65702740039 for ; Mon, 4 Mar 2024 15:44:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lSrQjtAdFpXQ6ExR1TWPWzT748D4DYvWPYnv6XRrDpQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Received-SPF:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1709567052; v=1; b=vxhRSw12cft/000idu6Y14XKNlu4GvicPnQ4SlvnZQAd/SjNuP+Qd5jmYyRqQtxNhGKnbhxD RefXaOkZ20sbvdpGPCg6DpAk6Kg3DIFK85la5Agk20lGS4eKplBMB8l8ANflD8gI99vMwHWdqNI xSl3TSZx3BfVvAoOXB5ZRfjY= X-Received: by 127.0.0.2 with SMTP id l3t8YY7687511xafKH2GEIle; Mon, 04 Mar 2024 07:44:12 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.76]) by mx.groups.io with SMTP id smtpd.web11.102093.1709567051354765959 for ; Mon, 04 Mar 2024 07:44:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WCXffOMkzYCha1P7AH+eEQd790pyzzZjGUN1RxQyJteJPyDguNxZnhmE37lPi542nXENv/l5kMBpIrs4w4NYDIQYYpYWgIaI+62r5vGWQeoxYXpinLJ9z5wpdVveIGN5fAmf8mKKmnJu2f53IMLETxb7YjK3NB6l5E8n5S5KjYLugM6da7y84GRGL5LGAZ9MbIL2qrYo7yrZpnN1YxT2xBDRF07JOOB9lb3wCqQglZGbsWQ2QepHo++CYHmqsiXwh+VIWjnCze+Ii621X7unUUunni/yUCXsvoCmrZrmuJ3zSG0aw3pyhLuuENjyiYgquh4K2SKPPho1IO0sKoDnMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z3gZFEzFtP2UEK/AZ4jLBI22+SP0uAf4VclIDC4jPdE=; b=akzC+uh04si8ZmOTHccEe+Jm9mBFTuZVRTWCAQajL1oef2qpNQNPnjLIaPGmfmU884AIHG/BFWpiqx4IPU6BMAExdy0EHLQt8HzpOJY8X8c7vIjVhUU28EPLr7f3CoH08AKg5YhaAVyggKzZJ4IDl53qu1XPTsPCS47Diy4uxzuZxznGIWpKSbBQ1ibbmsbOtpuoqri1/dpwy288CsylzEz/xLpmLtNbTomn1vK2+YcdYK7VbH0VSSbT/7SJqu8yc/14lFhZcIV/C/kk5omxBMWagXaH71qEQAvDfBfkfl8S1vEVUkDAlpWVg/8T0AKxkyV0Dg4h6rplLjVPXpq5vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from CY5PR15CA0098.namprd15.prod.outlook.com (2603:10b6:930:7::7) by SN7PR12MB8604.namprd12.prod.outlook.com (2603:10b6:806:273::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Mon, 4 Mar 2024 15:44:08 +0000 X-Received: from CY4PEPF0000EE32.namprd05.prod.outlook.com (2603:10b6:930:7:cafe::e3) by CY5PR15CA0098.outlook.office365.com (2603:10b6:930:7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39 via Frontend Transport; Mon, 4 Mar 2024 15:44:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE32.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7362.11 via Frontend Transport; Mon, 4 Mar 2024 15:44:08 +0000 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 09:44:05 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Mon, 4 Mar 2024 09:44:04 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Sami Mujawar , Pierre Gondois Subject: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Adds ACPI HPET Table generator Date: Mon, 4 Mar 2024 21:13:54 +0530 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Received-SPF: None (SATLEXMB04.amd.com: abdattar@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE32:EE_|SN7PR12MB8604:EE_ X-MS-Office365-Filtering-Correlation-Id: 02a997c7-e2b6-4954-64d4-08dc3c61ee49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: WMsnH9S2DTdckDp5Ssnfqzmsj+PKjl/4YmCMSWRslIKW2rhYQO1f3lf4cdXxSsFYNiSyeH+v0s0IFRpM1vDLqAk9SghsjSLCwAc3vnAKcNiKX0bfkAEKIeCkiyDXuWwSdOIDLq4/7PZa8vRpyo14iGl1p+zlU77D8FMzW8+o+/Jiiep6z2G0KLrXYpMehSntVATZnonUZMNftH1MZmRLtLiGpwpYAZaOs8t8RIcwUc3faK6J0R+ffgKTuGwDz7vDJT7CyROIR9PTHdlbLlGHIKqqmkl+y4CZehx3Ay9voR56HlAzwi3VgA46/hNzd0txOj+Vd3xFMCAZvsEFpI5cpSYKD/TIlRVbvl2JJeJBoX1/Lkqq+qQIBZ5Sg6xgkRNNOPmIHh/cTRnb+MTHFQpwu1gaYO2f6TJEkQTDzm5e7pdkcmcdtRoTQkrC1LsCEsGoCEQMwWava6w9hKXdT2jFswFpaeOf49nI62YyCzt3un5qasel28Td2XzEp/DoSVQlvdSsthlQcgBidDlDAAUmals9HrEIsM7AtqEvWG7gfuvGh8Zb4rakSeTx48M1NTXR4WPBbYFefGlHpyBjYOHWnZ6sRArN3VrHzK61vrrevOycBtW62Gm5hZYn8oIpvehGTMvU50PurpLi1fO1mk8uUydUdGh1PqTGsis3AOu7FlrAbjsQIpOBQK1ZuYbhi5lUvACsDPa0H75sSblPIo01N2JvDZisb7QQZ9H1UdCkFPNCCGvUdprgGOMtpPmzIODR X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 15:44:08.5955 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02a997c7-e2b6-4954-64d4-08dc3c61ee49 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE32.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8604 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FLbWyZ0ae5NMg09J6dxMh9TCx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vxhRSw12; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") From: Abdul Lateef Attar Adds generic ACPI HPET table generator library. Register/Deregister HPET table. Update the HPET table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc | 2 + DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 3 +- DynamicTablesPkg/Include/AcpiTableGenerator.h | 1 + .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf | 35 +++ .../Library/Acpi/AcpiHpetLib/HpetGenerator.c | 216 ++++++++++++++++++ 5 files changed, 256 insertions(+), 1 deletion(-) create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.i= nf create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerator= .c diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/Dyna= micTables.dsc.inc index 92f3a138e4..b2ef36eb8a 100644 --- a/DynamicTablesPkg/DynamicTables.dsc.inc +++ b/DynamicTablesPkg/DynamicTables.dsc.inc @@ -34,6 +34,7 @@ # Generators # DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf + DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf =20 [Components.IA32, Components.X64] # @@ -42,6 +43,7 @@ DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.i= nf { NULL|DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf + NULL|DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf } =20 [Components.ARM, Components.AARCH64] diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/D= ynamicTablesPkg.ci.yaml index 1ad5540e24..cacdaa1df6 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml @@ -53,7 +53,8 @@ "EmbeddedPkg/EmbeddedPkg.dec", "DynamicTablesPkg/DynamicTablesPkg.dec", "MdeModulePkg/MdeModulePkg.dec", - "MdePkg/MdePkg.dec" + "MdePkg/MdePkg.dec", + "PcAtChipsetPkg/PcAtChipsetPkg.dec" ], # For host based unit tests "AcceptableDependencies-HOST_APPLICATION":[ diff --git a/DynamicTablesPkg/Include/AcpiTableGenerator.h b/DynamicTablesP= kg/Include/AcpiTableGenerator.h index d0eda011c3..18b5f99f47 100644 --- a/DynamicTablesPkg/Include/AcpiTableGenerator.h +++ b/DynamicTablesPkg/Include/AcpiTableGenerator.h @@ -99,6 +99,7 @@ typedef enum StdAcpiTableId { EStdAcpiTableIdSsdtCpuTopology, ///< SSDT Cpu Topology EStdAcpiTableIdSsdtPciExpress, ///< SSDT Pci Express Gene= rator EStdAcpiTableIdPcct, ///< PCCT Generator + EStdAcpiTableIdHpet, ///< HPET Generator EStdAcpiTableIdMax } ESTD_ACPI_TABLE_ID; =20 diff --git a/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf b/Dy= namicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf new file mode 100644 index 0000000000..9f89bc9fb6 --- /dev/null +++ b/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf @@ -0,0 +1,35 @@ +## @file +# HPET Table Generator +# +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +## + +[Defines] + INF_VERSION =3D 1.27 + BASE_NAME =3D AcpiHpetLib + FILE_GUID =3D 4E75F653-C356-48B3-B32C-D1B901ECF90A + VERSION_STRING =3D 1.0 + MODULE_TYPE =3D DXE_DRIVER + LIBRARY_CLASS =3D NULL|DXE_DRIVER + CONSTRUCTOR =3D AcpiHpetLibConstructor + DESTRUCTOR =3D AcpiHpetLibDestructor + +[Sources] + HpetGenerator.c + +[Packages] + DynamicTablesPkg/DynamicTablesPkg.dec + MdeModulePkg/MdeModulePkg.dec + MdePkg/MdePkg.dec + PcAtChipsetPkg/PcAtChipsetPkg.dec + +[LibraryClasses] + BaseLib + DebugLib + IoLib + PcdLib + +[Pcd] + gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress diff --git a/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerator.c b/Dy= namicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerator.c new file mode 100644 index 0000000000..df4cc3969f --- /dev/null +++ b/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerator.c @@ -0,0 +1,216 @@ +/** @file + HPET Table Generator + + Copyright (c) 2017 - 2023, Arm Limited. All rights reserved. + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. + + SPDX-License-Identifier: BSD-2-Clause-Patent + + @par Reference(s): + - ACPI 6.5 Specification, Aug 29, 2022 + - HPET spec, version 1.0a + +**/ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/** The Creator ID for the ACPI tables generated using + the standard ACPI table generators. +*/ +#define TABLE_GENERATOR_CREATOR_ID_GENERIC SIGNATURE_32('D', 'Y', 'N', 'T= ') + +/** This macro defines the HPET Table Generator revision. +*/ +#define HPET_GENERATOR_REVISION CREATE_REVISION (1, 0) + +/** The AcpiHpet is a template EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_TABLE_H= EADER + structure used for generating the HPET Table. +*/ +STATIC +EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_TABLE_HEADER mAcpiHpet =3D { + ACPI_HEADER ( + EFI_ACPI_6_5_HIGH_PRECISION_EVENT_TIMER_TABLE_SIGNATURE, + EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_TABLE_HEADER, + EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_TABLE_REVISION + ), + // EventTimerBlockId + 0, + // BaseAddressLower32Bit + { EFI_ACPI_6_5_SYSTEM_MEMORY, 0,0, EFI_ACPI_= RESERVED_BYTE, 0 }, + // HpetNumber + 0, + // MainCounterMinimumClockTickInPeriodicMode + 0, + // PageProtectionAndOemAttribute + EFI_ACPI_NO_PAGE_PROTECTION +}; + +/** Construct the HPET table. + + This function invokes the Configuration Manager protocol interface + to get the required hardware information for generating the ACPI + table. + + If this function allocates any resources then they must be freed + in the FreeXXXXTableResources function. + + @param [in] This Pointer to the table generator. + @param [in] AcpiTableInfo Pointer to the ACPI Table Info. + @param [in] CfgMgrProtocol Pointer to the Configuration Manager + Protocol Interface. + @param [out] Table Pointer to the constructed ACPI Table. + + @retval EFI_SUCCESS Table generated successfully. + @retval EFI_INVALID_PARAMETER A parameter is invalid. + @retval EFI_NOT_FOUND The required object was not found. + @retval EFI_BAD_BUFFER_SIZE The size returned by the Configuration + Manager is less than the Object size for t= he + requested object. +**/ +STATIC +EFI_STATUS +BuildHpetTable ( + IN CONST ACPI_TABLE_GENERATOR *CONST This, + IN CONST CM_STD_OBJ_ACPI_TABLE_INFO *CONST AcpiTableInfo, + IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL *CONST CfgMgrProtocol, + OUT EFI_ACPI_DESCRIPTION_HEADER **CONST Table + ) +{ + EFI_STATUS Status; + + ASSERT (This !=3D NULL); + ASSERT (AcpiTableInfo !=3D NULL); + ASSERT (CfgMgrProtocol !=3D NULL); + ASSERT (Table !=3D NULL); + ASSERT (AcpiTableInfo->TableGeneratorId =3D=3D This->GeneratorID); + ASSERT (AcpiTableInfo->AcpiTableSignature =3D=3D This->AcpiTableSignatur= e); + + if ((AcpiTableInfo->AcpiTableRevision < This->MinAcpiTableRevision) || + (AcpiTableInfo->AcpiTableRevision > This->AcpiTableRevision)) + { + DEBUG (( + DEBUG_ERROR, + "ERROR: HPET: Requested table revision =3D %d, is not supported." + "Supported table revision: Minimum =3D %d, Maximum =3D %d\n", + AcpiTableInfo->AcpiTableRevision, + This->MinAcpiTableRevision, + This->AcpiTableRevision + )); + return EFI_INVALID_PARAMETER; + } + + *Table =3D NULL; + + Status =3D AddAcpiHeader ( + CfgMgrProtocol, + This, + (EFI_ACPI_DESCRIPTION_HEADER *)&mAcpiHpet, + AcpiTableInfo, + sizeof (EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_TABLE_HEADER) + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "ERROR: HPET: Failed to add ACPI header. Status =3D %r\n", + Status + )); + return Status; + } + + mAcpiHpet.BaseAddressLower32Bit.Address =3D PcdGet32 (PcdHpe= tBaseAddress); + mAcpiHpet.EventTimerBlockId =3D MmioRead32 (PcdG= et32 (PcdHpetBaseAddress) + HPET_GENERAL_CAPABILITIES_ID_OFFSET); + mAcpiHpet.MainCounterMinimumClockTickInPeriodicMode =3D (UINT16)MmioRead= 32 (PcdGet32 (PcdHpetBaseAddress) + HPET_GENERAL_CAPABILITIES_ID_OFFSET + 4= ); + *Table =3D (EFI_ACPI_DESCRI= PTION_HEADER *)&mAcpiHpet; + + return Status; +} + +/** The interface for the HPET Table Generator. +*/ +STATIC +CONST +ACPI_TABLE_GENERATOR mHpetGenerator =3D { + // Generator ID + CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdHpet), + // Generator Description + L"ACPI.STD.HPET.GENERATOR", + // ACPI Table Signature + EFI_ACPI_6_5_HIGH_PRECISION_EVENT_TIMER_TABLE_SIGNATURE, + // ACPI Table Revision supported by this Generator + EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_TABLE_REVISION, + // Minimum supported ACPI Table Revision + EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_TABLE_REVISION, + // Creator ID + TABLE_GENERATOR_CREATOR_ID_GENERIC, + // Creator Revision + HPET_GENERATOR_REVISION, + // Build Table function + BuildHpetTable, + // No additional resources are allocated by the generator. + // Hence the Free Resource function is not required. + NULL, + // Extended build function not needed + NULL, + // Extended build function not implemented by the generator. + // Hence extended free resource function is not required. + NULL +}; + +/** Register the Generator with the ACPI Table Factory. + + @param [in] ImageHandle The handle to the image. + @param [in] SystemTable Pointer to the System Table. + + @retval EFI_SUCCESS The Generator is registered. + @retval EFI_INVALID_PARAMETER A parameter is invalid. + @retval EFI_ALREADY_STARTED The Generator for the Table ID + is already registered. +**/ +EFI_STATUS +EFIAPI +AcpiHpetLibConstructor ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + EFI_STATUS Status; + + Status =3D RegisterAcpiTableGenerator (&mHpetGenerator); + DEBUG ((DEBUG_INFO, "HPET: Register Generator. Status =3D %r\n", Status)= ); + ASSERT_EFI_ERROR (Status); + return Status; +} + +/** Deregister the Generator from the ACPI Table Factory. + + @param [in] ImageHandle The handle to the image. + @param [in] SystemTable Pointer to the System Table. + + @retval EFI_SUCCESS The Generator is deregistered. + @retval EFI_INVALID_PARAMETER A parameter is invalid. + @retval EFI_NOT_FOUND The Generator is not registered. +**/ +EFI_STATUS +EFIAPI +AcpiHpetLibDestructor ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + EFI_STATUS Status; + + Status =3D DeregisterAcpiTableGenerator (&mHpetGenerator); + DEBUG ((DEBUG_INFO, "HPET: Deregister Generator. Status =3D %r\n", Statu= s)); + ASSERT_EFI_ERROR (Status); + return Status; +} --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116326): https://edk2.groups.io/g/devel/message/116326 Mute This Topic: https://groups.io/mt/104724516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-