From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from FRA01-PR2-obe.outbound.protection.outlook.com (FRA01-PR2-obe.outbound.protection.outlook.com [40.107.12.50]) by mx.groups.io with SMTP id smtpd.web08.20906.1621265620635059418 for ; Mon, 17 May 2021 08:33:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=sO5+uUzA; spf=pass (domain: arm.com, ip: 40.107.12.50, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BHqRTH+w8NQSnWtAkkxap1P3tsuUM6vmH6mH50NaY0M=; b=sO5+uUzAncrIIuplMJqy4DXMbd8AKcHxX4t8nn4mqC7Vr+fPpAtFkBY+762kMlqvDwrXH9ilntXbe5Qc1fJQH1NiL0b9pH4f4W2JSrFN0/vfu4F+FSr1u5UZcIBQ+GgF/sTqAsqjO5oWmzNdFbTbjxfwjG+siJtXCVkdsvHZoqM= Received: from DB6PR0501CA0029.eurprd05.prod.outlook.com (2603:10a6:4:67::15) by PR2PR08MB4652.eurprd08.prod.outlook.com (2603:10a6:101:18::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Mon, 17 May 2021 15:33:37 +0000 Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:67:cafe::5f) by DB6PR0501CA0029.outlook.office365.com (2603:10a6:4:67::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 17 May 2021 15:33:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 17 May 2021 15:33:37 +0000 Received: ("Tessian outbound 6c8a2be3c2e7:v92"); Mon, 17 May 2021 15:33:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b20383b0808bdb1e X-CR-MTA-TID: 64aa7808 Received: from 1a87767b42f0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D9223ECB-A52B-455C-AA9C-E647EA80EFCC.1; Mon, 17 May 2021 15:33:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1a87767b42f0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 17 May 2021 15:33:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lqXS0U4pp7sfXDW9bXUKUgI4t/kwd/j5AI6qUdYnSCFxP6giti7qnXyOWW+tFI1BDY0hkeUYXlvICnulVHAsyCS9lusuppr0Vh3jW3TtNXb9ehnLk9eL5C06EI0oXWo+39RDKn0aBU3m/LP6wdsut8OFTyEtOY/8gZaCwolzDnwTvRgZfNUDhtavmIR0uPXuHEFEGUWYMk4Qx/ur+9DdllEQJjRDmF79QhEIlclUwI5SYlNorW42lKU9UWGOiS4A4dL1v3Ac/rd/EurFeAerXc7IzY1+5ykyBpObeMyS20hd/aIiBcXZWiKQZUPzE5Yp5N7JTTZaBn6w1A0egKgJdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BHqRTH+w8NQSnWtAkkxap1P3tsuUM6vmH6mH50NaY0M=; b=KmPfRMqeSG4xCZ0c0fMqt8Q5lhTmEFnOwb0hGk3UBoIHIxSlkHvzDbNfgUQHCk+CqH0HJj0f0NtMUE7vYxaBAHPOYzxss3n2R6CIQnAbkJx2jr9Ip06nlPXAIo3ZJTvlozxCU7ouf9LVeK4yHDWBvJAz1n+o8y3kXphAeWc2juYkfCnG4UvUAq5CSS+WLuezDBWwAl4jJqBlJuwx0UGKDC4t9qQ8BK6cXg7tHvg7k3Bpv26jEwTmKaZeeXDqaabh6E6CtBlgr1NBVKB6sbe5EpYD1xQkncxHOkDTK1lD68qHddiuC6jJG1xBomVIdhnTPCN2rONbTX1aRjNY1sScEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BHqRTH+w8NQSnWtAkkxap1P3tsuUM6vmH6mH50NaY0M=; b=sO5+uUzAncrIIuplMJqy4DXMbd8AKcHxX4t8nn4mqC7Vr+fPpAtFkBY+762kMlqvDwrXH9ilntXbe5Qc1fJQH1NiL0b9pH4f4W2JSrFN0/vfu4F+FSr1u5UZcIBQ+GgF/sTqAsqjO5oWmzNdFbTbjxfwjG+siJtXCVkdsvHZoqM= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4343.eurprd08.prod.outlook.com (2603:10a6:20b:ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Mon, 17 May 2021 15:33:17 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4129.031; Mon, 17 May 2021 15:33:17 +0000 Subject: Re: [edk2-platforms][PATCH V2 04/11] Platform/Sgi: Add SMBIOS Type1 Table To: Pranav Madhu , devel@edk2.groups.io Cc: Ard Biesheuvel References: <20210516092917.21124-1-pranav.madhu@arm.com> <20210516092917.21124-5-pranav.madhu@arm.com> From: "Sami Mujawar" Message-ID: Date: Mon, 17 May 2021 16:33:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210516092917.21124-5-pranav.madhu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LNXP123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::20) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LNXP123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.32 via Frontend Transport; Mon, 17 May 2021 15:33:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9dde987c-722a-4ab8-24f7-08d91949239a X-MS-TrafficTypeDiagnostic: AM6PR08MB4343:|PR2PR08MB4652: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4502;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iM2H4Z99qKMpt7A8uyVXRYaikSm2AhB3BBRKbmCb+ClBmHvxMQzljUyFZJNBisIK6tJj7nCjrCHuFlYyzGiVCEE9OY9MD3Vz86GUjoFdZ9ZiL+dusQIe0oziQoj0dMI5veaAo2kEMPlesjXM8j52BiDs5OnzhV61z3paJ2pUWFRK5d4kn4CWS/7VfBSWpW9FBlJVRtSPu3Gcke7vWBoywiqrk+5p+6Q87eNHB58Dl877TD+IksWiX4To8EFVK8EVverRtHg6XgMxGwNBaRDP+6aVOqh8OcbU72GxBmILs2Q+pr09hOvP2ht2G1iDVXUo3yZEyqXlGWr5V/AQXJ9bTIx6jm+HpOHc2Am8jinG+/GFtgxYjzh/cCLNn+mczDdXsrIHbn6eA2Ze4nKKIfuKEv3zX1UsOqshE5if1AOR5BpMtz2rW7hDudwza6DPnIThLhB7FfaUco9bgkOUftZ+slaR+YJEn9NOxBIoBBTv4ATMwmS8GHCU+sEQFbf2w00uDnRRFjHVlLhb1CU5kh8ihXP22L268BCtdEynlANogt20pxUx81avUJZcUgh7y+4xE4z8BwI3JfO8egsIQAiBWsu34HX9p+WRgwkh2RhtMO088gLYAdJzeOCQ2AEZ9Eo2ea88cp8L36/UAzPXEypq/nwEje67x8+JuA3IIbNwu2cpxT5KaIK3TSArC0EkJ36sGuMFu17ZoI2l91WFiVIbIEAI5+EA6VWR3K7yfHzJmtM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(366004)(346002)(39850400004)(396003)(186003)(19627235002)(16526019)(36756003)(316002)(83380400001)(52116002)(26005)(38100700002)(38350700002)(6486002)(16576012)(44832011)(66556008)(2906002)(53546011)(31696002)(4326008)(86362001)(8936002)(8676002)(956004)(2616005)(5660300002)(66946007)(66476007)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NGQ0MHlaenBqUk9razZnR2lkcGozSlJ0YzhlWmxBZjl0S2tkYWVaNGQzR1Fp?= =?utf-8?B?OXFjelpoTm1NTW1HaGZwbXhNS0xoK0hLdGRUNHdLWTFyTmFFNjJJT25qN0VX?= =?utf-8?B?YksrZ1RRUko3djUyZWlpeUJaWjhvRFUzU0kvQmZuR1p0cWQ2dDZteE54TElJ?= =?utf-8?B?UjhxNHVYVWw0SFptdjh4MlZ5OU9NS2YvZHJ1bGpmSDk5bWpFWjI3TDVscVZN?= =?utf-8?B?T1p0ejVocUI2VEQ0bDYwSlJXUEVEN08ySmlzdDJyMklpaGJ3WGJtcDZubXly?= =?utf-8?B?UnVUQ3MyT0Y3dUcrVy9NZUx5MktyR2dPZDhrTzZDdDRlMTZzM3dXR0JaTFB6?= =?utf-8?B?YU5hL1NHdU1MazQzS093TVZuYlhMdEp4M3ErWVN5TGY4SmVxWDlwN2ozV2ZZ?= =?utf-8?B?cjBOYzVkWklCOUsrYUx1VzIrU3YzUDlTTzh3QzNCMmgwTHA0VEh2L2JNc3BF?= =?utf-8?B?Z2I2STVpWVpBNDkvM01IRzNua1lpNWhJUnFwc21OOVdIb1ZpT2hsT092ZlY5?= =?utf-8?B?TzUveW00Y01KZmhlMzdUQzV6dkdyMEo1WjduazZjSTdRSzc5aUJDVEVKODI3?= =?utf-8?B?NkhJUWZjYk00Z21iVXRybDhibmxLdkV3SFV0bk5KQlVQVTQ3UWlWbk0wQUJs?= =?utf-8?B?T0sycUhhNE1kK3Iyb29XZllBM2xrdHFValVWRTBIRkZ2RGZPNmIrbzhVT2U2?= =?utf-8?B?ZEhQUXVRVXM0TnBORW5TQWFjbzRrVVBmNzdaRHlwd1dPaDRwaGhvdmlyWFBt?= =?utf-8?B?VDZ1YlVaS25VSEI2UXhCVEZIZ3JRMi9CZjBRWHNacUQxdWphWFV2aXcyMi9n?= =?utf-8?B?OGpRUHlObFJ4czQ3UDg0dmtHaUk4K2N6dHUwTnptcEprR210L1NpeVMzY0tC?= =?utf-8?B?emFkUnRoOWgvL3NyTTRiMlVUckdRR0tydjh1eDYwWjJOenJMRlFlTjEyRHBM?= =?utf-8?B?RXF4MHFiMTdlVU00bU9vRXYxR2tobG1GNjBqdThBYU44NHNIZG1VR1kzNHR5?= =?utf-8?B?UFBDN3RXN3VLaHRVb0JyalhCeUJra2RzN3FNRThJRXdGd1U5MTMzcWJkUlRW?= =?utf-8?B?VTFpUVpoT0R1dWZmYmtiWk93WnlLdXZpNUtRSFkwNmFNZ3BMSFdndExYUG9k?= =?utf-8?B?Yk5oRnMrZmlCcUVPQkMyNXR1YXd2TzJkV1hVREtiYjUrTjF2SEJCRGZBdWh0?= =?utf-8?B?KytRaTR6REMzSEt5V0xheXNMY1ErYU4vWG50OWNkWnJPMzNMdVdTR2p1SmVR?= =?utf-8?B?RFpyQkJoWHUvZDFhejgwdDJiZDhrRGVZMVZSRjhmQzd5NkloeDBta3l3QzVN?= =?utf-8?B?a3lRSjhOZUJCUjZLK1hDMUNtczB3OUZiMW5ycFFCa25STEVzSjVsQ1BvNHl5?= =?utf-8?B?Q0F3akd4di8yQWVPS0RucGd1Tll4MlZpYkN6MWY1T2NCendXVExtMGExVTIy?= =?utf-8?B?SG9ZSjVjNjVydGQwNE42aFNOMVdjMTB1cVlPN3NyNGNVQmovVlFqUVBUbFIv?= =?utf-8?B?SEtxR2tpckJHWG9RKzM3TUVtY2pvdi9tTE8ydjZyN2w0L1JXYkdONjJXUnY0?= =?utf-8?B?d3VydHdCdVM5NkV1bUs3U0ZVMnJ4UjErbi9sMGJJZnBiUHllU25EU1lvT2VX?= =?utf-8?B?bksyNDlTSThuRzJjZndFS2REYXlodVlhOHBjV0tUNW9PMjR2M3lpYjlkU1Bt?= =?utf-8?B?allGQVkyNjBlbTdEMjY0aWR1NEgzUmJlaGpBNy94N0tENUZRcDcyL3VyZGVr?= =?utf-8?Q?Payj7aMjpUtRP3VPYexOyIYe+nNCl3SFQXevk20?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4343 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 35d227b4-9a85-4884-2b89-08d91949181e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c9qWIN5nrOZkr3j8hGq+/3N47Duv36hHwmr4ogImta2iD4LLFbhbR2M8WWEGr2eUVIPhN67oPVQZFKeKb0/YpMvFIaQLzUI6UgVEI1uWiLC48o2z79vSwXc7mDtax9EOWoLMA34JjTEmiE29chRxASVyHoi+a+BMFhFBu+WXfGyrHhCOBa30kB8M/TJGnSlfPs2PEgVlbFSzEbKjraX2sGROCnf8sOTkddRCyz2cmUMQjq1+lDFQt88Jjv/+WE1NNNsk9T5xu49ig9cLTlNduRDL68R83+1BSIOk0UL+4nbvrovxpXbyqYu/NAsgrm+NG3PQdYm3xhkhw0PRN3EDWHFk0lTAm9FngRPDbE/mtnqhLbfeJ7Q8Yjx6hjE4fll37FdPCxF83m/4c3q4M+B6mew+DFrLw14f1FqBP2PeybWCAGtFcpwTQMqCWItpY546Msrdsuu/kc9Z/FAwq7QiydfUriLajWSu+vCNqQBhVOOjYx3t8lNqLiCXNyTIIJVSgTXK/rwLbnUS4HpdWjMRMsSuweDhfsQKlJo2/A721YFS43j0bRUHWdZz5Hul0PPOsUdLvfqodOpk++Bn/GXZIPanJpfbL+AvnOap21eCrax1vTGlzvuGZUs6LqUxHu1Dbn5NzfvE+3x5pW707nFjglPbmkKVhQyDeRrIafXuzv4azbdJE2m5BnQXJ8QrAGrT X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(346002)(39850400004)(376002)(396003)(36840700001)(46966006)(47076005)(53546011)(26005)(2616005)(478600001)(19627235002)(2906002)(16576012)(316002)(86362001)(8676002)(4326008)(81166007)(36860700001)(31696002)(82740400003)(44832011)(36756003)(356005)(16526019)(186003)(70206006)(70586007)(5660300002)(31686004)(6486002)(82310400003)(8936002)(336012)(83380400001)(107886003)(956004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2021 15:33:37.0177 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dde987c-722a-4ab8-24f7-08d91949239a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4652 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Pranav, Please find my comments inline marked [SAMI]. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: > Add the SMBIOS type 1 table (System Information) that includes > information about manufacturer, product name, version, serial number and > other information related to the system identification. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf = | 1 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h = | 6 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c = | 1 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c = | 132 ++++++++++++++++++++ > 4 files changed, 140 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatform= Dxe.inf b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.i= nf > index 3568380f8404..f7beb1c66c80 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > @@ -16,6 +16,7 @@ > [Sources] > SmbiosPlatformDxe.c > Type0BiosInformation.c > + Type1SystemInformation.c > > [Packages] > ArmPkg/ArmPkg.dec > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatform= Dxe.h b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > index 091e0ec8314e..d7b3aadba948 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > @@ -17,4 +17,10 @@ InstallBiosInformation ( > IN EFI_SMBIOS_PROTOCOL *Smbios > ); > > +EFI_STATUS > +EFIAPI > +InstallSystemInformation ( > + IN EFI_SMBIOS_PROTOCOL *Smbios > + ); > + > #endif // SMBIOS_PLATFORM_DXE_H_ > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatform= Dxe.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index eb3ba45ca654..7b478063e223 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -27,6 +27,7 @@ typedef EFI_STATUS (*ARM_RD_SMBIOS_TABLE_INSTALL_FPTR)(= EFI_SMBIOS_PROTOCOL *); > STATIC > ARM_RD_SMBIOS_TABLE_INSTALL_FPTR mSmbiosTableList[] =3D { > &InstallBiosInformation, > + &InstallSystemInformation, > }; > > /** > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInf= ormation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInfor= mation.c > new file mode 100644 > index 000000000000..4559af81046b > --- /dev/null > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformatio= n.c > @@ -0,0 +1,132 @@ > +/** @file > + SMBIOS Type 1 (System information) table for ARM RD platforms. > + > + This file installs SMBIOS Type 1 (System information) table for Arm's > + Reference Design platforms. Type 1 table defines attributes of the > + overall system such as manufacturer, product name, UUID etc. > + > + Copyright (c) 2021, ARM Limited. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Specification Reference: > + - SMBIOS Reference Specification 3.4.0, Chapter 7.2 > +**/ > + > +#include > +#include > +#include > +#include > + > +#include "SgiPlatform.h" > + > +#define PRODUCT_NAME_BASE 6 /* Product name base from TYPE1_STRINGS = */ > +#define TYPE1_STRINGS \ > + "ARM LTD\0" /* Manufacturer */ \ > + "Version not set\0" /* Version */ \ > + "Serial not set\0" /* Serial number */ \ > + "Not Applicable\0" /* SKU */ \ > + "Not Applicable\0" /* Family */ \ > + "SGI575\0" /* Product Names */ \ > + "RdN1Edge\0" \ > + "RdN1EdgeX2\0" \ > + "RdE1Edge\0" \ > + "RdV1\0" \ > + "RdV1Mc\0" \ > + "RdN2\0" > + > +/* SMBIOS Type1 structure */ > +#pragma pack(1) > +struct ArmRdSmbiosType1 { > + SMBIOS_TABLE_TYPE1 Base; > + UINT8 Strings[sizeof (TYPE1_STRINGS)]; [SAMI] CHAR8 ? > +} ARM_TYPE1; > +#pragma pack() > + > +STATIC GUID mSmbiosUid[] =3D { > + /* Sgi575 */ > + {0xdd7cad0a, 0x227c, 0x4ed4, {0x9f, 0x42, 0xa9, 0x8b, 0xd6, 0xa2, 0x42= , 0x6c}}, > + /* Rd-N1-Edge */ > + {0x80984efe, 0x404a, 0x43e0, {0xad, 0xa4, 0x63, 0xa0, 0xe0, 0xc4, 0x5e= , 0x60}}, > + /* Rd-N1-Edge-X2 */ > + {0x2cc4f916, 0x267a, 0x4251, {0x95, 0x6e, 0xf0, 0x49, 0x82, 0xbe, 0x94= , 0x58}}, > + /* Rd-E1-Edge */ > + {0x567f35c4, 0x104f, 0x447b, {0xa0, 0x94, 0x89, 0x2f, 0xbd, 0xb6, 0x5a= , 0x55}}, > + /* Rd-V1 */ > + {0xc481f0b1, 0x237c, 0x42d7, {0x98, 0xb2, 0xb4, 0xb4, 0x8d, 0xb5, 0x4f= , 0x50}}, > + /* Rd-V1Mc */ > + {0x1f3a0806, 0x18b5, 0x4eca, {0xad, 0xcd, 0xba, 0x9b, 0x07, 0xb1, 0x0a= , 0xcf}}, > + /* Rd-N2 */ > + {0xf2cded73, 0x37f9, 0x4ec9, {0xd9, 0xf9, 0x89, 0x9b, 0x74, 0x91, 0x20= , 0x49}} > +}; > + > +/* System information */ > +static struct ArmRdSmbiosType1 mArmRdSmbiosType1 =3D { [SAMI] STATIC in capital letters? > + { > + { > + // SMBIOS header > + EFI_SMBIOS_TYPE_SYSTEM_INFORMATION, // Type 1 > + sizeof (SMBIOS_TABLE_TYPE1), // Length > + SMBIOS_HANDLE_PI_RESERVED, // Assign an unused handle num= ber > + }, > + 1, // Manufacturer > + PRODUCT_NAME_BASE, // Product Name, update dynamically > + 2, // Version > + 3, // Serial > + {0}, // UUID, Update dymanically > + 1, // Wakeup type other > + 4, // SKU > + 5, // Family > + }, > + // Text strings (unformatted) > + TYPE1_STRINGS > +}; > + > +/** > + Install SMBIOS System information Table. > + > + Install the SMBIOS system information (type 1) table for Arm's referen= ce > + design platforms. > + > + @param[in] Smbios SMBIOS protocol. > + > + @retval EFI_SUCCESS Record was added. > + @retval EFI_NOT_FOUND Unknown product id. > + @retval EFI_OUT_OF_RESOURCES Record was not added. > + @retval EFI_ALREADY_STARTED The SmbiosHandle passed in is already in= use. > +**/ > +EFI_STATUS > +InstallSystemInformation ( > + IN EFI_SMBIOS_PROTOCOL *Smbios > + ) > +{ > + EFI_STATUS Status; > + EFI_SMBIOS_HANDLE SmbiosHandle; > + > + SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER *)&mArmRdSmbiosType1)->Hand= le; > + > + /* Choose the product name from TYPE1_STRINGS based on the product ID = */ > + if (SgiGetProductId () !=3D UnknownId) { > + mArmRdSmbiosType1.Base.ProductName =3D > + PRODUCT_NAME_BASE + (SgiGetProductId () - 1); > + CopyGuid (&mArmRdSmbiosType1.Base.Uuid, > + &mSmbiosUid[SgiGetProductId () - 1]); [SAMI] Apart from the horizontal spacing issues, I think minor optimisation can be achieved by calling SgiGetProductId () once and the return value stored in a local variable for subsequent use. [/SAMI] > + } else { > + return EFI_NOT_FOUND; > + } > + > + /* Install type 1 table */ > + Status =3D Smbios->Add ( > + Smbios, > + NULL, > + &SmbiosHandle, > + (EFI_SMBIOS_TABLE_HEADER *)&mArmRdSmbiosType1 > + ); > + if (Status !=3D EFI_SUCCESS) { [SAMI] if (EFI_ERROR (Status)) ? Same comment for other patches in this seires. > + DEBUG (( > + DEBUG_ERROR, > + "SMBIOS: Failed to install Type1 SMBIOS table.\n" > + )); > + } > + > + return Status; > +} IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.