From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.9794.1586528450482097813
 for <devel@edk2.groups.io>;
 Fri, 10 Apr 2020 07:20:50 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F35730E;
	Fri, 10 Apr 2020 07:20:49 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D2EE3F68F;
	Fri, 10 Apr 2020 07:20:48 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/DxeCore: clean up image loading functions
To: "Gao, Liming" <liming.gao@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>,
 "Bi, Dandan" <dandan.bi@intel.com>
References: <20200409160948.23427-1-ard.biesheuvel@arm.com>
 <dcd6cb902b624a36b77df07400bd9bf4@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <a964000b-019e-0066-c936-b73e4596690f@arm.com>
Date: Fri, 10 Apr 2020 16:20:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <dcd6cb902b624a36b77df07400bd9bf4@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/10/20 3:59 PM, Gao, Liming wrote:
> Ard:
>    What's purpose for this change? Only code clean up? Is there any other benefit?
> 

Just code cleanup.

>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
>> Sent: Friday, April 10, 2020 12:10 AM
>> To: devel@edk2.groups.io
>> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Subject: [edk2-devel] [PATCH 0/2] MdeModulePkg/DxeCore: clean up image loading functions
>>
>> A pair of cleanup patches for the LoadImage/StartImage implementations
>> in DxeCore.
>>
>> https://github.com/ardbiesheuvel/edk2/pull/new/dxecore-loadimage-cleanup
>>
>> Ard Biesheuvel (2):
>>    MdeModulePkg/DxeCore/Image: make local functions STATIC
>>    MdeModulePkg/DxeCore/Image: remove unused function arguments
>>
>>   MdeModulePkg/Core/Dxe/Image/Image.c | 91 ++++----------------
>>   1 file changed, 17 insertions(+), 74 deletions(-)
>>
>> --
>> 2.17.1
>>
>>
>> 
>