Re: [platforms: PATCH] SolidRun/Armada80x0McBin: Introduce SD/MMC ACPI description

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

Hello Marcin,

On 11/14/20 10:21 AM, Marcin Wojtas wrote:
> This patch adds a new description of the board's SD/MMC
> interfaces in DSDT table that can work with the newly
> introduced support in Linux.
> Remaining Armada7k8k / CN913x platforms will follow
> after this binding is accepted.
> 
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>   Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 60 ++++++++++++++++++++
>   1 file changed, 60 insertions(+)
> 
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> index 7e9e361988..5f910fa814 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> @@ -86,6 +86,66 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
>               })
>           }
>   
> +        Device (MMC0)
> +        {
> +            Name (_HID, "MRVL0002")     // _HID: Hardware ID
> +            Name (_UID, 0x00)           // _UID: Unique ID
> +            Name (_CCA, 0x01)           // _CCA: Cache Coherency Attribute
> +
> +            Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
> +            {
> +                Memory32Fixed (ReadWrite,
> +                    0xF06E0000,         // Address Base (MMIO)
> +                    0x00000300,         // Address Length
> +                    )
> +                Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
> +                {
> +                  48
> +                }
> +            })
> +            Name (_DSD, Package () {
> +                ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> +                Package () {
> +                      Package () { "clock-frequency", 400000000 },
> +                      Package () { "bus-width", 8 },
> +                      Package () { "marvell,xenon-phy-slow-mode", 0x1 },
> +                      Package () { "no-1-8-v", 0x1 },
> +                      Package () { "no-sd", 0x1 },
> +                      Package () { "no-sdio", 0x1  },
> +                      Package () { "non-removable", 0x1  },
> +                      Package () { "compatible", "marvell,armada-ap806-sdhci" },

Please use either a dedicated ACPI _HID, or use PRP0001+compatible to 
match the device (and the former is strongly preferred).


> +                }
> +            })
> +        }
> +
> +        Device (MMC1)
> +        {
> +            Name (_HID, "MRVL0002")     // _HID: Hardware ID
> +            Name (_UID, 0x01)           // _UID: Unique ID
> +            Name (_CCA, 0x01)           // _CCA: Cache Coherency Attribute
> +
> +            Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
> +            {
> +                Memory32Fixed (ReadWrite,
> +                    0xF2780000,         // Address Base (MMIO)
> +                    0x00000300,         // Address Length
> +                    )
> +                Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
> +                {
> +                  CP_GIC_SPI_CP0_SDMMC
> +                }
> +            })
> +            Name (_DSD, Package () {
> +                ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> +                Package () {
> +                      Package () { "clock-frequency", 400000000 },
> +                      Package () { "bus-width", 4 },
> +                      Package () { "broken-cd", 0x1 },
> +                      Package () { "no-1-8-v", 0x1 },
> +                }
> +            })
> +        }
> +
>           Device (XHC0)
>           {
>               Name (_HID, "PNP0D10")      // _HID: Hardware ID
>