From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.5852.1605359951915450367 for ; Sat, 14 Nov 2020 05:19:12 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B04EB1042; Sat, 14 Nov 2020 05:19:10 -0800 (PST) Received: from [192.168.1.81] (unknown [10.37.8.18]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B4BFA3F6CF; Sat, 14 Nov 2020 05:19:09 -0800 (PST) Subject: Re: [platforms: PATCH] SolidRun/Armada80x0McBin: Introduce SD/MMC ACPI description To: Marcin Wojtas , devel@edk2.groups.io Cc: leif@nuviainc.com, jsd@semihalf.com References: <20201114092104.19516-1-mw@semihalf.com> From: "Ard Biesheuvel" Message-ID: Date: Sat, 14 Nov 2020 14:19:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201114092104.19516-1-mw@semihalf.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hello Marcin, On 11/14/20 10:21 AM, Marcin Wojtas wrote: > This patch adds a new description of the board's SD/MMC > interfaces in DSDT table that can work with the newly > introduced support in Linux. > Remaining Armada7k8k / CN913x platforms will follow > after this binding is accepted. > > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 60 ++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > index 7e9e361988..5f910fa814 100644 > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > @@ -86,6 +86,66 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3) > }) > } > > + Device (MMC0) > + { > + Name (_HID, "MRVL0002") // _HID: Hardware ID > + Name (_UID, 0x00) // _UID: Unique ID > + Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute > + > + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > + { > + Memory32Fixed (ReadWrite, > + 0xF06E0000, // Address Base (MMIO) > + 0x00000300, // Address Length > + ) > + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, ) > + { > + 48 > + } > + }) > + Name (_DSD, Package () { > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > + Package () { > + Package () { "clock-frequency", 400000000 }, > + Package () { "bus-width", 8 }, > + Package () { "marvell,xenon-phy-slow-mode", 0x1 }, > + Package () { "no-1-8-v", 0x1 }, > + Package () { "no-sd", 0x1 }, > + Package () { "no-sdio", 0x1 }, > + Package () { "non-removable", 0x1 }, > + Package () { "compatible", "marvell,armada-ap806-sdhci" }, Please use either a dedicated ACPI _HID, or use PRP0001+compatible to match the device (and the former is strongly preferred). > + } > + }) > + } > + > + Device (MMC1) > + { > + Name (_HID, "MRVL0002") // _HID: Hardware ID > + Name (_UID, 0x01) // _UID: Unique ID > + Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute > + > + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > + { > + Memory32Fixed (ReadWrite, > + 0xF2780000, // Address Base (MMIO) > + 0x00000300, // Address Length > + ) > + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, ) > + { > + CP_GIC_SPI_CP0_SDMMC > + } > + }) > + Name (_DSD, Package () { > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > + Package () { > + Package () { "clock-frequency", 400000000 }, > + Package () { "bus-width", 4 }, > + Package () { "broken-cd", 0x1 }, > + Package () { "no-1-8-v", 0x1 }, > + } > + }) > + } > + > Device (XHC0) > { > Name (_HID, "PNP0D10") // _HID: Hardware ID >