Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers.

["Pete Batard" <pete@akeo.ie>]

Hi Philippe,

For the record these fixes were validated by Jared by booting NetBSD as 
per [1]:

[     1.000007] sdhc0 at acpi0 (SDC1, BCM2847-0): mem 
0xfe300000-0xfe3000ff irq 158

We'll have a few more of these coming up in [2], which we need to sort 
out before we send a patch, but at least for the SDHC, we're pretty 
confident the proposed changes are indeed correct.

It's more for the FIXMEs in [2] that we may require help from someone 
with access to the datasheet. Of course, double checking what we already 
have won't hurt either.

Regards,

/Pete

[1] https://dmesgd.nycbug.org/index.cgi?do=view&id=5273
[2] 
https://github.com/pftf/edk2-platforms/commit/e6df781e25fc3dc51e83393c127410a1e4fc4345

On 2019-12-31 14:30, Philippe Mathieu-Daudé wrote:
> Cc'ing Samer because he has access to the datasheet, and I wonder if 
> Linux is right.
> 
> Samer, do you mind to confirm this fix?
> 
> Thanks,
> 
> Phil.
> 
> On 12/31/19 11:39 AM, Pete Batard wrote:
>> Many thanks for fixing these.
>>
>> Reviewed-by: Pete Batard <pete@akeo.ie>
>>
>> On 2019-12-30 15:07, Jared McNeill wrote:
>>> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126
>>> and the Broadcom SDHost uses GIC SPI 120.
>>>
>>> Signed-off-by: Jared McNeill <jmcneill@invisible.ca>
>>> ---
>>>   Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl 
>>> b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>>> index 57ee411a61..56d15c3927 100644
>>> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>>> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>>> @@ -33,7 +33,7 @@ Device (SDC1)
>>>       Name (RBUF, ResourceTemplate ()
>>>       {
>>>         MEMORY32FIXED (ReadWrite, 0xFE300000, 0x100,)
>>> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
>>> 0x5E }
>>> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
>>> 0x9E }
>>>       })
>>>       Return (RBUF)
>>>     }
>>> @@ -76,7 +76,7 @@ Device (SDC2)
>>>       Name (RBUF, ResourceTemplate ()
>>>       {
>>>         MEMORY32FIXED (ReadWrite, 0xFE202000, 0x100,)
>>> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
>>> 0x58 }
>>> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
>>> 0x98 }
>>>       })
>>>       Return (RBUF)
>>>     }
>>>
>>
>>
>> 
>>
>