From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web09.3858.1577803625726077681 for ; Tue, 31 Dec 2019 06:47:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=ZW8n2lGy; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.66, mailfrom: pete@akeo.ie) Received: by mail-wr1-f66.google.com with SMTP id d16so35334928wre.10 for ; Tue, 31 Dec 2019 06:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=3+xJroUmRo7CmWpdBL9hBt+2hTcgiytVWolVSqSNtMs=; b=ZW8n2lGyNmHvwSTiugAfRwrHssppx1+fWByYdNnqZWyLCzn77kQh7+1+EUJpyguIrN z+U2WcLwtsBWHg5eNaN3nUu6eYXn0zEmhWGnfXszT7ZahskOnSD4XxW8jqXedEYJHtnS E/btLCI2kwJp3vBaTmlNeSlgQHSd+Brox/o4jNlxTKOaerMtizTPOc5pk6RxvXRnERX2 NxNumb+p1ZlYSIdmLVphvQzcUKqgsLg+ezu1J0CeCZlIkFE6+08wNXYJcDI09EEb+oXu ZNvv/ZV+jNpit5TWWF3jlzBZ5hXq7I4WR5HaJR/EDtCbe5owOBRPGbdoQnsb1zfjUOfc mSAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3+xJroUmRo7CmWpdBL9hBt+2hTcgiytVWolVSqSNtMs=; b=HiEExf+iA+/j4ivWJoIdLSnid8aNk5DCFZqllWKMZnNpY/YFUCyxzQwibVK+kp2roP IJjG/hOhRVU9C2tcrk/CTHigzkndqMLVDqC2L25nuJ6hk3cB1xeI8ztwGxegGSwJOUD7 NIp6TBtcYRZZ4x/zaRgKNXX3KVneA0W5LXD0frWRHp5iB6iQ+W5XpeRiLwzEtAe74vuk c8kcu4C5H0NogmNyBtuR2xW35zu2UtK39Eajl0G3rW9geFzGW6LSyDxp0PrXmaRa+jhr guDsbel9qQyEoXHB79QHIxxE1AACRN/iiOEZNTeOnQd96Y4dla+N6ipy2YaGkbZ0CmGJ k4eQ== X-Gm-Message-State: APjAAAVDB3kR5sc+0GY5i13zhibnp4ZYJHN82xk6f8brgBcRvnsPhPyt MLrSu4c0Ol2j6vaMdn5YExal1w== X-Google-Smtp-Source: APXvYqxrfFFCliS/3QlFpArL1jnLJTcfO3FqlRophJP2CUTD9SXgJ+QAXgJ1G46lQakG939MYBPuCg== X-Received: by 2002:a5d:6211:: with SMTP id y17mr72224208wru.344.1577803624150; Tue, 31 Dec 2019 06:47:04 -0800 (PST) Return-Path: Received: from [192.168.0.11] (gge44-1-78-198-200-53.fbx.proxad.net. [78.198.200.53]) by smtp.googlemail.com with ESMTPSA id x7sm48801175wrq.41.2019.12.31.06.47.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2019 06:47:03 -0800 (PST) Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers. To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io, jmcneill@invisible.ca, Samer El-Haj-Mahmoud , Ard Biesheuvel References: <39052ebe-f126-6c84-5d95-8c91297216bd@akeo.ie> <53e1b682-4d9a-2ba2-6f17-89f44afc32a6@redhat.com> From: "Pete Batard" Message-ID: Date: Tue, 31 Dec 2019 15:47:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <53e1b682-4d9a-2ba2-6f17-89f44afc32a6@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Philippe, For the record these fixes were validated by Jared by booting NetBSD as per [1]: [ 1.000007] sdhc0 at acpi0 (SDC1, BCM2847-0): mem 0xfe300000-0xfe3000ff irq 158 We'll have a few more of these coming up in [2], which we need to sort out before we send a patch, but at least for the SDHC, we're pretty confident the proposed changes are indeed correct. It's more for the FIXMEs in [2] that we may require help from someone with access to the datasheet. Of course, double checking what we already have won't hurt either. Regards, /Pete [1] https://dmesgd.nycbug.org/index.cgi?do=view&id=5273 [2] https://github.com/pftf/edk2-platforms/commit/e6df781e25fc3dc51e83393c127410a1e4fc4345 On 2019-12-31 14:30, Philippe Mathieu-Daudé wrote: > Cc'ing Samer because he has access to the datasheet, and I wonder if > Linux is right. > > Samer, do you mind to confirm this fix? > > Thanks, > > Phil. > > On 12/31/19 11:39 AM, Pete Batard wrote: >> Many thanks for fixing these. >> >> Reviewed-by: Pete Batard >> >> On 2019-12-30 15:07, Jared McNeill wrote: >>> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126 >>> and the Broadcom SDHost uses GIC SPI 120. >>> >>> Signed-off-by: Jared McNeill >>> --- >>>   Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >>> b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >>> index 57ee411a61..56d15c3927 100644 >>> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >>> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >>> @@ -33,7 +33,7 @@ Device (SDC1) >>>       Name (RBUF, ResourceTemplate () >>>       { >>>         MEMORY32FIXED (ReadWrite, 0xFE300000, 0x100,) >>> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { >>> 0x5E } >>> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { >>> 0x9E } >>>       }) >>>       Return (RBUF) >>>     } >>> @@ -76,7 +76,7 @@ Device (SDC2) >>>       Name (RBUF, ResourceTemplate () >>>       { >>>         MEMORY32FIXED (ReadWrite, 0xFE202000, 0x100,) >>> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { >>> 0x58 } >>> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { >>> 0x98 } >>>       }) >>>       Return (RBUF) >>>     } >>> >> >> >> >> >