From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.12890.1591273638105313742 for ; Thu, 04 Jun 2020 05:27:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=dFtNm9/v; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.66, mailfrom: pete@akeo.ie) Received: by mail-wm1-f66.google.com with SMTP id v19so5052921wmj.0 for ; Thu, 04 Jun 2020 05:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NJgbM3jelif+KmIVBC3wSiRJUI9S910RXZ2C8sSYmnM=; b=dFtNm9/vaLPFeRb/RzLpnlOwLL3WS5Uwb6HNW+KJnLhBB6zL81VDhufHjiYXAfwny4 eV4gc2OGclZ5c8UcywsKvo/OASzJQSdf3TIRO41hWY/y7W5JbVVcCBAVaaZWI3IIoLnx JPAyGjhnCikyLRBfeGjZ9eLXt3HekWysBKcSRN0KGg8KPBAv0p9l0k0pVN0tXQjAgP4r edkfOf541HdXMHKUB7DyYusJVa2l6IzfKiyCaqE9p/glkGvVnuigH9Tz9Ew7fc9Kdj0j jqpcaMmr/ec7SPyFEoYcfW1hYcaz8yTWeJxUZAgzU9TMYKopyisEpA2yki8tR3+8rgDc wdAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NJgbM3jelif+KmIVBC3wSiRJUI9S910RXZ2C8sSYmnM=; b=C3yyQJo9jlaIW+zIH/gpsJYsDDBsKFvEbMuTsTC5IpH1ON/Z5bkk2FTSeILySosbI2 6Z1u/7wCsmbKwRk0TfUuraiTv4VyNBorzgmzn1Wu731axLgUvG4NaVdY3YbuQ0KB3K98 uRPbOXZsM0I0HGf3Zk1BHhjFqZYJvjTm7x+t6ICbzPzVV8Bq0M4onRU9JI9pXOsvoD03 kAl4IaFxGiSouq7jV6rVbQ2dM+i8MgSUSq2THCZ8a79nZbM83Ab+q9sdI7mZiH3IKXoB NSeVkU7lMH97TY2mNjzp120IgRQl/ebi1Abd2x9PPDejaE0/j2aMAV9W/U0X8LqVPS5h /EFA== X-Gm-Message-State: AOAM531//4Q9JvM/NcRhbfo6VeudBrjifBnid1K/odgeNKq1QfU9Fu7H mC8rkb+1Mj0gTXu/+VJoN5+J3Q== X-Google-Smtp-Source: ABdhPJxvnEa3HUzV/8p4f9TkUGmqJsUeTDBosRDi8mf0O+CBxNDCoDNW6s0fTwpXQqqUw6Beknhwkw== X-Received: by 2002:a1c:c916:: with SMTP id f22mr308208wmb.1.1591273636337; Thu, 04 Jun 2020 05:27:16 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.48.247]) by smtp.googlemail.com with ESMTPSA id d13sm6836200wmb.39.2020.06.04.05.27.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 05:27:15 -0700 (PDT) Subject: Re: [PATCH edk2-platforms 2/3] Platform/RaspberryPi: add UEFI Shell to boot manager menu To: Ard Biesheuvel , devel@edk2.groups.io Cc: Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud , Leif Lindholm , Jeremy Linton References: <20200604095007.45693-1-ard.biesheuvel@arm.com> <20200604095007.45693-3-ard.biesheuvel@arm.com> From: "Pete Batard" Message-ID: Date: Thu, 4 Jun 2020 13:27:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200604095007.45693-3-ard.biesheuvel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.06.04 10:50, Ard Biesheuvel wrote: > Take advantage of a recent change to the core EDK2 BDS code that > makes boot options with the LOAD_OPTION_ACTIVE flag cleared visible > in the boot manager menu, so that they can be selected manually > while never being considered for automatic booting (unless selected > specifically via BootNext) > > Signed-off-by: Ard Biesheuvel > --- > Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > index 996ba8f39938..2bd625ad7e7c 100644 > --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > @@ -460,7 +460,7 @@ PlatformRegisterOptionsAndKeys ( > RemoveStaleBootOptions (); > > > > ShellOption = PlatformRegisterFvBootOption (&gUefiShellFileGuid, > > - L"UEFI Shell", LOAD_OPTION_CATEGORY_APP); > > + L"UEFI Shell", 0); > > if (ShellOption != -1) { > > // > > // F1 boots Shell. > Reviewed-by: Pete Batard