public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master
Date: Tue, 3 Dec 2019 09:56:24 +0100	[thread overview]
Message-ID: <a9aac628-f16a-1cf4-2ccb-fbadb807d9fd@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9E25C97@ORSMSX113.amr.corp.intel.com>

On 12/02/19 20:55, Kinney, Michael D wrote:

> So my question still stands.  What notifications would
> you like to see if we have the use case of a single PR
> with multiple rounds of reviews and a transition from 
> a PR without the 'push' label to a PR with a 'push' label?

Thank you for explaining.

In this case, I think it would be helpful if, whenever another email
notification were sent out about a PR, the subject of that email
contained an auto-generated part that advertized the push label's
presence on the PR, at that time.

OTOH... It's also possible that I'm approaching this wrong. After all,
before we adopted github.com for pushing, a maintainer would just go
ahead and push post-review (with no *automatic* email notification about
the fact), and then we'd expect that maintainer to report back under the
patch review thread ("pushed as commit range ..."), and/or close the BZ
ticket with a similar comment. (And then there would be an
auto-generated bugzilla email about that.)

My point being, maybe I shouldn't even *read* these github.com
notifications at all. I'm not sure if they give me useful information.
(When the PR is ultimately merged, we *still* require the above kind of
closing comment in Bugzilla, from the maintainer -- thus the originally
needed information is still provided, just like before.)

It's just that, *if* I attempt to read the github.com emails, *then*
they confuse me (for example because they don't expose the push label).
If we consider this specific kind of PR that we have adopted for edk2 a
(practically) "maintainer-internal", mechanical, action, then I guess I
might as well want to unsubscribe from those notifications. After all
I'm still subscribed to BZ emails, and I'll see the resultant commit
range noted there (through the comment that the assignee adds manually,
when they close the BZ).

Is it possible for a tianocore group member to "unwatch" PRs?

Thanks!
Laszlo


  reply	other threads:[~2019-12-03  8:56 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  2:55 EDK II Maintainers - EDK II CI is now active on edk2/master Michael D Kinney
2019-11-12  8:56 ` [edk2-devel] " Laszlo Ersek
2019-11-12 19:50   ` Michael D Kinney
2019-11-12 19:52     ` Michael D Kinney
2019-11-13  7:56     ` Laszlo Ersek
2019-11-13  8:57 ` Laszlo Ersek
2019-11-13 16:23   ` Michael D Kinney
2019-11-13 17:03     ` Laszlo Ersek
2019-11-26  8:23 ` Laszlo Ersek
2019-11-27 19:03   ` Michael D Kinney
2019-11-28 12:00     ` Laszlo Ersek
2019-12-02 19:55       ` Michael D Kinney
2019-12-03  8:56         ` Laszlo Ersek [this message]
2019-12-03 17:07           ` Michael D Kinney
2019-12-03 20:39             ` Laszlo Ersek
2019-12-06 11:02 ` Laszlo Ersek
2019-12-06 11:07   ` Laszlo Ersek
2020-01-02 14:42 ` Philippe Mathieu-Daudé
2020-01-02 18:36   ` Michael D Kinney
2020-01-06 14:58     ` Philippe Mathieu-Daudé
2020-01-03 13:29   ` Laszlo Ersek
2020-01-06 17:29 ` Laszlo Ersek
2020-01-06 18:17   ` Michael D Kinney
2020-01-07  9:00     ` Laszlo Ersek
2020-01-09 21:30     ` Laszlo Ersek
2020-01-09 21:37       ` Michael D Kinney
2020-01-10 10:51         ` Laszlo Ersek
2020-03-08 11:12 ` Laszlo Ersek
  -- strict thread matches above, loose matches on Subject: below --
2020-03-08 19:21 Sean
2020-03-08 19:53 ` Michael D Kinney
2020-03-09 19:29   ` Laszlo Ersek
2020-03-09 19:32     ` Laszlo Ersek
2020-03-09 22:00       ` Michael D Kinney
2020-03-09 19:37     ` Laszlo Ersek
2020-03-09 20:06   ` Laszlo Ersek
2020-03-09 21:44     ` Michael D Kinney
2020-03-10  7:53       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9aac628-f16a-1cf4-2ccb-fbadb807d9fd@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox