[[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot

[[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot

[Samer El-Haj-Mahmoud]

Enable HTTP Boot (with and without TLS) on RPi3

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Pete Batard <pete@akeo.ie>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
---
 Platform/RaspberryPi/RPi3/RPi3.dsc | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 91d5738afbc6..960b1ac57ad3 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -25,12 +25,6 @@ [Defines]
   SKUID_IDENTIFIER               = DEFAULT
   FLASH_DEFINITION               = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
 
-  #
-  # Network definition
-  #
-  DEFINE NETWORK_TLS_ENABLE       = FALSE
-  DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
-
   #
   # Defines for default states.  These can be changed on the command line.
   # -D FLAG=VALUE
@@ -123,6 +117,7 @@ [LibraryClasses.common]
   IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
   BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
   OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
+  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
 
   #
   # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
@@ -329,6 +324,8 @@ [PcdsFixedAtBuild.common]
   gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04
 !endif
 
+  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
+
   gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x40000000
   gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0
   gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x1
-- 
2.17.1

Re: [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot

[Pete Batard]

On 2020.03.25 15:02, Samer El-Haj-Mahmoud wrote:
> Enable HTTP Boot (with and without TLS) on RPi3
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Pete Batard <pete@akeo.ie>
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 91d5738afbc6..960b1ac57ad3 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -25,12 +25,6 @@ [Defines]
>     SKUID_IDENTIFIER               = DEFAULT
>     FLASH_DEFINITION               = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
>   
> -  #
> -  # Network definition
> -  #
> -  DEFINE NETWORK_TLS_ENABLE       = FALSE
> -  DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> -
>     #
>     # Defines for default states.  These can be changed on the command line.
>     # -D FLAG=VALUE
> @@ -123,6 +117,7 @@ [LibraryClasses.common]
>     IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
>     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
>     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>   
>     #
>     # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
> @@ -329,6 +324,8 @@ [PcdsFixedAtBuild.common]
>     gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04
>   !endif
>   
> +  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> +
>     gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x40000000
>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0
>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x1
> 

Reviewed-by: Pete Batard <pete@akeo.ie>

Re: [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot

[Ard Biesheuvel]

On Wed, 8 Apr 2020 at 12:04, Pete Batard <pete@akeo.ie> wrote:
>
> On 2020.03.25 15:02, Samer El-Haj-Mahmoud wrote:
> > Enable HTTP Boot (with and without TLS) on RPi3
> >
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Pete Batard <pete@akeo.ie>
> > Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> > ---
> >   Platform/RaspberryPi/RPi3/RPi3.dsc | 9 +++------
> >   1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> > index 91d5738afbc6..960b1ac57ad3 100644
> > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> > @@ -25,12 +25,6 @@ [Defines]
> >     SKUID_IDENTIFIER               = DEFAULT
> >     FLASH_DEFINITION               = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
> >
> > -  #
> > -  # Network definition
> > -  #
> > -  DEFINE NETWORK_TLS_ENABLE       = FALSE
> > -  DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> > -
> >     #
> >     # Defines for default states.  These can be changed on the command line.
> >     # -D FLAG=VALUE
> > @@ -123,6 +117,7 @@ [LibraryClasses.common]
> >     IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> >     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> >     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> >
> >     #
> >     # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
> > @@ -329,6 +324,8 @@ [PcdsFixedAtBuild.common]
> >     gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04
> >   !endif
> >
> > +  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> > +
> >     gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x40000000
> >     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0
> >     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x1
> >
>
> Reviewed-by: Pete Batard <pete@akeo.ie>
>

Thanks

Pushed as b93aa851aab6..4a73a96931a5