public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ray.ni@intel.com, "Dong,
	Eric" <eric.dong@intel.com>
Cc: "Kumar, Chandana C" <chandana.c.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs.
Date: Fri, 24 Apr 2020 18:37:49 +0200	[thread overview]
Message-ID: <a9d0b474-e69b-697c-e566-d6742a7be707@redhat.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C5087DB@SHSMSX104.ccr.corp.intel.com>

On 04/22/20 13:47, Ni, Ray wrote:
> Eric,
> It's natural to use the volatile registers value derived from BSP in ApInitReconfig path.
> So I still prefer to use the code I suggested in the review comment to the v1 patch.
> 
> We can remove the below line that specially for ApInitReconfig path in MpInitLbInitialize().
> https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Library/MpInitLib/MpLib.c#L1783:
>       CopyMem (&CpuMpData->CpuData[Index].VolatileRegisters, &VolatileRegisters, sizeof (CPU_VOLATILE_REGISTERS));

Sorry I didn't mean to disagree or disregard this feedback.

Laszlo


  reply	other threads:[~2020-04-24 16:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  9:01 [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs Dong, Eric
2020-04-22  9:01 ` [PATCH v2 2/2] UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI Dong, Eric
2020-04-22 11:23   ` Ni, Ray
2020-04-24 16:39   ` [edk2-devel] " Laszlo Ersek
2020-04-22 11:47 ` [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs Ni, Ray
2020-04-24 16:37   ` Laszlo Ersek [this message]
2020-04-22 21:41 ` [edk2-devel] " Laszlo Ersek
2020-04-23  0:58   ` Dong, Eric
2020-04-24 16:37 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9d0b474-e69b-697c-e566-d6742a7be707@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox