public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Cc: Andrew Fish <afish@apple.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen
Date: Fri, 9 Aug 2019 01:29:17 +0200	[thread overview]
Message-ID: <a9fdb3bc-e41c-d830-c158-3493cc415c07@redhat.com> (raw)
In-Reply-To: <bacde6e4-e675-4fd0-be38-e081b1a236b2@redhat.com>

On 08/09/19 00:18, Laszlo Ersek wrote:
> On 08/08/19 17:38, Feng, Bob C wrote:
>> Hi Laszlo and Leif,
>>
>> Thanks for you detailed testing and comments.
>>
>> I'd like to explain the failure of the test 3#. I can reproduce the failure with your steps and I found this failure can also be reproduced without multiple process autogen patch set.  I debugged and found this failure is due to --hash build option. I double tested that if remove --hash build option, the test 3# can pass.  Would you please double verified test 3# without --hash?
>>
>> I think we can enter a new BZ for the --hash bug.
> 
> Confirmed -- with "--hash" removed from the build command line, the build is picked up fine after Ctrl-C. (And the firmware binary is sound.)
> 
> So, my ACK stands.
> 
> (
> 
> And now I remember that in my v3 testing, I also omitted "--hash": 
> 
>   http://mid.mail-archive.com/4ea3d3fa-2210-3642-2337-db525312d312@redhat.com
>   https://edk2.groups.io/g/devel/message/44246
> 
> At the bottom I stated that I didn't test "--hash".
> 
> )

... based on the above, I can even provide:

Tested-by: Laszlo Ersek <lersek@redhat.com>

for the series.

Thanks
Laszlo

  reply	other threads:[~2019-08-08 23:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07  4:25 [Patch 00/10 V8] Enable multiple process AutoGen Bob Feng
2019-08-07  4:25 ` [Patch 01/10 V8] BaseTools: Singleton the object to handle build conf file Bob Feng
2019-08-07  4:25 ` [Patch 02/10 V8] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions Bob Feng
2019-08-07  4:25 ` [Patch 03/10 V8] BaseTools: Add functions to get platform scope build options Bob Feng
2019-08-07  4:25 ` [Patch 04/10 V8] BaseTools: Decouple AutoGen Objects Bob Feng
2019-08-22  8:04   ` [edk2-devel] " Gary Lin
2019-08-22  8:15     ` Bob Feng
2019-08-22  8:26       ` Gary Lin
2019-08-07  4:25 ` [Patch 05/10 V8] BaseTools: Enable Multiple Process AutoGen Bob Feng
2019-09-24  1:18   ` [edk2-devel] " dann frazier
2019-09-24  2:25     ` Bob Feng
2019-09-24 12:49       ` dann frazier
2019-08-07  4:25 ` [Patch 06/10 V8] BaseTools: Add shared data for processes Bob Feng
2019-08-07  4:25 ` [Patch 07/10 V8] BaseTools: Add LogAgent to support multiple process Autogen Bob Feng
2019-08-07  4:25 ` [Patch 08/10 V8] BaseTools: Move BuildOption parser out of build.py Bob Feng
2019-08-07  4:25 ` [Patch 09/10 V8] BaseTools: Add the support for python 2 Bob Feng
2019-08-07  4:25 ` [Patch 10/10 V8] BaseTools: Enable block queue log agent Bob Feng
2019-08-08 13:08 ` [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen Laszlo Ersek
2019-08-08 13:45   ` Leif Lindholm
2019-08-08 15:38     ` Bob Feng
2019-08-08 22:18       ` Laszlo Ersek
2019-08-08 23:29         ` Laszlo Ersek [this message]
2019-08-09  0:49           ` Liming Gao
2019-08-09  1:37             ` Bob Feng
2019-08-09 12:54               ` Laszlo Ersek
2019-08-09 13:28                 ` Leif Lindholm
2019-08-09 14:54                   ` Liming Gao
2019-08-09 15:31                     ` Leif Lindholm
2019-08-09 15:09                   ` Bob Feng
2019-08-09 14:42                 ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9fdb3bc-e41c-d830-c158-3493cc415c07@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox