From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.46]) by mx.groups.io with SMTP id smtpd.web12.6935.1622722613341646076 for ; Thu, 03 Jun 2021 05:16:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=JTiTl/nN; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.46, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E+UwWGS2QuFIiq1xLzLAfPHtJdcnRzx8ATiBR6LxYU4emDj/2g5Edk8JCuFrX/xRIEpxWEeHDBcyvx0fIvgqkp9A6Gt0s/AG2GHRad0W8V7IS5sbBfHPOdmjABSlGF6fne/iC3f3DMChSJDSxpElfW/gtNgSWttcvMMedeFKULdnGx4ASEZirWuQ59YsChgZYrNt63W6pE6KP6BQsMcyvZUK9R+HRpwDK798VPtFwGQqtZwYgYMU7u87mE8ASh9QibooAg58RYRSJarpCOZbqXFqPa5uceL8WFOCqzxSAnRTwHgKUZ5h14c1TxwYPOqn2l0mqZy5LsAridHTcLDmzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gcAlYM3QEaI2d/Fft46Yr8UgLzYMKV6al37V7lAZeKg=; b=mueq+zJLojCj4gUt3LZ+V9OA7Irms/xLcNajrMvpvq85ZpIpPF9Me5VLKsaxK+bklmkMF3THPEiIxYkHe99Mrfhb1ihV+qh8r0p+6i5b8LniMyB+Zhyu+ppVREle8i/PVntslTiVl78mmZs12pR7jUhRCzg3ZH54uha6pzq+g61I5bv0BeiDTyr1v0N5q4+L5KBcWhbsDDwz2ZjyJ/aUN5vv7OyGTVDB5138P8884PgdcFTwPXiz/WFRkoGjESf/N2ewyoJoJajTy2Ppdl+uQ8p6TCIfaMz6DqfwzXHLpZQQJasKdLu+ukrJdGVulLYSGHPmvm1lWEkA8pLJpn9n/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gcAlYM3QEaI2d/Fft46Yr8UgLzYMKV6al37V7lAZeKg=; b=JTiTl/nN4mxJhFS1Fczr8fDkEZ1rpxSzcs1phkQuHXv+G/JoYlmiK44XtNcM0VfevJQ5CYBNgi+hB04WCfgY8JHoZNuC4FmG93NJEP6g3cbG4q2HM3KNPzzc0VMqCcd6G/CJ308OWJcnN2tkKglFL94ZiErcxINKK0cFe4nBiVw= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4413.namprd12.prod.outlook.com (2603:10b6:806:9e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.24; Thu, 3 Jun 2021 12:16:52 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4173.030; Thu, 3 Jun 2021 12:16:52 +0000 Cc: brijesh.singh@amd.com, Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH RFC v3 01/22] UefiCpuPkg: Define the SEV-SNP specific dynamic PCDs To: Laszlo Ersek , devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Erdem Aktas , Eric Dong , Ray Ni , Rahul Kumar References: <20210526231118.12946-1-brijesh.singh@amd.com> <20210526231118.12946-2-brijesh.singh@amd.com> <5789af86-593f-46b3-0502-c0afb2223786@redhat.com> From: "Brijesh Singh" Message-ID: Date: Thu, 3 Jun 2021 07:16:47 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 In-Reply-To: <5789af86-593f-46b3-0502-c0afb2223786@redhat.com> X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: SA9PR13CA0145.namprd13.prod.outlook.com (2603:10b6:806:27::30) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SA9PR13CA0145.namprd13.prod.outlook.com (2603:10b6:806:27::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.10 via Frontend Transport; Thu, 3 Jun 2021 12:16:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86730362-d912-4240-545b-08d92689782d X-MS-TrafficTypeDiagnostic: SA0PR12MB4413: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GPiYa+/YW7yQI7r3qZxpSNiiBh8aaN5Offb+f4ESNaTjI/uMRLRm0gv3LNO4lQ2Yn6wg8bHziKo36bWwWzJ3FwyrfehKB9nxpQpnsyE37SkiqU5QVfs05HQT5wfr93EZK3JjVtGoCaSFi0S8QR9lcOxTpriQnX+3dpL5kQD9PGHSXupTAd+k/BpPb2X+VBLkDeRgkPu6WEQiRO1eMgxsvet3cQ/n0x8VrD5ku3z1mJFhfCBkSqHZPdJfdYj2+qZzoSEpNUT1LjAgDBJCA6bhqVRVYcvKDLmbVRurchNUdlitr1HQk57kiGvDcbHWYg/Tk5V4rYRoS5Hi0RdvsRPmmPFtJ2zzeBaO4XKM9Om5dVoePRbiixqxBxQpk8bZnJPGMxc0uE20TGxNuRUTWv8TrXMQ5eqktVHapw1gswxPOERIYth+qVbtR1A5Q5DYfHdYZLaj0tEThMv2poEwj9pM/4OAUw/52o7eg2+Arceb3NIOfp9gWc2TBW1/7gGjy9b+t1hpV4t+Dt+e7DEfobgfsyMK74YnXxGWlO123muL9U4hVZGN7I9P5FsU95bjgLnkXam5lXuD73rbxvWV3WZj7Xdm5SuJqjniRT//agrotOLdffghV90oMo7O2+sXXKVPSX1kCmY/lsJRf00fPYgk0z0Waq2BvrXVAhEvCCynkBQmv4jQE+ieF5kqHnQki1VWAREFVH/ZZzaMO/CZs2uzZNfyxwG+2F2GjitgdO6izQzakffqQA/fsaI07+fTNZkq/oT9T3oFuiR1cTkCQ1KikR3vJ2hilV0Cc+uydtFTaBqU1WfqTrIN00oeZubS7efkQyyHx9DC5qXAVJMWmBZEu/kwRXJ61t+VF1/EZbmno80= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(5660300002)(36756003)(921005)(38350700002)(83380400001)(8936002)(4326008)(66556008)(66476007)(66946007)(186003)(53546011)(86362001)(6506007)(2616005)(44832011)(38100700002)(31696002)(26005)(45080400002)(478600001)(6512007)(8676002)(6486002)(31686004)(110136005)(316002)(16526019)(7416002)(2906002)(52116002)(966005)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VlJyTW9jaDN4cC9WTjZURVo4YVZENmlRcjNTdHJEYXdFaGl4SWpET05PdUlm?= =?utf-8?B?N3c2ekkyZ1ZaYUxGK0lIcjh0OGVwY09UbmZKR1dxNTRZbnZnT1JRWjRnNmtJ?= =?utf-8?B?clBSODBoZ1RtRjF0blg2QWZMb0tiRkMrdERqRTh3UVFvRXJIKzZJeWhNMjdU?= =?utf-8?B?NDhzVkdvZDlXSUp3cVowNGx0cVJJWS9rMWMvWGVORnJOeGV1U1dtcnRTMDBW?= =?utf-8?B?ODBLbmVyWGw1bURrRElFd2tvSzI5cHBvQSs5Y09JeHBxdHl2Sno0Z094ZnhB?= =?utf-8?B?NXlEMlpsVXdEbGoxNzNlYm5LNSttVnd2MDVlc1pINjdvcmtMTHRCaU1KVzlJ?= =?utf-8?B?N2R2cnBNNFlvbXZpbnVzVVVwaXRJU3FGZXNaaExxTzYwbS9qSy85cjhwcFpX?= =?utf-8?B?TC9xdGFPcFJFSDMvUDdpcklDcm1pVlVmMDRrbDQrUUVuc0RjUE5lTzJNSWhV?= =?utf-8?B?MEtSdmhLMDJQUnFxbEZDaWxiR0NYL1IyNlBDUHd5VW5UVkpoU0x6eVVkOTF3?= =?utf-8?B?L00wVmkrWFhCMHVvcmhlWUZsNkROVzJaZ3dSRVhaekpRM3pLK1dBb05NUFE0?= =?utf-8?B?UE9tYlZOZzc2YW1SRThubU02M2NPN1pXQ2FJNHJyNlY3MS9RUWlETG9pQ0Nx?= =?utf-8?B?WkhpeDR0WWVDZXpUWlJ0UFBvZ1dhbzNIbGdFMUJ3SlVNM2Y4S0htemhyK3hL?= =?utf-8?B?Qk96RWhUc3dzc1dwT2xMRGEvUGZ1WDM4Nk1jL1MzRkhOa3VMdmw1NVl4NTht?= =?utf-8?B?VURqSkhZeHFrYi9jYWQvczEvVFVXdDlqUWdxMTh1SzZYOEUvRzRzdVk2aXVG?= =?utf-8?B?NWpFRG9wRWRQQ2l0Si92T0pSa2dvd0tFUGRCVzYraGVCbFBjQ3ZBRERwY2xz?= =?utf-8?B?YndHQmJ1T2k4Q3ZNKzJCQmtjVjljK2tUbUtZVmIwY3NaeUt1WXoyZllidDht?= =?utf-8?B?QTgyT0Fkc1E4SjBxSTdPUkh6ekk1VllFWDJKK2FJbTdpbUl1UTJWRVFwWXlr?= =?utf-8?B?L3J0TUQ4UGluUElCY1hoVS9MR1FxeW5UZTRucFNYSmFTaGdGdDZZQ3BaL0Jk?= =?utf-8?B?aXovbnRQTHgzTVdsd2lOOUcwbm1kTGdiR3E2dzBZOUphbWFnUkVpRytrRHlh?= =?utf-8?B?ajJOL1VkK1Bqdzl1R3k3NGlaMyt6M3JYekxKalBKSFl3SDRaQW4vTGF1TXZG?= =?utf-8?B?OHZhcnNaeGtlT2duUWY5R3NvRGZWVFhMMG93azlnazBEeTlzelhwbE0xdS9L?= =?utf-8?B?OEFGdDlOLzExMmNTS0VCN1Nwcm9rQ083dzRLa3RFQit1VHEwd1R1b0lmTkJu?= =?utf-8?B?VzRqM3FxekQzZ2lVL1pVRHRSa1VZcFB3Q3pVNVNHUjRXU09QTlhwOVFSaTds?= =?utf-8?B?KzNXNDk5RTQ4SVZ2dkI1OWZzQ1BOeU5QcW8zZkNVcVFJRC9yV3k3TXVGUmNL?= =?utf-8?B?OXZhc2prZmJrRGh2MDRjL3ljRVhrQWkvdlEvTXJPUUYzME9FRjIyL3lhTm80?= =?utf-8?B?czhUOEFlUGtIL3paenlvYlUxSUFtRnFSNUxBakdPMlVET3dTQU5yZmlERUNV?= =?utf-8?B?OXJqNGV5RkFtTm9aa1QvelN2ck55bzlUbjBMZ0lscFIzb3cyc215WHd0b1lm?= =?utf-8?B?a1h1MWtMQ0pqaTZaZGcrOWxLeU5CVFlteFpGaWtGaXNTTHJZUHBFYTV0VVVp?= =?utf-8?B?dzBwVE83TWlLS2dwY0Z6dG1DeVBDUE1ZL1hJOGMrVUY3aVpnNEpPVkJQbWJD?= =?utf-8?Q?X5TrmHBrvKqwEfs9dQ3lwsiFc0++GZUSNDLFT/f?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86730362-d912-4240-545b-08d92689782d X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2021 12:16:52.0186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H6zZ/esiu5nhgWUmBzyPL9PC303ypDAdjLSPnM8V9XXP5zO2rGKjhk8SfIfXaBy1PuGXncknbIdqXdi0ctvlaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4413 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 6/3/21 3:15 AM, Laszlo Ersek wrote: > Hi Brijesh, > > On 05/27/21 01:10, Brijesh Singh wrote: >> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cb4d27ba148e544f984ee08d92667d860%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637583049740462496%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=DaecxXoG%2BK932q9T70ISC%2BAIX4%2BUrAf6is6lEJmi9co%3D&reserved=0 >> >> Define the PCDs used by the MpLib while creating the AP when SEV-SNP is >> active in the guest VMs. >> >> Cc: James Bottomley >> Cc: Min Xu >> Cc: Jiewen Yao >> Cc: Tom Lendacky >> Cc: Jordan Justen >> Cc: Ard Biesheuvel >> Cc: Laszlo Ersek >> Cc: Erdem Aktas >> Signed-off-by: Brijesh Singh >> --- >> UefiCpuPkg/UefiCpuPkg.dec | 11 +++++++++++ >> 1 file changed, 11 insertions(+) > I'm really sorry that this is my first "actual" comment (on the 7th day > of your posting this series), but the CC list is incorrect on this > patch, and (at least) on patch#11 as well. > > I'm a stickler myself for being CC'd on any patches per > "Maintainers.txt", so I'm going to request a resending of this series, > with the CC lists extended. > > Please run "$EDK_TOOLS_PATH/Scripts/GetMaintainer.py" on every patch in > the series, and add the missing CC's. Manually copying all of the > "confidential computing" reviewers on all of the patches is great, but > we need to keep the usual package-level reviewers/maintainers as well. > > In particular, the UefiCpuPkg patches need to be copied to Eric, Ray and > Rahul -- like you actually did in patch#21. Patch#22 also misses the > MdePkg reviewers (Michael, Liming, Zhiguang). Actually all the UefiCpuPkg maintainers/reviewers are CC'ed in the whole series. Its just that they are not listed in the git commit Cc tag. Patch#22 was a single one liner which bumps the version number after the SNP support is added. I was not sure if MdePkg maintainer will have much comment so I tried to avoid flooding the inbox -- I guess I should have copied them. I will resend with Cc tags updated. > I'm truly sorry that this must feel like a cop-out on my part. I won't > deny that I appreciate a breather after the last two, hellishly busy, > two weeks, but I *did* resolve last night to start reviewing this series > today. (I should note that we expect reviewers to start reviewing a > patch set within a calendar week, so my feedback *is* just in time by my > count -- except, I expected to make actual patch review comments.) > > If you can resend today with the CC's correct, I'll make an attempt to > start reviewing tomorrow. > > Also, let me point this out: we have a nice long CC list now, by virtue > of the "confidential computing" section in "Maintainers.txt", and a > calendar week has passed -- I'd have appreciated seeing comments from > others as well! > > Thanks, > Laszlo > >> diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec >> index 62acb291f309..0ec25871a50f 100644 >> --- a/UefiCpuPkg/UefiCpuPkg.dec >> +++ b/UefiCpuPkg/UefiCpuPkg.dec >> @@ -396,5 +396,16 @@ [PcdsDynamic, PcdsDynamicEx] >> # @Prompt SEV-ES Status >> gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|FALSE|BOOLEAN|0x60000016 >> >> + ## This dynamic PCD indicates whether SEV-SNP is enabled >> + # TRUE - SEV-SNP is enabled >> + # FALSE - SEV-SNP is not enabled >> + # @Prompt SEV-SNP Status >> + gUefiCpuPkgTokenSpaceGuid.PcdSevSnpIsEnabled|FALSE|BOOLEAN|0x60000017 >> + >> + ## This dynamic PCD contains the hypervisor features value obtained through the GHCB HYPERVISOR >> + # features VMGEXIT defined in the version 2 of GHCB spec. >> + # @Prompt GHCB Hypervisor Features >> + gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures|0x0|UINT64|0x60000018 >> + >> [UserExtensions.TianoCore."ExtraFiles"] >> UefiCpuPkgExtra.uni >>