From: "Laszlo Ersek" <lersek@redhat.com>
To: Hao A Wu <hao.a.wu@intel.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, David Woodhouse <dwmw2@infradead.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v1 0/9] Duplicate required CSM components for OVMF
Date: Wed, 15 May 2019 10:46:12 +0200 [thread overview]
Message-ID: <aa6e0efc-27a6-4afd-ed47-86c6c0b66538@redhat.com> (raw)
In-Reply-To: <20190515082720.12560-1-hao.a.wu@intel.com>
Hello Hao,
thanks for this series. I have one high-level comment at this point:
On 05/15/19 10:27, Hao A Wu wrote:
> This series is also available at:
> https://github.com/hwu25/edk2/tree/ovmf_csm_v1
>
> The series will duplicate the CSM components used by the OVMF package from
> IntelFrameworkModulePkg & IntelFrameworkPkg.
>
> Verification done for the series:
> * Build pass with/without build command option '-D CSM_ENABLE';
> * Boot shell pass with the built images.
>
> Also, the series does not cover the update of file 'Maintainers.txt' to
> cover the maintainance duty for the copied CSM components. Maybe this can
> be addressed via another patch.
Actually, I insist on the inverse approach here, please. I will not
accept CSM components under OvmfPkg unless the first patch of the series
introduces a new "R" role in Maintainers.txt, such as:
OvmfPkg
...
R: Name <email>
(CSM components)
I will commence reviewing the series if the series starts with such a
patch, *and* the proposed long-term CSM reviewer ACKs it.
(As we discussed earlier, the alternative is to remove CSM from OVMF.)
My understanding is that David offered to step up for this reviewer role.
AIUI, TianoCore#1811 -- this series -- blocks TianoCore#1604 and
TianoCore#1605 -- IntelFramework[Module]Pkg removals --, and those are
planned for edk2-stable201908.
I suggest that we come to an agreement on the CSM reviewership first,
and then return to this series after the edk2-stable201905 release has
been tagged. Right now is a very busy time.
(The DSC files are undergoing a bit of reorganization anyway, at the
moment, due to <https://bugzilla.tianocore.org/show_bug.cgi?id=1293>,
which is planned for edk2-stable201905.)
Thanks,
Laszlo
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Hao A Wu (9):
> OvmfPkg: Copy the required CSM components from framework packages
> OvmfPkg/OvmfPkg.dec: Add definitions for CSM-related Guid & Protocol
> OvmfPkg/OvmfPkg.dec: Add the new include folder for CSM header files
> OvmfPkg/OvmfPkg.dec: Add PCD definitions used by copied CSM modules
> OvmfPkg/Csm/VideoDxe: Update to make it build for OVMF
> OvmfPkg/Csm/LegacyBiosDxe: Update to make it build for OVMF
> OvmfPkg/Csm/LegacyBootMaintUiLib: Update to make it build for OVMF
> OvmfPkg/Csm/LegacyBootManagerLib: Update to make it build for OVMF
> OvmfPkg: Update DSC/FDF files to consume CSM components in OvmfPkg
>
> OvmfPkg/OvmfPkg.dec | 68 +
> OvmfPkg/OvmfPkgIa32.dsc | 10 +-
> OvmfPkg/OvmfPkgIa32X64.dsc | 10 +-
> OvmfPkg/OvmfPkgX64.dsc | 10 +-
> OvmfPkg/OvmfPkgIa32.fdf | 4 +-
> OvmfPkg/OvmfPkgIa32X64.fdf | 4 +-
> OvmfPkg/OvmfPkgX64.fdf | 4 +-
> OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf | 78 +
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.inf | 129 +
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 62 +
> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf | 57 +
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 532 ++++
> OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 459 +++
> OvmfPkg/Csm/Include/Framework/BootScript.h | 41 +
> OvmfPkg/Csm/Include/Framework/DxeCis.h | 170 +
> OvmfPkg/Csm/Include/Framework/FirmwareVolumeHeader.h | 79 +
> OvmfPkg/Csm/Include/Framework/FirmwareVolumeImageFormat.h | 32 +
> OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 397 +++
> OvmfPkg/Csm/Include/Framework/Hob.h | 28 +
> OvmfPkg/Csm/Include/Framework/StatusCode.h | 155 +
> OvmfPkg/Csm/Include/FrameworkDxe.h | 26 +
> OvmfPkg/Csm/Include/Guid/LegacyBios.h | 29 +
> OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h | 39 +
> OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h | 340 ++
> OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 298 ++
> OvmfPkg/Csm/Include/Protocol/IsaIo.h | 356 +++
> OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 1553 +++++++++
> OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 755 +++++
> OvmfPkg/Csm/Include/Protocol/LegacyInterrupt.h | 122 +
> OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 88 +
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 1460 +++++++++
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 249 ++
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 79 +
> OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h | 60 +
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 3289 ++++++++++++++++++++
> OvmfPkg/Csm/BiosThunk/VideoDxe/ComponentName.c | 306 ++
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c | 377 +++
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBda.c | 62 +
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 1214 ++++++++
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 2173 +++++++++++++
> OvmfPkg/Csm/LegacyBiosDxe/LegacyCmos.c | 117 +
> OvmfPkg/Csm/LegacyBiosDxe/LegacyIde.c | 310 ++
> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 3083 ++++++++++++++++++
> OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c | 477 +++
> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 419 +++
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 1505 +++++++++
> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 1530 +++++++++
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxe.uni | 17 +
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxeExtra.uni | 14 +
> OvmfPkg/Csm/LegacyBiosDxe/IA32/InterruptTable.nasm | 63 +
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.uni | 16 +
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxeExtra.uni | 14 +
> OvmfPkg/Csm/LegacyBiosDxe/X64/InterruptTable.nasm | 64 +
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 20 +
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni | 43 +
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr | 67 +
> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni | 20 +
> 57 files changed, 22962 insertions(+), 21 deletions(-)
> create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.inf
> create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
> create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf
> create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
> create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
> create mode 100644 OvmfPkg/Csm/Include/Framework/BootScript.h
> create mode 100644 OvmfPkg/Csm/Include/Framework/DxeCis.h
> create mode 100644 OvmfPkg/Csm/Include/Framework/FirmwareVolumeHeader.h
> create mode 100644 OvmfPkg/Csm/Include/Framework/FirmwareVolumeImageFormat.h
> create mode 100644 OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h
> create mode 100644 OvmfPkg/Csm/Include/Framework/Hob.h
> create mode 100644 OvmfPkg/Csm/Include/Framework/StatusCode.h
> create mode 100644 OvmfPkg/Csm/Include/FrameworkDxe.h
> create mode 100644 OvmfPkg/Csm/Include/Guid/LegacyBios.h
> create mode 100644 OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h
> create mode 100644 OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h
> create mode 100644 OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> create mode 100644 OvmfPkg/Csm/Include/Protocol/IsaIo.h
> create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyBios.h
> create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
> create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyInterrupt.h
> create mode 100644 OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
> create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h
> create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h
> create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h
> create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
> create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/ComponentName.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBda.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyCmos.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyIde.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/Thunk.c
> create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c
> create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c
> create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxe.uni
> create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxeExtra.uni
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/IA32/InterruptTable.nasm
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.uni
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxeExtra.uni
> create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/X64/InterruptTable.nasm
> create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni
> create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni
> create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr
> create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni
>
prev parent reply other threads:[~2019-05-15 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 8:27 [PATCH v1 0/9] Duplicate required CSM components for OVMF Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 1/9] OvmfPkg: Copy the required CSM components from framework packages Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 2/9] OvmfPkg/OvmfPkg.dec: Add definitions for CSM-related Guid & Protocol Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 3/9] OvmfPkg/OvmfPkg.dec: Add the new include folder for CSM header files Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 4/9] OvmfPkg/OvmfPkg.dec: Add PCD definitions used by copied CSM modules Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 5/9] OvmfPkg/Csm/VideoDxe: Update to make it build for OVMF Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 6/9] OvmfPkg/Csm/LegacyBiosDxe: " Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 7/9] OvmfPkg/Csm/LegacyBootMaintUiLib: " Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 8/9] OvmfPkg/Csm/LegacyBootManagerLib: " Wu, Hao A
2019-05-15 8:27 ` [PATCH v1 9/9] OvmfPkg: Update DSC/FDF files to consume CSM components in OvmfPkg Wu, Hao A
2019-05-15 8:46 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6e0efc-27a6-4afd-ed47-86c6c0b66538@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox