Re: [PATCH v3 1/6] MdeModulePkg: cleanup Heap Guard pool/page type PCD documentation

["Zeng, Star" <star.zeng@intel.com>]

On 2018/10/24 13:26, Jian J Wang wrote:
>> v3 changes:
>> a. split from #1 patch of v2
>> b. update title
> 
> This cleanup is meant for avoiding misuse of newly introduced BIT4
> (UAF detection) of PCD PcdHeapGuardPropertyMask, because it applies
> to all types of physical memory. In another words,
> PcdHeapGuardPoolType and PcdHeapGuardPageType don't have effect to
> the BIT4 of PcdHeapGuardPropertyMask.
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>

Reviewed-by: Star Zeng <star.zeng@intel.com>

You may can add Laszlo's RB and even Suggested-by according to Laszlo's 
feedback to V2 patch series.


Thanks,
Star

> ---
>   MdeModulePkg/MdeModulePkg.dec | 4 ++++
>   MdeModulePkg/MdeModulePkg.uni | 2 ++
>   2 files changed, 6 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 6037504fa7..2009dbc5fd 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -955,6 +955,8 @@
>     # free pages for all of them. The page allocation for the type related to
>     # cleared bits keeps the same as ususal.
>     #
> +  # This PCD is only valid if BIT0 and/or BIT2 are set in PcdHeapGuardPropertyMask.
> +  #
>     # Below is bit mask for this PCD: (Order is same as UEFI spec)<BR>
>     #  EfiReservedMemoryType             0x0000000000000001<BR>
>     #  EfiLoaderCode                     0x0000000000000002<BR>
> @@ -984,6 +986,8 @@
>     # if there's enough free memory for all of them. The pool allocation for the
>     # type related to cleared bits keeps the same as ususal.
>     #
> +  # This PCD is only valid if BIT1 and/or BIT3 are set in PcdHeapGuardPropertyMask.
> +  #
>     # Below is bit mask for this PCD: (Order is same as UEFI spec)<BR>
>     #  EfiReservedMemoryType             0x0000000000000001<BR>
>     #  EfiLoaderCode                     0x0000000000000002<BR>
> diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
> index a6bcb627cf..9d2e473fa9 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1171,6 +1171,7 @@
>                                                                                           " before and after corresponding type of pages allocated if there's enough\n"
>                                                                                           " free pages for all of them. The page allocation for the type related to\n"
>                                                                                           " cleared bits keeps the same as ususal.\n\n"
> +                                                                                        " This PCD is only valid if BIT0 and/or BIT2 are set in PcdHeapGuardPropertyMask.\n\n"
>                                                                                           " Below is bit mask for this PCD: (Order is same as UEFI spec)<BR>\n"
>                                                                                           "  EfiReservedMemoryType             0x0000000000000001\n"
>                                                                                           "  EfiLoaderCode                     0x0000000000000002\n"
> @@ -1198,6 +1199,7 @@
>                                                                                           " before and after corresponding type of pages which the allocated pool occupies,\n"
>                                                                                           " if there's enough free memory for all of them. The pool allocation for the\n"
>                                                                                           " type related to cleared bits keeps the same as ususal.\n\n"
> +                                                                                        " This PCD is only valid if BIT1 and/or BIT3 are set in PcdHeapGuardPropertyMask.\n\n"
>                                                                                           " Below is bit mask for this PCD: (Order is same as UEFI spec)<BR>\n"
>                                                                                           "  EfiReservedMemoryType             0x0000000000000001\n"
>                                                                                           "  EfiLoaderCode                     0x0000000000000002\n"
>