From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mx.groups.io with SMTP id smtpd.web12.5296.1634187810119727904 for ; Wed, 13 Oct 2021 22:03:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=6bd0e/gS; spf=pass (domain: nuviainc.com, ip: 209.85.215.171, mailfrom: rebecca@nuviainc.com) Received: by mail-pg1-f171.google.com with SMTP id 66so4388287pgc.9 for ; Wed, 13 Oct 2021 22:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=VmVdh9d0W4OwsdlGSrTnhmbPNISA9iYsHbNl5Mwtbic=; b=6bd0e/gSenGnyeYyk4D2v5LAUeuKgFM1T0A1XnYBhPa9rIvEwB+vnm2CUuyTxFq/QR MkCqzfn7Rsv3p03dTRDTYVW5H4WV11p0YzXw8L16D40tP9FOzur4Z+7b2NdiT9BhRdWl ATnKohdJwfMv+xb00ACTLF+u1dS/v1Jt+WfsQkujYMbctod7D1XuQUEPDTA8YwyT4IcQ jFrHG7LJ9tgpthm28Aotd3mdji/zwLttm/SN7WnJLuU6xog9ChJBX4a2NJpFkpkhM5LO C4+O1yYTCXjJBml8HfAHYpgAtTYqgk7ZC4XUDhf54u4zMwC83ed8GQfA9B0U6Kx6S/Ez vAIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VmVdh9d0W4OwsdlGSrTnhmbPNISA9iYsHbNl5Mwtbic=; b=lfitZ8SOqGmIEBZoLEVvme7oV2kJ/PkrmFxKnqTNWSVEdqxRSSwn05q55mr5Oly73B EdieHffXa10LnrKAlXozzZMvLNq/hK4c4GvcBNDKlisETn+lU3rDCoa51YlQ0AvT2t48 wcpvDSFeWd//JpVDfP9EN7d6gTJO7w7Aalb3xdzjEx0WXNkiam3JAXYFMv3GwY0+UBYR y3OrK7XeY/c9F+lpuxV1K0vWJwe0/vPb9Di1w1rpC+EvetKj1aZLQxvenjTUVqIKuDNH k9ettObVn6UXqlGR6T6pcPa7aGfViipSISAcQBZSra4PBmOQLm8zZMJSHJ4EWH+RWRxv /oJA== X-Gm-Message-State: AOAM531ZV4yHQhDbAWQxhWkkepoTt1YXklWfe9HzxlR3+0iIFaDYYdP4 eCX4BYtwosJxEEzXKhAQ3Kvn3w== X-Google-Smtp-Source: ABdhPJxE/GIXCUHhEh4RB5ui5DaPh/PWaU1Ftb2ubg7CGbGND/fvkVQzU7yOPwR5UrAI3BuNz812cw== X-Received: by 2002:aa7:9844:0:b0:44c:ce0a:f736 with SMTP id n4-20020aa79844000000b0044cce0af736mr3427162pfq.1.1634187809456; Wed, 13 Oct 2021 22:03:29 -0700 (PDT) Return-Path: Received: from linbox.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id b10sm1076639pfl.200.2021.10.13.22.03.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Oct 2021 22:03:28 -0700 (PDT) Subject: Re: [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python3.6.8: add IA32 support for py3 package creation batch script To: Jayaprakash Nevara , devel@edk2.groups.io Cc: Michael D Kinney References: <20211014044803.630-1-n.jayaprakash@intel.com> <20211014044803.630-2-n.jayaprakash@intel.com> From: "Rebecca Cran" Message-ID: Date: Wed, 13 Oct 2021 23:03:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211014044803.630-2-n.jayaprakash@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Pushed as 2ebe49ccd34cfd59bac32216b71334d371b3fa44. Sorry, I forgot to add my "Acked-by" to the commit before pushing. Acked-by: Rebecca Cran On 10/13/21 10:48 PM, Jayaprakash Nevara wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3638 > > This change is to add IA32 support into py3 EFI package > creation batch script. Enhanced the script take Architecture > as an additional parameter. With this the script can be used > to create deployable Python 3.6.8 EFI package from X64 and IA32 builds > as required by the user > > Cc: Rebecca Cran > Cc: Michael D Kinney > Signed-off-by: Jayaprakash N > --- > .../Python-3.6.8/create_python368_pkg.bat | 62 ++++++++++++------- > 1 file changed, 39 insertions(+), 23 deletions(-) > > diff --git a/AppPkg/Applications/Python/Python-3.6.8/create_python368_pkg.bat b/AppPkg/Applications/Python/Python-3.6.8/create_python368_pkg.bat > index 6bbdbd9..b48f83e 100644 > --- a/AppPkg/Applications/Python/Python-3.6.8/create_python368_pkg.bat > +++ b/AppPkg/Applications/Python/Python-3.6.8/create_python368_pkg.bat > @@ -2,47 +2,63 @@ > > set TOOL_CHAIN_TAG=%1 > set TARGET=%2 > -set OUT_FOLDER=%3 > +set ARCH=%3 > +set OUT_FOLDER=%4 > if "%TOOL_CHAIN_TAG%"=="" goto usage > if "%TARGET%"=="" goto usage > +if "%ARCH%"=="" goto usage > if "%OUT_FOLDER%"=="" goto usage > goto continue > > :usage > echo. > +echo Batch Script to create Python EFI Package. > echo. > +echo Invalid command line arguments passed, please see the below usage instructions > echo. > -echo Creates Python EFI Package. > -echo. > -echo "Usage: %0 " > -echo. > -echo ToolChain = one of VS2013x86, VS2015x86, VS2017, VS2019 > -echo Target = one of RELEASE, DEBUG > -echo OutFolder = Target folder where package needs to create > -echo. > +echo "Usage: %0 " > echo. > +echo ToolChain = one of VS2013x86, VS2015x86, VS2017, VS2019 > +echo Target = one of RELEASE, DEBUG > +echo Architecture = one of IA32, X64 > +echo OutFolder = Output directory for creating the package > echo. > > goto :eof > > :continue > cd ..\..\..\..\ > -IF NOT EXIST Build\AppPkg\%TARGET%_%TOOL_CHAIN_TAG%\X64\Python368.efi goto error > -mkdir %OUT_FOLDER%\EFI\Tools > -xcopy Build\AppPkg\%TARGET%_%TOOL_CHAIN_TAG%\X64\Python368.efi %OUT_FOLDER%\EFI\Tools\ /y > -mkdir %OUT_FOLDER%\EFI\StdLib\lib\python36.8 > -mkdir %OUT_FOLDER%\EFI\StdLib\etc > -xcopy AppPkg\Applications\Python\Python-3.6.8\Lib\* %OUT_FOLDER%\EFI\StdLib\lib\python36.8\ /Y /S /I > -xcopy StdLib\Efi\StdLib\etc\* %OUT_FOLDER%\EFI\StdLib\etc\ /Y /S /I > -goto all_done > - > -:error > -echo Failed to Create Python 3.6.8 Package, Python368.efi is not available on build location Build\AppPkg\%TARGET%_%TOOL_CHAIN_TAG%\X64\ > +if not exist Build\AppPkg\%TARGET%_%TOOL_CHAIN_TAG%\%ARCH%\Python368.efi ( > + goto error > +) > > +if not exist %OUT_FOLDER%\EFI\Tools ( > + mkdir %OUT_FOLDER%\EFI\Tools > +) > +xcopy Build\AppPkg\%TARGET%_%TOOL_CHAIN_TAG%\%ARCH%\Python368.efi %OUT_FOLDER%\EFI\Tools\ /y > > -:all_done > -exit /b %ec% > - > +if not exist %OUT_FOLDER%\EFI\StdLib\lib\python36.8 ( > + mkdir %OUT_FOLDER%\EFI\StdLib\lib\python36.8 > +) > +if not exist %OUT_FOLDER%\EFI\StdLib\etc ( > + mkdir %OUT_FOLDER%\EFI\StdLib\etc > +) > +xcopy AppPkg\Applications\Python\Python-3.6.8\Lib\* %OUT_FOLDER%\EFI\StdLib\lib\python36.8\ /Y /S /I > +xcopy StdLib\Efi\StdLib\etc\* %OUT_FOLDER%\EFI\StdLib\etc\ /Y /S /I > +echo. > > +if not x%OUT_FOLDER::=%==x%OUT_FOLDER% ( > + echo Python EFI package available at %OUT_FOLDER% > +) else ( > + echo Python EFI package available at %CD%\%OUT_FOLDER% > +) > +goto all_done > > +:error > +echo Failed to Create Python EFI Package > +echo Python368.efi is not available at Build\AppPkg\%TARGET%_%TOOL_CHAIN_TAG%\%ARCH%\ > +echo Follow the instructions in Py368ReadMe.txt to build Python interpreter > +echo Then use this script to create a Python EFI package > > +:all_done > +exit /b %ERRORLEVEL%