From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C02D97803E3 for ; Fri, 17 Nov 2023 16:09:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MFzdJuGjlp79JyLR6dgZ+9jA2lEzqsdrHnQtSXfGidk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700237353; v=1; b=OnyTznHHFsFf9j+5ByyIZ9FhO9wAdCXlYcNO49vKV1eRXPZyaPDU+6DirupZ1zV/N81KmQAQ PnycTmp0I0FeLNnfjuNzHS4SZJuDB65JxpfhC0LWmr0NWU5wg1SSztQSsOB3eOMEDnJNSvviRnI 8Kb7jXbKqe1GG9lQunqQRLjI= X-Received: by 127.0.0.2 with SMTP id DCH0YY7687511xlqgoPmiwYP; Fri, 17 Nov 2023 08:09:13 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.15122.1700237352888406929 for ; Fri, 17 Nov 2023 08:09:13 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-IPdLQ1OrOdKoH-pqHlEjIw-1; Fri, 17 Nov 2023 11:09:08 -0500 X-MC-Unique: IPdLQ1OrOdKoH-pqHlEjIw-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 364A6101A52D; Fri, 17 Nov 2023 16:09:08 +0000 (UTC) X-Received: from [10.39.193.21] (unknown [10.39.193.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05DEC492BFD; Fri, 17 Nov 2023 16:09:06 +0000 (UTC) Message-ID: Date: Fri, 17 Nov 2023 17:09:05 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: use a proper PCI IO range To: devel@edk2.groups.io, corvink@FreeBSD.org Cc: Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Rebecca Cran , "Liming Gao (Byosoft address)" References: <20231117124354.63713-1-corvink@FreeBSD.org> From: "Laszlo Ersek" In-Reply-To: <20231117124354.63713-1-corvink@FreeBSD.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6CACh7OCNLQiuo3XidjSZRwpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OnyTznHH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/17/23 13:43, Corvin Köhne wrote: > Bhyve uses an io port range of [ 0x2000, 0x10000 ] [1]. At the moment, > EDKII is using a subset of this range [ 0xC000, 0x10000 ] [2]. Even > though the EDKII range doesn't exeed the bhyve range, it's causing s/exeed/exceed/ > issues on some guests like OpenBSD. We don't know why it's causing > issues yet. However, using the same IO port range in EDKII fixes the > issue and is a good idea anyway. > > [1] https://github.com/freebsd/freebsd-src/blob/82ea0132c8b17a7a6067c8a36c6434e587ede6de/usr.sbin/bhyve/pci_emul.c#L133-L134 > [2] https://github.com/tianocore/edk2/blob/fb044b7fe893a4545995bfe2701fd38e593355d9/OvmfPkg/Bhyve/PlatformPei/Platform.c#L156-L157 > > Signed-off-by: Corvin Köhne > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Rebecca Cran > --- > OvmfPkg/Bhyve/PlatformPei/Platform.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c > index f6d9a9038e12..bd1b22a9476e 100644 > --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c > +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c > @@ -153,8 +153,8 @@ MemMapInitialization ( > UINT64 PciIoSize; > RETURN_STATUS PcdStatus; > > - PciIoBase = 0xC000; > - PciIoSize = 0x4000; > + PciIoBase = 0x2000; > + PciIoSize = 0xE000; > > // > // Create Memory Type Information HOB Reviewed-by: Laszlo Ersek Can you create a BZ for this issue? With that, I think this should be possible to merge during the hard feature freeze. Adding Liming. (For the typo fix in the commit message, either post v2, or ask Liming to fix it up upon merge.) Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111403): https://edk2.groups.io/g/devel/message/111403 Mute This Topic: https://groups.io/mt/102646333/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-