From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.627.1610117255006715706 for ; Fri, 08 Jan 2021 06:47:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cYiBhIFv; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610117254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/6b8bc84k6iszACo3dEtOR8YoZe7Lx53hpP2d309pmo=; b=cYiBhIFv349W0mURTR4jJ25l1uevavxpBoU9GNaUeQqGYXTQrA0O7SMRpl9k/VdwgVwB7X hNRucrgOSI6BmW1j2pN0dcC69846g06j0/5icFMmgha5WhraBBS/40q9DZHZJBwk6EsqEB scmVzTnIHD/png5AksOPk3X5w/nD5xc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-E9DmCTLDNYmj1YPgQNm25g-1; Fri, 08 Jan 2021 09:47:32 -0500 X-MC-Unique: E9DmCTLDNYmj1YPgQNm25g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 173FE107ACE3; Fri, 8 Jan 2021 14:47:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-112.ams2.redhat.com [10.36.113.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id AED815D9DE; Fri, 8 Jan 2021 14:47:29 +0000 (UTC) Subject: Re: [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen To: Leif Lindholm , devel@edk2.groups.io Cc: Ard Biesheuvel , Anthony Perard , Julien Grall References: <20210108141238.19911-1-leif@nuviainc.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 8 Jan 2021 15:47:28 +0100 MIME-Version: 1.0 In-Reply-To: <20210108141238.19911-1-leif@nuviainc.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/08/21 15:12, Leif Lindholm wrote: > Commit 55ee36b0c490 > ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib") > added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks > build of OvmfXen.dsc. > > Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Leif Lindholm > --- > OvmfPkg/OvmfXen.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index c13388ba5a05..7d31e88907ca 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -212,6 +212,7 @@ [LibraryClasses] > Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > RealTimeClockLib|OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.inf > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > !ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE) > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPortNocheck.inf > !else > Reviewed-by: Laszlo Ersek Thank you! Laszlo