Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

["Laszlo Ersek" <lersek@redhat.com>]

Hi Leo,

On 02/25/20 20:39, Leo Duran wrote:
> This patch set fixes an issue introduced recently in MpInitLib, where we read
> a PlatformId MSR that is not implemented on AMD processors.
> 
> The proposed solution is to export the StandardSignatureIsAuthenticAMD function
> from LocalApicLib, so that it may be used by MpInitLib or any other module that
> consumes LocalApicLib.
> 
> Alternatively, we considered creating a new library, but opted against it as
> that would incur quite a bit of churning across modules that consume MpInitLib.
> 
> BTW, reading the PlatformId MSR was already being done by MicrocodeDetect(),
> but it never affected AMD-based platforms as the flow never gets that far, since
> the Detect routine bails out early when it finds the size of the patch is zero.
> 
> 
> Leo Duran (2):
>   UefiCpuPkg: LocalApicLib: Export StandardSignatureIsAuthenticAMD
>     function
>   UefiCpuPkg: MpInitLib: Exclude code no pertinent to AMD processors.
> 
>  UefiCpuPkg/Include/Library/LocalApicLib.h          | 15 +++++++
>  UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c     | 47 +++++++++++-----------
>  .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c        | 47 +++++++++++-----------
>  UefiCpuPkg/Library/MpInitLib/Microcode.c           | 17 +++++++-
>  UefiCpuPkg/Library/MpInitLib/MpLib.c               | 11 ++++-
>  5 files changed, 87 insertions(+), 50 deletions(-)
> 

from my perspective I'm OK with this approach:

Acked-by: Laszlo Ersek <lersek@redhat.com>

but Ray and Eric have the final word on this, of course.

Thanks
Laszlo