public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Anthony PERARD via groups.io" <anthony.perard=citrix.com@groups.io>
To: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>, Julien Grall <julien@xen.org>
Subject: Re: [edk2-devel] [PATCH 3/4] OvmfPkg: Remove applicationProcessorEntryPoint
Date: Mon, 24 Jul 2023 11:17:09 +0100	[thread overview]
Message-ID: <aad9ef7f-16be-44e1-ad18-59d766f38cf0@perard> (raw)
In-Reply-To: <20230710031706.1329-4-zhiguang.liu@intel.com>

On Mon, Jul 10, 2023 at 11:17:05AM +0800, Zhiguang Liu wrote:
> diff --git a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm
> index 56749bdbc9..67156d8252 100644
> --- a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm
> +++ b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm
> @@ -39,23 +39,13 @@ xenPVHEntryPoint:
>  
>  BITS    16
>  ALIGN   16
> -
> -applicationProcessorEntryPoint:
> -;
> -; Application Processors entry point
>  ;
> -; GenFv generates code aligned on a 4k boundary which will jump to this
> -; location.  (0xffffffe0)  This allows the Local APIC Startup IPI to be
> -; used to wake up the application processors.
> +; 0xffffffe0
>  ;
> -    jmp     EarlyApInitReal16
> -
> -ALIGN   8
> -
> -    DD      0
> +   DD      0, 0, 0
>  
>  ;
> -; The VTF signature
> +; The VTF signature (0xffffffec)
>  ;
>  ; VTF-0 means that the VTF (Volume Top File) code does not require
>  ; any fixups.


I've tested that part of the patch. OvmfXen seems to work fine with it:

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107167): https://edk2.groups.io/g/devel/message/107167
Mute This Topic: https://groups.io/mt/100051790/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-07-24 10:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10  3:17 [PATCH 0/4] Remove AP waking vector in Reset Vector Zhiguang Liu
2023-07-10  3:17 ` [PATCH 1/4] BaseTools: Remove logic to create AP waking vector in GenFv Zhiguang Liu
2023-07-10 11:38   ` 回复: [edk2-devel] " gaoliming
2023-07-10  3:17 ` [PATCH 2/4] UefiCpuPkg/SecCore: Remove AP waking Vector logic in SecCore Zhiguang Liu
2023-07-10  3:17 ` [PATCH 3/4] OvmfPkg: Remove applicationProcessorEntryPoint Zhiguang Liu
2023-07-24 10:17   ` Anthony PERARD via groups.io [this message]
2023-07-10  3:17 ` [PATCH 4/4] UefiCpuPk/ResetVector: Remove AP waking vector from ResetVector Zhiguang Liu
2023-07-10  3:35 ` [edk2-devel] [PATCH 0/4] Remove AP waking vector in Reset Vector Ni, Ray
     [not found] ` <1770634CE62FBB6D.7145@groups.io>
2023-07-24  2:47   ` [edk2-devel] [PATCH 3/4] OvmfPkg: Remove applicationProcessorEntryPoint Zhiguang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aad9ef7f-16be-44e1-ad18-59d766f38cf0@perard \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox