Re: [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

["Laszlo Ersek" <lersek@redhat.com>]

Hi Anthony,

On 07/04/19 16:41, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.platform-xen-pvh-v3
> 
> Hi,
> 
> I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc
> with the goal to make it work on both Xen HVM and Xen PVH.
> 
> The first few patches only create the platform and duplicate some code from
> OvmfPkg and the later patches makes OVMF boot in a Xen PVH guest and can boot
> a Linux guest.
> 
> After this patch series, I'd like to wait a bit before removing Xen support
> from the OvmfPkg*.dsc, to allow time to switch to the new Xen only platform,
> maybe 1 year.
> 
> To build and boot:
> 
> To build, simply run OvmfPkg/build.sh -p OvmfPkg/OvmfXen.dsc
> Then use OVMF.fd as a kernel of a pvh guest config file (with xl/libxl).
> 
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.platform-xen-pvh-v3

The patches on the list are malformed. They have

Content-Transfer-Encoding: quoted-printable

which is fine, in itself; however, they have CR-CR-LF line terminators.

For example, from the first patch:

diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/L=
ibrary/ResetSystemLib/ResetSystemLib.inf
index 7c44f99a5c..2f24dac87f 100644
--- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
+++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
@@ -30,4 +30,5 @@ [Packages]
 [LibraryClasses]=0D=0D
   DebugLib=0D=0D
   IoLib=0D=0D
+  PciLib=0D=0D
   TimerLib=0D=0D

Note "=0D=0D".

Your other (recent) patches,

- [edk2-devel] [PATCH v2]
  OvmfPkg/XenBusDxe: Close XenIoProtocol openned by children

- [edk2-devel] [PATCH]
  OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop()

had the same problem; I had to use "--ignore-whitespace" with git-am, to
apply them.

Now, if I try to apply this full set with git-am like that, the first
patch in the series applies, but the second still fails:

> error: corrupt patch at line 23
> Patch failed at 0002 OvmfPkg: Create platform OvmfXen

Based on the email headers, the "iphmx.com" references suggest (via a
google search) "Cisco's Ironport Cloud email service".

I think that email service (MTA) is broken.

I decoded your emails (from quoted-printable to 8-bit plaintext),
removed the "Content-Transfer-Encoding" lines, and replaced '\r\r' with
'\r'. This way, git-am completed (with some "new blank line at EOF"
warnings). Applying the "processed" patches on top of commit
a7c7d21ffa9a, the resultant tree is identical to your tree at
"br.platform-xen-pvh-v3" branch (commit e8795d185875). In addition, I ran

$ git range-diff a7c7d21ffa9a \
      xen_pvh_anthony_v3 \
      xen_pvh_anthony_v3_from_email

and the only differences reported by that command were the "Message-Id"
tags appended to the commit messages by my "git-am" invocation. (I have
"am.messageid" set to to "true".)

I like to perform this sanity check when a patch series doesn't apply
as-is (without local tweaking) from the list, but there is a remote
topic branch to fetch (i.e. when there are two things I can compare). So
in this case, the sanity check passed fine; I can now look at the
patches themselves.

If you could use a different MTA (or get the current one fixed), that
would be helpful. (Yes, yes: if the edk2 project didn't use CRLF line
terminators, that would be *even more* helpful.)

Thanks
Laszlo