From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 05 Jul 2019 05:21:27 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1287D308216C; Fri, 5 Jul 2019 12:21:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-244.ams2.redhat.com [10.36.116.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id 352C18479E; Fri, 5 Jul 2019 12:21:14 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Ard Biesheuvel , Jordan Justen , Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20190704144233.27968-1-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 5 Jul 2019 14:21:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190704144233.27968-1-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 05 Jul 2019 12:21:24 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Anthony, On 07/04/19 16:41, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.platform-xen-pvh-v3 > > Hi, > > I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc > with the goal to make it work on both Xen HVM and Xen PVH. > > The first few patches only create the platform and duplicate some code from > OvmfPkg and the later patches makes OVMF boot in a Xen PVH guest and can boot > a Linux guest. > > After this patch series, I'd like to wait a bit before removing Xen support > from the OvmfPkg*.dsc, to allow time to switch to the new Xen only platform, > maybe 1 year. > > To build and boot: > > To build, simply run OvmfPkg/build.sh -p OvmfPkg/OvmfXen.dsc > Then use OVMF.fd as a kernel of a pvh guest config file (with xl/libxl). > > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.platform-xen-pvh-v3 The patches on the list are malformed. They have Content-Transfer-Encoding: quoted-printable which is fine, in itself; however, they have CR-CR-LF line terminators. For example, from the first patch: diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/L= ibrary/ResetSystemLib/ResetSystemLib.inf index 7c44f99a5c..2f24dac87f 100644 --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf @@ -30,4 +30,5 @@ [Packages] [LibraryClasses]=0D=0D DebugLib=0D=0D IoLib=0D=0D + PciLib=0D=0D TimerLib=0D=0D Note "=0D=0D". Your other (recent) patches, - [edk2-devel] [PATCH v2] OvmfPkg/XenBusDxe: Close XenIoProtocol openned by children - [edk2-devel] [PATCH] OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop() had the same problem; I had to use "--ignore-whitespace" with git-am, to apply them. Now, if I try to apply this full set with git-am like that, the first patch in the series applies, but the second still fails: > error: corrupt patch at line 23 > Patch failed at 0002 OvmfPkg: Create platform OvmfXen Based on the email headers, the "iphmx.com" references suggest (via a google search) "Cisco's Ironport Cloud email service". I think that email service (MTA) is broken. I decoded your emails (from quoted-printable to 8-bit plaintext), removed the "Content-Transfer-Encoding" lines, and replaced '\r\r' with '\r'. This way, git-am completed (with some "new blank line at EOF" warnings). Applying the "processed" patches on top of commit a7c7d21ffa9a, the resultant tree is identical to your tree at "br.platform-xen-pvh-v3" branch (commit e8795d185875). In addition, I ran $ git range-diff a7c7d21ffa9a \ xen_pvh_anthony_v3 \ xen_pvh_anthony_v3_from_email and the only differences reported by that command were the "Message-Id" tags appended to the commit messages by my "git-am" invocation. (I have "am.messageid" set to to "true".) I like to perform this sanity check when a patch series doesn't apply as-is (without local tweaking) from the list, but there is a remote topic branch to fetch (i.e. when there are two things I can compare). So in this case, the sanity check passed fine; I can now look at the patches themselves. If you could use a different MTA (or get the current one fixed), that would be helpful. (Yes, yes: if the edk2 project didn't use CRLF line terminators, that would be *even more* helpful.) Thanks Laszlo