From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.11583.1597226749968862537 for ; Wed, 12 Aug 2020 03:05:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bJWRfGqp; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597226749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVxuZ4FL7QAmr3W7PlREYkqKVMIHEyeTsWCkfDRRa2Q=; b=bJWRfGqpM9Zs32zKpngL8geYygcHkUlZaBZ2+ScwMNhxtYm1wjsoogOra0+/yAUyvh2Xt/ ujkXCVeiFNU088wREU4++FaN5DBPiTuJY+I0ryPGtgRZ2xZ8+v39Tw3iNWjbZlwAakKgue mgsDqW5Tl+hT4uIlgr31Xc+3DnBcz9M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-T-Y-jbIdPBiNJ0WHtj32ag-1; Wed, 12 Aug 2020 06:05:45 -0400 X-MC-Unique: T-Y-jbIdPBiNJ0WHtj32ag-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1DB4D800FEC; Wed, 12 Aug 2020 10:05:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-34.ams2.redhat.com [10.36.114.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 391D85F9DF; Wed, 12 Aug 2020 10:05:43 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto To: Matthew Carlson , devel@edk2.groups.io, Rebecca Cran References: <13469.1597199256202235840@groups.io> From: "Laszlo Ersek" Message-ID: Date: Wed, 12 Aug 2020 12:05:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <13469.1597199256202235840@groups.io> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit (+Rebecca) On 08/12/20 04:27, macarl via [] wrote: > Thank you for the helpful comments Lazlo! > > I sent out an updated series (v5) that fixes the things you mentioned. I added more description, so hopefully that helps. > > Sorry I didn't notice BhyvePkg, I thought you couldn't have packages under other packages, so I didn't think to check for other DSC's. It should be fixed up like the other Ovmf DSC's. Right, with Bhyve we indeed broke the DEC spec first, having two DEC files under OvmfPkg (this was reported by Sean). The issue was fixed in commit e557442e3f7e; since then, bhyve is not a new package nested under OvmfPkg (which is invalid), just a separate platform DSC. Arguably, the "Pkg" infix in the following file names: Bhyve/BhyvePkgDefines.fdf.inc Bhyve/BhyvePkgX64.dsc Bhyve/BhyvePkgX64.fdf remains a bit confusing, and should indeed be removed: Bhyve/BhyveDefines.fdf.inc Bhyve/BhyveX64.dsc Bhyve/BhyveX64.fdf Rebecca, could you please submit a patch with such renames? > I've been following your excellent guide for sending mailing list patches (Lazlo's Guide). ( https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers ) Is there a better way to get all the CC's from all the patches other than just copy and pasting them all? Perhaps the GetMaintainers.py where you specify multiple commits? Specifying a range didn't produce the desired behavior. For collecting the full CC set for the cover letter, one possibility is: $ git log master..topic \ | grep '^Cc:' \ | sort -u and then cut n' paste the result of this command into the cover letter. (I assume even on Windows the above command should work in WSL or Cygwin.) Thanks! Laszlo