From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 64DD6D80A5F for ; Wed, 6 Mar 2024 21:09:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DOO6aUlT05JzHL43h6VNBgFl6Gv8gBK32bIESyWZH2U=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709759381; v=1; b=2E1ZfPqO0uxTCuYTgK58bclUAhBcM3kBuM8YBBlARQGwD2/V/h0noS8vHjLT4zArd4/cexCI KWasKUcObksGpOC/s+pq+ETfEAQcBR4MBOjlbUeW78TOXBfv8ano/omxOPIrlAS573BiMAQHaYX eI3V5PD261B6XRCLox0Nealr316oYgZnknDmTJKyMflWBGDCcS/A6a6msTOIEnVZfHvUzN8GuMZ oxTVQuZvC34gDOGuc2qOVvyHoUFcmGl2d/ASt+6b+MqM97YRydOwX9/fmceUQd/XcQbb4T478ig cKL3z2Z/N1wdB4EBncqEbzfd7+KywGSNDVyHHMy7/tTzw== X-Received: by 127.0.0.2 with SMTP id VMkGYY7687511xYVCxtkcYsm; Wed, 06 Mar 2024 13:09:41 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7265.1709759380363199254 for ; Wed, 06 Mar 2024 13:09:40 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-05DVbNLgP7GlzcccaQhSTw-1; Wed, 06 Mar 2024 16:09:36 -0500 X-MC-Unique: 05DVbNLgP7GlzcccaQhSTw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F0C4F3C0CEE2; Wed, 6 Mar 2024 21:09:35 +0000 (UTC) X-Received: from [10.39.192.14] (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6E9032166AE8; Wed, 6 Mar 2024 21:09:35 +0000 (UTC) Message-ID: Date: Wed, 06 Mar 2024 13:09:40 -0800 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Andrew Fish , Ray Ni Reply-To: devel@edk2.groups.io,lersek@redhat.com References: <20240305113843.68812-1-lersek@redhat.com> <20240305113843.68812-8-lersek@redhat.com> In-Reply-To: <20240305113843.68812-8-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uE6KNXnvIWL39lKpfB2nM4v3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=2E1ZfPqO; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) Can I please get a quick R-b for this patch -- it's urgent because of . Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). >=20 > Build-tested with: >=20 > build -a X64 -b DEBUG -m EmulatorPkg/Sec/Sec.inf \ > -p EmulatorPkg/EmulatorPkg.dsc -t GCC5 >=20 > Cc: Andrew Fish > Cc: Ray Ni > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 > Signed-off-by: Laszlo Ersek > --- > EmulatorPkg/Sec/Sec.inf | 2 +- > EmulatorPkg/Sec/Sec.h | 9 --------- > 2 files changed, 1 insertion(+), 10 deletions(-) >=20 > diff --git a/EmulatorPkg/Sec/Sec.inf b/EmulatorPkg/Sec/Sec.inf > index 2f9e3d4780cc..7476094f1305 100644 > --- a/EmulatorPkg/Sec/Sec.inf > +++ b/EmulatorPkg/Sec/Sec.inf > @@ -11,7 +11,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D EmuSec > FILE_GUID =3D BCAF98C9-22B0-3B4F-9CBD-C8A6B4DBCEE= 9 > MODULE_TYPE =3D SEC > diff --git a/EmulatorPkg/Sec/Sec.h b/EmulatorPkg/Sec/Sec.h > index 29272a29ffa5..94689eb41d35 100644 > --- a/EmulatorPkg/Sec/Sec.h > +++ b/EmulatorPkg/Sec/Sec.h > @@ -20,15 +20,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > #include > =20 > -// > -// I think this should be defined in a MdePkg include file? > -// > -VOID > -EFIAPI > -ProcessLibraryConstructorList ( > - VOID > - ); > - > EFI_STATUS > EFIAPI > SecTemporaryRamSupport ( >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116455): https://edk2.groups.io/g/devel/message/116455 Mute This Topic: https://groups.io/mt/104742527/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-