From: Jeff Westfahl <jeff.westfahl@ni.com>
To: <edk2-devel@lists.01.org>
Cc: Jeff Westfahl <jeff.westfahl@ni.com>,
Ruiyu Ni <ruiyu.ni@intel.com>,
"Jaben Carsey" <jaben.carsey@intel.com>
Subject: [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage
Date: Tue, 14 Mar 2017 16:02:01 -0500 [thread overview]
Message-ID: <ab21d66a74dd7bdfa203e367d59a3a4018d21e0a.1489525307.git.jeff.westfahl@ni.com> (raw)
The format specifier for the LoadOptions field of the LoadedImage protocol
is "%s". However, the data in LoadOptions is often generic binary data. A
format specifier of "%x" is more appropriate for this field.
Using "dh -v" with format specifier "%s" on BIOS images based on EDK II
source before commit 891d844 can cause a crash.
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com>
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
index 0d51627..273a420 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
@@ -354,7 +354,7 @@
" DeviceHandle..: %%H%x%%N\r\n"
" FilePath......: %%H%x%%N\r\n"
" OptionsSize...: %%H%x%%N\r\n"
- " LoadOptions...: %%H%s%%N\r\n"
+ " LoadOptions...: %%H%x%%N\r\n"
" ImageBase.....: %%H%x%%N\r\n"
" ImageSize.....: %%H%Lx%%N\r\n"
" CodeType......: %%H%s%%N\r\n"
--
2.7.4
next reply other threads:[~2017-03-14 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 21:02 Jeff Westfahl [this message]
2017-03-15 20:37 ` [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage Carsey, Jaben
2017-03-15 21:08 ` Jeff Westfahl
2017-03-15 22:28 ` Carsey, Jaben
2017-03-16 5:33 ` Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab21d66a74dd7bdfa203e367d59a3a4018d21e0a.1489525307.git.jeff.westfahl@ni.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox