public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
Date: Thu, 12 Oct 2017 09:13:11 +0200	[thread overview]
Message-ID: <ab2990d5-2dfd-6f56-8e99-c0b91e42daae@redhat.com> (raw)
In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3B9A25D1@shsmsx102.ccr.corp.intel.com>

On 10/12/17 04:00, Bi, Dandan wrote:
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
> 
> -----Original Message-----
> From: Wang, Jian J 
> Sent: Thursday, October 12, 2017 9:04 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> index f42c13cd89..d249479c56 100644
> --- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> +++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> @@ -59,9 +59,6 @@ LegacyBiosInt86 (
>  {
>    UINT16                Segment;
>    UINT16                Offset;
> -  LEGACY_BIOS_INSTANCE  *Private;
> -
> -  Private = LEGACY_BIOS_INSTANCE_FROM_THIS (This);
>  
>    Regs->X.Flags.Reserved1 = 1;
>    Regs->X.Flags.Reserved2 = 0;
> 

Looks like this has been committed already; thank you guys for the quick
action!

Laszlo


      reply	other threads:[~2017-10-12  7:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12  1:04 [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning Jian J Wang
2017-10-12  2:00 ` Bi, Dandan
2017-10-12  7:13   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab2990d5-2dfd-6f56-8e99-c0b91e42daae@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox