* [edk2-devel] [PATCH] Package/Module: edk2-platforms\Features\Intel\UserInterface\UserAuthFeaturePkg
@ 2024-03-18 12:18 Nayana Patel
0 siblings, 0 replies; only message in thread
From: Nayana Patel @ 2024-03-18 12:18 UTC (permalink / raw)
To: devel; +Cc: bhavana.s, tabassum.yasmin, Nayana Patel
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4645
Clear out the variable SmmCommunicateSetPassword which contains password before goto Exit.
To avoid vulnerability.
Signed-off-by: Nayana Patel <nayana.patel@intel.com>
---
.../UserAuthenticationDxeSmm/UserAuthenticationSmm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/UserAuthenticationSmm.c b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/UserAuthenticationSmm.c
index 98f40c1812..8d7c018688 100644
--- a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/UserAuthenticationSmm.c
+++ b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/UserAuthenticationSmm.c
@@ -499,6 +499,7 @@ SmmPasswordHandler (
if (PasswordLen == sizeof(SmmCommunicateSetPassword.OldPassword)) {
DEBUG ((DEBUG_ERROR, "SmmPasswordHandler: OldPassword invalid!\n"));
Status = EFI_INVALID_PARAMETER;
+ ZeroMem (&SmmCommunicateSetPassword, sizeof (SmmCommunicateSetPassword));
goto EXIT;
}
@@ -510,6 +511,7 @@ SmmPasswordHandler (
} else {
Status = EFI_SECURITY_VIOLATION;
}
+ ZeroMem (&SmmCommunicateSetPassword, sizeof (SmmCommunicateSetPassword));
goto EXIT;
}
--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116869): https://edk2.groups.io/g/devel/message/116869
Mute This Topic: https://groups.io/mt/105014793/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-18 23:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-18 12:18 [edk2-devel] [PATCH] Package/Module: edk2-platforms\Features\Intel\UserInterface\UserAuthFeaturePkg Nayana Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox