public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Use central definitions for EFI_VARIABLE_*
@ 2017-12-15 16:59 Leif Lindholm
  2017-12-15 16:59 ` [PATCH v2 1/3] MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined Leif Lindholm
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Leif Lindholm @ 2017-12-15 16:59 UTC (permalink / raw)
  To: edk2-devel
  Cc: Michael D Kinney, Liming Gao, Ard Biesheuvel, Star Zeng,
	Eric Dong

The set of variable attribute definitions in <Uefi/UefiMultiPhase.h> is
used by C code, but VfrCompile does not seem happy with parts of that
header file.

Long-term, this should probably be fixed in VfrCompile, but a simple
solution for now is to conditionalise the complicating segments of
UefiMultiPhase.h on !VFRCOMPILE and include this directly in .vfr source.                             

v1 -> v2:
Instead of breaking parts of UefiMultiPhase.h out into a new header,
conditionalise the problematic bits on !VFRCOMPILE.

Leaving out the reviewed-bys on 2/3 since the underlying mechanism
changes...

Leif Lindholm (3):
  MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined
  MdeModulePkg: use central variable definitions in DriverSampleDxe
  EmbeddedPkg: use central variable definitions in .vfr files

 EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefHii.vfr |  9 +---
 EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformHii.vfr   |  9 +---
 MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr        |  9 +---
 MdePkg/Include/Uefi/UefiMultiPhase.h                  | 44 ++++++++++----------
 4 files changed, 26 insertions(+), 45 deletions(-)

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>            
-- 
2.11.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-02-23 14:18 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 16:59 [PATCH v2 0/3] Use central definitions for EFI_VARIABLE_* Leif Lindholm
2017-12-15 16:59 ` [PATCH v2 1/3] MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined Leif Lindholm
2017-12-17 11:23   ` Zeng, Star
2018-02-22 20:09     ` Leif Lindholm
2018-02-23  2:33       ` Zeng, Star
2018-02-23 10:25         ` Gao, Liming
2018-02-23 14:24           ` Leif Lindholm
2018-02-23 11:40         ` Leif Lindholm
2017-12-15 16:59 ` [PATCH v2 2/3] MdeModulePkg: use central variable definitions in DriverSampleDxe Leif Lindholm
2017-12-17 11:20   ` Zeng, Star
2017-12-15 16:59 ` [PATCH v2 3/3] EmbeddedPkg: use central variable definitions in .vfr files Leif Lindholm
2018-02-22 16:33   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox