From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::332; helo=mail-wm1-x332.google.com; envelope-from=julien.grall@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F41F211B6C17 for ; Thu, 17 Jan 2019 10:59:20 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id y185so1754351wmd.1 for ; Thu, 17 Jan 2019 10:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fGkG4Wsq34ckYBZcUUi1JGzcVzDSKO3tASLu+Y1vvnc=; b=IXJpvurXO0NLy0OSPzN3T/iLv4Dyw5br6389k6KSCiDNGqn9QFD78jqDOy9sB8abmy g8sfeEVXvhu/S+hrrKXerY78pDzUgpRhhSDqlTKHhB85lDMPb4Y1QbZKMemkHlvnDEze Bo1etX7bX6RRm+y16DCgncoRHd6NolXQdZgcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fGkG4Wsq34ckYBZcUUi1JGzcVzDSKO3tASLu+Y1vvnc=; b=HDFtfJNRF09vTsg5nczoeFwrGXq+APSSbCaN0I/KyJ/vEXudu+9eYOaB68fNnSThBD yYOO9vepq7vSTK2CaGipyCxH9KdQkNrgxRUQ52W1q2d2lp9BMAkmeMRU+jzEn9ePWqT6 4qjOKv6LHP3h48sSu5uonoYLQwU9uCnu25tjxySsjPbcLD0zq/SZ5Uw3u+bArp0CcTEQ 7HH9xeE7aMjKdSDJAY/WPr7l+boml2D7UTMd7wBlonuOE2MOVwiYL0Fisd4JdLu6WxyM A6sEvgi49tU2BWOKGjJBJbGCaKOIzjrWZby/ukKkqr+OCPdZNLyj88lnlzu3fzUUVVnR w65Q== X-Gm-Message-State: AJcUukcN5qj/CrypT7is2s87VrtlGQzOIrKoZVRlsoYCCPs2+mXTcjSH qSehGyJe+mZfpWXhp8RrIjfkHI2UQS4= X-Google-Smtp-Source: ALg8bN5SYJGSfKFM50QlP62HhYLxs3bff3XZS5rJ2LUsSaz+5YhC6N5rbTQRZwR7JeS48qSpjSaEQQ== X-Received: by 2002:a1c:20cb:: with SMTP id g194mr12611087wmg.77.1547751558590; Thu, 17 Jan 2019 10:59:18 -0800 (PST) Received: from ?IPv6:::1? ([206.189.23.0]) by smtp.gmail.com with ESMTPSA id d2sm71377354wrs.97.2019.01.17.10.59.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 10:59:17 -0800 (PST) To: "Zeng, Star" , Laszlo Ersek Cc: edk2-devel@lists.01.org References: <1547479196-40248-1-git-send-email-star.zeng@intel.com> <1547479196-40248-11-git-send-email-star.zeng@intel.com> <7da72765-785c-2499-eefd-d887a946c946@redhat.com> <6263ebd0-4c6a-97bd-7e04-c4f26ec21aa2@linaro.org> <01237fea-c440-a810-eb51-45646f26238e@intel.com> From: Julien Grall Message-ID: Date: Thu, 17 Jan 2019 18:59:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <01237fea-c440-a810-eb51-45646f26238e@intel.com> Subject: Re: [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 18:59:21 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Star, On 17/01/2019 01:26, Zeng, Star wrote: > On 2019/1/16 22:26, Julien Grall wrote: >> Hi Laszlo, >> >> On 15/01/2019 09:37, Laszlo Ersek wrote: >>> On 01/14/19 16:19, Star Zeng wrote: >>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 >>>> Merge EmuVariable and Real variable driver. >>>> >>>> The real variable driver has been updated to support emulated >>>> variable NV mode and the EmuVariableRuntimeDxe will be removed >>>> later, so use merged variable driver for emulated NV mode. >>>> >>>> Cc: Laszlo Ersek >>>> Cc: Ard Biesheuvel >>>> Cc: Julien Grall >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Star Zeng >>>> --- >>>>   ArmVirtPkg/ArmVirtXen.dsc | 9 +++++++-- >>>>   ArmVirtPkg/ArmVirtXen.fdf | 4 ++-- >>>>   2 files changed, 9 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc >>>> index a29d8a4ae717..db85fb3402d0 100644 >>>> --- a/ArmVirtPkg/ArmVirtXen.dsc >>>> +++ b/ArmVirtPkg/ArmVirtXen.dsc >>>> @@ -1,7 +1,7 @@ >>>>   # >>>>   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved. >>>>   #  Copyright (c) 2014, Linaro Limited. All rights reserved. >>>> -#  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>>>> +#  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
>>>>   # >>>>   #  This program and the accompanying materials >>>>   #  are licensed and made available under the terms and conditions of the >>>> BSD License >>>> @@ -101,6 +101,11 @@ [PcdsFixedAtBuild.common] >>>>     # Set terminal type to TtyTerm, the value encoded is EFI_TTY_TERM_GUID >>>>     gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer|{0x80, 0x6d, 0x91, >>>> 0x7d, 0xb1, 0x5b, 0x8c, 0x45, 0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94} >>>> +  # >>>> +  # Make VariableRuntimeDxe work at emulated non-volatile variable mode. >>>> +  # >>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE >>>> + >>>>   [PcdsPatchableInModule.common] >>>>     # >>>>     # This will be overridden in the code >>>> @@ -172,7 +177,7 @@ [Components.common] >>>>     MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf >>>>     MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf >>>> - MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf >>>> +  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf >>>> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf >>>> >>>> MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf >>>> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf >>>> index 50e670254d52..5655c0df2926 100644 >>>> --- a/ArmVirtPkg/ArmVirtXen.fdf >>>> +++ b/ArmVirtPkg/ArmVirtXen.fdf >>>> @@ -1,7 +1,7 @@ >>>>   # >>>>   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved. >>>>   #  Copyright (c) 2014, Linaro Limited. All rights reserved. >>>> -#  Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
>>>> +#  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
>>>>   # >>>>   #  This program and the accompanying materials >>>>   #  are licensed and made available under the terms and conditions of the >>>> BSD License >>>> @@ -137,7 +137,7 @@ [FV.FvMain] >>>>     INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf >>>>     INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf >>>> -  INF MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf >>>> +  INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf >>>>     INF >>>> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf >>>> >>>>     INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf >>>> >>> >>> Reviewed-by: Laszlo Ersek >>> >>> Julien, can you please regression test this series on Xen? The repo URL >>> and the branch name are in the blurb. >> >> I will have a try and let you know the result. > > Thank you, Julien. > I think you can try based on V3 series although there is no essential difference > between V2 and V3. :) > > Repo: git@github.com:lzeng14/edk2.git > Branch: MergedVariableDriver_EmuNvMode_V3 Thank you for the link. I am having trouble to get newer UEFI (without your patch) running in a Xen guest. I have an old binary working. I am not entirely sure why, I will let you know when I can test your series. Cheers, -- Julien Grall